[GitHub] harley2011 commented on issue #1254: Duplicate traceid in different request

2018-05-22 Thread GitBox
harley2011 commented on issue #1254: Duplicate traceid in different request URL: https://github.com/apache/incubator-skywalking/issues/1254#issuecomment-390916264 I need to rewrite the class of "com.github.danielwegener.logback.kafka.KafkaAppender"?

[GitHub] coveralls commented on issue #1252: Update release doc and related script

2018-05-22 Thread GitBox
coveralls commented on issue #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252#issuecomment-390857578 [![Coverage Status](https://coveralls.io/builds/17102332/badge)](https://coveralls.io/builds/17102332) Coverage

[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-22 Thread GitBox
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390936276 Promise This is an automated

[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-22 Thread GitBox
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390936276 Promise This is an automated

[GitHub] coveralls commented on issue #1252: Update release doc and related script

2018-05-22 Thread GitBox
coveralls commented on issue #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252#issuecomment-390857578 [![Coverage Status](https://coveralls.io/builds/17108683/badge)](https://coveralls.io/builds/17108683) Coverage

[GitHub] wu-sheng commented on issue #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu…

2018-05-22 Thread GitBox
wu-sheng commented on issue #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu… URL: https://github.com/apache/incubator-skywalking-ui/pull/172#issuecomment-391181889 @ajanthan Look like your CI fails.

[GitHub] candyleer commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-22 Thread GitBox
candyleer commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391214448 ok,I will test in last case This is an

[GitHub] xjr100419 opened a new issue #1257: TraceContext.traceId() [Ignored Trace]

2018-05-22 Thread GitBox
xjr100419 opened a new issue #1257: TraceContext.traceId() [Ignored Trace] URL: https://github.com/apache/incubator-skywalking/issues/1257 __ ### Question TraceContext.traceId() return [Ignored Trace] SkyWalking3.2.6 window centos7 jkd8 in spring cloud .I have many

[GitHub] peng-yongsheng closed pull request #1252: Update release doc and related script

2018-05-22 Thread GitBox
peng-yongsheng closed pull request #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252 This is an automated message from the Apache Git Service. To respond to the

[GitHub] ascrutae commented on issue #1258: Segment buffer pre read failure

2018-05-22 Thread GitBox
ascrutae commented on issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258#issuecomment-391208222 Cloud you describe you demo more detail? It is important to help us to locate this issue.

[GitHub] wu-sheng commented on issue #1258: Segment buffer pre read failure

2018-05-22 Thread GitBox
wu-sheng commented on issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258#issuecomment-391212292 @peng-yongsheng could you consider to ignore and abandon traces can't be analysis? And just log it.

[GitHub] coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-22 Thread GitBox
coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391136082 [![Coverage Status](https://coveralls.io/builds/17118537/badge)](https://coveralls.io/builds/17118537)

[GitHub] dinggel opened a new issue #1258: Segment buffer pre read failure

2018-05-22 Thread GitBox
dinggel opened a new issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258 __ ### Question - What do you want to know? Make a mistake every three seconds: 2018-05-23 10:44:37,174 -

[GitHub] coveralls commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-22 Thread GitBox
coveralls commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391208952 [![Coverage Status](https://coveralls.io/builds/17118181/badge)](https://coveralls.io/builds/17118181)

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-22 Thread GitBox
coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290 [![Coverage

[GitHub] peng-yongsheng commented on issue #1258: Segment buffer pre read failure

2018-05-22 Thread GitBox
peng-yongsheng commented on issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258#issuecomment-391216708 Single segment contains multiple entry span planning support in 5.0.0-beta2 version. So ignore this exception.

[GitHub] ascrutae opened a new pull request #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-22 Thread GitBox
ascrutae opened a new pull request #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ]

[GitHub] ajanthan opened a new pull request #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu…

2018-05-22 Thread GitBox
ajanthan opened a new pull request #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu… URL: https://github.com/apache/incubator-skywalking-ui/pull/172 Fixing issue[1231](https://github.com/apache/incubator-skywalking/issues/1231). Enabling trace search by status

[GitHub] coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-22 Thread GitBox
coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391136082 [![Coverage Status](https://coveralls.io/builds/17113658/badge)](https://coveralls.io/builds/17113658)

[GitHub] wu-sheng commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-22 Thread GitBox
wu-sheng commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391163251 Thanks and look forward to have this soon. This

[GitHub] wu-sheng commented on a change in pull request #1252: Update release doc and related script

2018-05-22 Thread GitBox
wu-sheng commented on a change in pull request #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252#discussion_r190070122 ## File path: tools/releasing/create_source_release.sh ## @@ -20,11 +20,13 @@ # This script

[GitHub] ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-22 Thread GitBox
ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391161821 OK. Let me change Ints to enum and resend the pull request.

[GitHub] wu-sheng commented on issue #1250: Dashboard to Service page Error

2018-05-22 Thread GitBox
wu-sheng commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390890621 I am a little confused. Local span should be not part of analysis, and if EntrySpan and ExistSpan are in different segment, then should

[GitHub] wu-sheng commented on issue #1250: Dashboard to Service page Error

2018-05-22 Thread GitBox
wu-sheng commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390895067 That is query for front and behind, but, that should not be the problem.

[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error

2018-05-22 Thread GitBox
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390880087 I read the ui codes,maybe it's caused by in `getServiceTopology ` the `nodes` don't contain the calls `source`,only `target`

[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error

2018-05-22 Thread GitBox
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390885487 Yes ,I am reading the backend method and try to fix it This is an

[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error

2018-05-22 Thread GitBox
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390885487 Yes ,I am reading the back method and try to fix it This is an

[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error

2018-05-22 Thread GitBox
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390889525 @wu-sheng I found the listener `public class ServiceReferenceMetricSpanListener implements EntrySpanListener, ExitSpanListener

[GitHub] wu-sheng closed pull request #1253: Fix NPE in Okhttp plugin when connect failed

2018-05-22 Thread GitBox
wu-sheng closed pull request #1253: Fix NPE in Okhttp plugin when connect failed URL: https://github.com/apache/incubator-skywalking/pull/1253 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error

2018-05-22 Thread GitBox
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390880087 I read the ui codes,maybe it's caused by in `getServiceTopology ` the nodes don't contain the calls `source`,only `target`

[GitHub] wu-sheng commented on issue #1250: Dashboard to Service page Error

2018-05-22 Thread GitBox
wu-sheng commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390883972 > I read the ui codes,maybe it's caused by in getServiceTopology the nodes don't contain the calls source,only target If

[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error

2018-05-22 Thread GitBox
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390889788 so that mean if we use cross thread and create exit span in it this issue may reproduce.

[GitHub] harley2011 opened a new issue #1254: traceid重复,不同请求的traceid相同问题

2018-05-22 Thread GitBox
harley2011 opened a new issue #1254: traceid重复,不同请求的traceid相同问题 URL: https://github.com/apache/incubator-skywalking/issues/1254 Hi 各位大佬: 现在我们项目集成skywalking出现不同请求traceid重复的问题,麻烦帮忙看下是什么原因,引起的谢谢。 logback配置如下: