[GitHub] ascrutae opened a new pull request #1292: Fix the interceptor class is incorrect

2018-05-30 Thread GitBox
ascrutae opened a new pull request #1292: Fix the interceptor class is incorrect URL: https://github.com/apache/incubator-skywalking/pull/1292 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided

[GitHub] wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393204351 > gRPC will blocked cause by the workers blocked which gRPC invoked. Agent has a time out mechanism. If

[GitHub] peng-yongsheng opened a new pull request #1294: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
peng-yongsheng opened a new pull request #1294: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/pull/1294 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Bug fix - [ ]

[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393194109 It's be done, testing. This is an

[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393195388 gRPC will blocked cause by the workers blocked which gRPC invoked.

[GitHub] ascrutae opened a new pull request #1293: Fix the issue that Hystrix plugin case NPE

2018-05-30 Thread GitBox
ascrutae opened a new pull request #1293: Fix the issue that Hystrix plugin case NPE URL: https://github.com/apache/incubator-skywalking/pull/1293 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature

[GitHub] wu-sheng closed pull request #1292: Fix the interceptor class is incorrect

2018-05-30 Thread GitBox
wu-sheng closed pull request #1292: Fix the interceptor class is incorrect URL: https://github.com/apache/incubator-skywalking/pull/1292 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] coveralls commented on issue #1293: Fix the issue that Hystrix plugin case NPE

2018-05-30 Thread GitBox
coveralls commented on issue #1293: Fix the issue that Hystrix plugin case NPE URL: https://github.com/apache/incubator-skywalking/pull/1293#issuecomment-393365473 [![Coverage Status](https://coveralls.io/builds/17243248/badge)](https://coveralls.io/builds/17243248) Coverage

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-30 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393365944 @wu-sheng ok, after released, I will fix and test asap This is an

[GitHub] wu-sheng commented on issue #1285: hystrix plugin bug

2018-05-30 Thread GitBox
wu-sheng commented on issue #1285: hystrix plugin bug URL: https://github.com/apache/incubator-skywalking/issues/1285#issuecomment-393365943 @xyydcoo I think this should be fixed by #1293 If you want this now, please compile the source codes from master branch, and copy this plugin.jar to

[GitHub] wu-sheng closed issue #1285: hystrix plugin bug

2018-05-30 Thread GitBox
wu-sheng closed issue #1285: hystrix plugin bug URL: https://github.com/apache/incubator-skywalking/issues/1285 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-30 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393355460 @wu-sheng we are preparing to release, maybe today or tomorrow, after released, I will resolve the conflict and test again.

[GitHub] coveralls commented on issue #1294: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
coveralls commented on issue #1294: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/pull/1294#issuecomment-393371556 [![Coverage Status](https://coveralls.io/builds/17243603/badge)](https://coveralls.io/builds/17243603)

[GitHub] wu-sheng closed pull request #1294: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
wu-sheng closed pull request #1294: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/pull/1294 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] SevenPointOld commented on issue #443: Which companies are using SkyWalking

2018-05-30 Thread GitBox
SevenPointOld commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-392719221 重庆宜迅联供应链科技有限公司 https://www.tsfinance.com.cn/ 线下环境预研中,5.0.0-beta,即将在生产试用

[GitHub] wu-sheng closed pull request #1293: Fix the issue that Hystrix plugin case NPE

2018-05-30 Thread GitBox
wu-sheng closed pull request #1293: Fix the issue that Hystrix plugin case NPE URL: https://github.com/apache/incubator-skywalking/pull/1293 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-30 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393365696 @leizhiyuan Ping me after you have done. I definitely hope this could be provided in beta2 release.

[GitHub] wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393373603 Fixed. This is an automated message from the

[GitHub] wu-sheng closed issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
wu-sheng closed issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291 This is an automated message from the Apache Git Service. To respond to the

[GitHub] xjr100419 commented on issue #1296: fix mysql Connection URL Syntax

2018-05-30 Thread GitBox
xjr100419 commented on issue #1296: fix mysql Connection URL Syntax URL: https://github.com/apache/incubator-skywalking/issues/1296#issuecomment-393400690 Connection URL Syntax: https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-reference-jdbc-url-format.html database

[GitHub] wu-sheng commented on issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
wu-sheng commented on issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393408750 @yrjjf all description should be in English. This is an automated message from the

[GitHub] xjr100419 opened a new issue #1296: fix mysql Connection URL Syntax

2018-05-30 Thread GitBox
xjr100419 opened a new issue #1296: fix mysql Connection URL Syntax URL: https://github.com/apache/incubator-skywalking/issues/1296 - Why do you submit this issue? My orm framework mysql link does not specify the database: protocol//[hosts][/database][?properties]

[GitHub] yrjjf opened a new issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
yrjjf opened a new issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ]

[GitHub] yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404721 # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with

[GitHub] yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404492 # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with

[GitHub] yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404378 package com.hsjry.monitor.sw.client.agent.define; import net.bytebuddy.description.method.MethodDescription; import

[GitHub] yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404427 // // Source code recreated from a .class file by IntelliJ IDEA // (powered by Fernflower decompiler) // package

[GitHub] yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404721 # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with

[GitHub] yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404820 tiny-rpc-3.4.7=com.hsjry.monitor.sw.client.agent.define.TinyRPCInstrumentation

[GitHub] yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404343 package com.hsjry.monitor.sw.client.agent; import com.google.common.base.MoreObjects; import

[GitHub] yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错

2018-05-30 Thread GitBox
yrjjf commented on issue #1297: tiny框架插件开发,遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404492 # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with

[GitHub] wu-sheng commented on issue #1295: This error does not know how to solve? Can anyone help me see?

2018-05-30 Thread GitBox
wu-sheng commented on issue #1295: This error does not know how to solve? Can anyone help me see? URL: https://github.com/apache/incubator-skywalking/issues/1295#issuecomment-393392205 I am not familiar with Eclipse env. Also in IntelliJ. We already provided document about how to build

[GitHub] wu-sheng commented on issue #1295: This error does not know how to solve? Can anyone help me see?

2018-05-30 Thread GitBox
wu-sheng commented on issue #1295: This error does not know how to solve? Can anyone help me see? URL: https://github.com/apache/incubator-skywalking/issues/1295#issuecomment-393392425 And if you are not familiar with all SkyWalking project structure, I don't recommend you to start from

[GitHub] xjr100419 closed issue #1257: TraceContext.traceId() [Ignored Trace]

2018-05-30 Thread GitBox
xjr100419 closed issue #1257: TraceContext.traceId() [Ignored Trace] URL: https://github.com/apache/incubator-skywalking/issues/1257 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] liyuyun opened a new issue #1295: This error does not know how to solve? Can anyone help me see?

2018-05-30 Thread GitBox
liyuyun opened a new issue #1295: This error does not know how to solve? Can anyone help me see? URL: https://github.com/apache/incubator-skywalking/issues/1295 Exception in thread "main" java.util.ServiceConfigurationError: org.apache.skywalking.apm.collector.core.module.ModuleProvider:

[GitHub] xyydcoo opened a new issue #1285: hystrix plugin bug

2018-05-30 Thread GitBox
xyydcoo opened a new issue #1285: hystrix plugin bug URL: https://github.com/apache/incubator-skywalking/issues/1285 When I started at spring boot, there was an exception when I invoked other services through CommandLineRunner using feign, causing the service startup failure. Feign

[GitHub] xyydcoo opened a new issue #1287: kafka exception

2018-05-30 Thread GitBox
xyydcoo opened a new issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287 When I use the log4j2 output log to Kafka to produce an exception spring-kafka.version:1.1.7.RELEASE

[GitHub] kevinyyyy opened a new pull request #1286: modify launch link address to Apache

2018-05-30 Thread GitBox
kevin opened a new pull request #1286: modify launch link address to Apache URL: https://github.com/apache/incubator-skywalking/pull/1286 Please answer these questions before submitting pull request - Why submit this pull request? Bug fix - Related issues

[GitHub] ascrutae opened a new pull request #1288: Support the Chinese in config properties

2018-05-30 Thread GitBox
ascrutae opened a new pull request #1288: Support the Chinese in config properties URL: https://github.com/apache/incubator-skywalking/pull/1288 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature

[GitHub] coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-05-30 Thread GitBox
coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-392457692 [![Coverage Status](https://coveralls.io/builds/17227466/badge)](https://coveralls.io/builds/17227466) Coverage

[GitHub] wu-sheng closed pull request #1286: modify launch link address to Apache

2018-05-30 Thread GitBox
wu-sheng closed pull request #1286: modify launch link address to Apache URL: https://github.com/apache/incubator-skywalking/pull/1286 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] wu-sheng commented on issue #1285: hystrix plugin bug

2018-05-30 Thread GitBox
wu-sheng commented on issue #1285: hystrix plugin bug URL: https://github.com/apache/incubator-skywalking/issues/1285#issuecomment-393087875 @ascrutae If the hytrix makes more complex than we expected, please consider #1284 as an option. I don't want we deal too much about the across

[GitHub] coveralls commented on issue #1286: modify launch link address to Apache

2018-05-30 Thread GitBox
coveralls commented on issue #1286: modify launch link address to Apache URL: https://github.com/apache/incubator-skywalking/pull/1286#issuecomment-393103263 [![Coverage Status](https://coveralls.io/builds/17227910/badge)](https://coveralls.io/builds/17227910) Coverage

[GitHub] DevWithLin opened a new pull request #1289: Update README_ZH.md

2018-05-30 Thread GitBox
DevWithLin opened a new pull request #1289: Update README_ZH.md URL: https://github.com/apache/incubator-skywalking/pull/1289 fix Typos Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug Fix - [ ] New feature provided

[GitHub] coveralls commented on issue #1288: Support the Chinese in config properties

2018-05-30 Thread GitBox
coveralls commented on issue #1288: Support the Chinese in config properties URL: https://github.com/apache/incubator-skywalking/pull/1288#issuecomment-393115870 [![Coverage Status](https://coveralls.io/builds/17229605/badge)](https://coveralls.io/builds/17229605) Coverage

[GitHub] wu-sheng closed pull request #1288: Support the Chinese in config properties

2018-05-30 Thread GitBox
wu-sheng closed pull request #1288: Support the Chinese in config properties URL: https://github.com/apache/incubator-skywalking/pull/1288 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] coder-yqj opened a new pull request #1290: Hotfix/fixbug reids

2018-05-30 Thread GitBox
coder-yqj opened a new pull request #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290 Please answer these questions before submitting pull request - Why submit this pull request? - [√ ] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] coveralls commented on issue #1289: Update README_ZH.md

2018-05-30 Thread GitBox
coveralls commented on issue #1289: Update README_ZH.md URL: https://github.com/apache/incubator-skywalking/pull/1289#issuecomment-393120045 [![Coverage Status](https://coveralls.io/builds/17228914/badge)](https://coveralls.io/builds/17228914) Coverage remained the same at

[GitHub] wu-sheng commented on issue #1290: Hotfix/fixbug reids

2018-05-30 Thread GitBox
wu-sheng commented on issue #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290#issuecomment-393149053 @ascrutae Look like we miss a construct. Please confirm. This is an automated

[GitHub] coveralls commented on issue #1290: Hotfix/fixbug reids

2018-05-30 Thread GitBox
coveralls commented on issue #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290#issuecomment-393157904 [![Coverage Status](https://coveralls.io/builds/17230973/badge)](https://coveralls.io/builds/17230973) Coverage increased (+0.001%) to

[GitHub] wu-sheng closed pull request #1290: Hotfix/fixbug reids

2018-05-30 Thread GitBox
wu-sheng closed pull request #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng commented on issue #1290: Hotfix/fixbug reids

2018-05-30 Thread GitBox
wu-sheng commented on issue #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290#issuecomment-393164506 @coder-yqj Thanks for fixing this. This is an automated message from the Apache Git

[GitHub] coveralls commented on issue #1290: Hotfix/fixbug reids

2018-05-30 Thread GitBox
coveralls commented on issue #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290#issuecomment-393157904 [![Coverage Status](https://coveralls.io/builds/17230886/badge)](https://coveralls.io/builds/17230886) Coverage increased (+0.001%) to

[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393178581 Solution: Block the workers which cache collection's size exceed the setting. Add a configuration

[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393178581 Solution: Block the workers which cache collection's size exceed the setting. Add a configuration

[GitHub] peng-yongsheng opened a new issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
peng-yongsheng opened a new issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion

[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393178581 Solution: Block the workers which cache collection's size exceed the setting. Add a configuration

[GitHub] wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.

2018-05-30 Thread GitBox
wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393192839 @peng-yongsheng My suggestion, you should be care of the gRPC buffer too. And do you confirm you want to do this