[GitHub] candyleer commented on issue #1322: Add Client version when agent register instance

candyleer commented on issue #1322: Add Client version when agent register instance URL: https://github.com/apache/incubator-skywalking/issues/1322#issuecomment-395667816 ok,I read current code,we should add a field `agent_version` in `instance` index when instance registered, ui show

[GitHub] haotian2015 closed pull request #1329: tomcat 探针使用说明修改

haotian2015 closed pull request #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng commented on a change in pull request #1328: Modify the document

wu-sheng commented on a change in pull request #1328: Modify the document URL: https://github.com/apache/incubator-skywalking/pull/1328#discussion_r193989016 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,11 @@ CATALINA_OPTS="$CATALINA_OPTS

[GitHub] haotian2015 opened a new pull request #1330: tomcat 探针使用说明修改

haotian2015 opened a new pull request #1330: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1330 tomcat 探针使用说明修改 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng commented on a change in pull request #1328: Modify the document

wu-sheng commented on a change in pull request #1328: Modify the document URL: https://github.com/apache/incubator-skywalking/pull/1328#discussion_r193989348 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,11 @@ CATALINA_OPTS="$CATALINA_OPTS

[GitHub] hanahmily commented on issue #178: 5.0.0/beta2

hanahmily commented on issue #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178#issuecomment-395724527 @wu-sheng This PR contains all beta2 features that are confirmed one week ago, and I prefer to merge them to master now. > 1. Access control > 1.

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003 in the class `org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor` * if more than one

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003 in the class `org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor` * if more than one

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003 in the class `org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor` * if more than one

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003 in the class `org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor` * if more than one

[GitHub] wu-sheng opened a new issue #177: Consider to add access control for UI

wu-sheng opened a new issue #177: Consider to add access control for UI URL: https://github.com/apache/incubator-skywalking-ui/issues/177 If we deploy the web at internet, may face the data leak, without access control. Could you consider to add that? Attention, **this is not for

[GitHub] wu-sheng commented on issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document.

wu-sheng commented on issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document. URL: https://github.com/apache/incubator-skywalking/issues/1326#issuecomment-395668407 You can fix these things for the community. We are always welcome your

[GitHub] candyleer commented on issue #1327: Application Avg Throughput Issue

candyleer commented on issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327#issuecomment-395668746 just curious why they are not consistent This is an automated

[GitHub] wu-sheng commented on issue #1322: Add Client version when agent register instance

wu-sheng commented on issue #1322: Add Client version when agent register instance URL: https://github.com/apache/incubator-skywalking/issues/1322#issuecomment-395677014 > ok,I read current code,we should add a field agent_version in instance index when instance registered, ui show in

[GitHub] wu-sheng closed pull request #178: 5.0.0/beta2

wu-sheng closed pull request #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] wu-sheng closed issue #169: Check data for Sankey chart

wu-sheng closed issue #169: Check data for Sankey chart URL: https://github.com/apache/incubator-skywalking-ui/issues/169 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng closed issue #173: Linking heatmap of dashboard to trace search page

wu-sheng closed issue #173: Linking heatmap of dashboard to trace search page URL: https://github.com/apache/incubator-skywalking-ui/issues/173 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng closed issue #175: Filter nodes by appCode

wu-sheng closed issue #175: Filter nodes by appCode URL: https://github.com/apache/incubator-skywalking-ui/issues/175 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng closed issue #167: The format about exception stack is irregular

wu-sheng closed issue #167: The format about exception stack is irregular URL: https://github.com/apache/incubator-skywalking-ui/issues/167 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395663060 good idea This is an automated message from the Apache Git

[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor

ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395672961 The `forward` support by containers(e.g. Tomcat, jetty-server), we should modify all the containers plugin for this. > If

[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor

ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395672961 The `forward` support by containers(e.g. Tomcat, jetty-server), we should modify all the containers plugin for this. > If

[GitHub] SoberChina closed pull request #1328: Modify the document

SoberChina closed pull request #1328: Modify the document URL: https://github.com/apache/incubator-skywalking/pull/1328 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng closed pull request #170: add sofarpc icon

wu-sheng closed pull request #170: add sofarpc icon URL: https://github.com/apache/incubator-skywalking-ui/pull/170 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003 in the class `org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor` * if more than one

[GitHub] wu-sheng commented on a change in pull request #1329: tomcat 探针使用说明修改

wu-sheng commented on a change in pull request #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329#discussion_r193988001 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -30,13 +30,13 @@ New agent package looks like this： - The

[GitHub] zpf1989 opened a new issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans

zpf1989 opened a new issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332 Hello,I'm using incubator-skywalking 5.0-beta. I have a request contains many spans(almost 40),and

[GitHub] wu-sheng commented on issue #117: Can't see any traces in skywalking UI

wu-sheng commented on issue #117: Can't see any traces in skywalking UI URL: https://github.com/apache/incubator-skywalking-ui/issues/117#issuecomment-395717508 Closing. This is an automated message from the Apache Git

[GitHub] wu-sheng closed issue #117: Can't see any traces in skywalking UI

wu-sheng closed issue #117: Can't see any traces in skywalking UI URL: https://github.com/apache/incubator-skywalking-ui/issues/117 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] wu-sheng closed pull request #1331: modify the document

wu-sheng closed pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng closed issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document.

wu-sheng closed issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document. URL: https://github.com/apache/incubator-skywalking/issues/1326 This is an automated message from the Apache

[GitHub] wu-sheng commented on issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document.

wu-sheng commented on issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document. URL: https://github.com/apache/incubator-skywalking/issues/1326#issuecomment-395668282 Please feel free to submit your pr to modify the en/cn documents.

[GitHub] wu-sheng commented on issue #1327: Application Avg Throughput Issue

wu-sheng commented on issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327#issuecomment-395668005 It is calculated by UI component, I think. Is it a problem for you?

[GitHub] SoberChina opened a new pull request #1331: modify the document

SoberChina opened a new pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331 Please answer these questions before submitting pull request - Why submit this pull request? modify the document - Related issues ___ ### Bug

[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor

wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395669919 > That's right. The event is the new local span that i said. I am a little confusing, do you say forward event of http MVC

[GitHub] wu-sheng commented on a change in pull request #1331: modify the document

wu-sheng commented on a change in pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331#discussion_r193998527 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,10 @@ CATALINA_OPTS="$CATALINA_OPTS

[GitHub] candyleer opened a new issue #1327: Application Avg Throughput Issue

candyleer opened a new issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ]

[GitHub] wu-sheng commented on issue #1327: Application Avg Throughput Issue

wu-sheng commented on issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327#issuecomment-395672039 @peng-yongsheng Could you give some explanation about how does the collector calculate the throughputs of server? The UI did a

[GitHub] SoberChina opened a new pull request #1328: Modify the document

SoberChina opened a new pull request #1328: Modify the document URL: https://github.com/apache/incubator-skywalking/pull/1328 Please answer these questions before submitting pull request - Why submit this pull request? Modify the document - Related issues ___

[GitHub] wu-sheng commented on issue #1329: tomcat 探针使用说明修改

wu-sheng commented on issue #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329#issuecomment-395692551 You don't need to close every time. Just update your branch. This is an automated

[GitHub] wu-sheng commented on issue #151: Place conjecture nodes outside application topology

wu-sheng commented on issue #151: Place conjecture nodes outside application topology URL: https://github.com/apache/incubator-skywalking-ui/issues/151#issuecomment-395717743 After we provided new filter mechanism for topology map, do we still implement this? even in the future?

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395658256 wait a moment ,i will show you the reason This is an automated

[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor

wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395658112 @candyleer Could you be specific about how? Or trigger what? This

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395657915 @ascrutae @wu-sheng I have tried this solution, but this will trigger other problem

[GitHub] haotian2015 opened a new pull request #1329: tomcat 探针使用说明修改

haotian2015 opened a new pull request #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329 tomcat 探针使用说明修改 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] SoberChina commented on issue #1331: modify the document

SoberChina commented on issue #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331#issuecomment-395698847 The pr [#1330](https://github.com/apache/incubator-skywalking/pull/1330) is in conflict with me.

[GitHub] wu-sheng commented on issue #178: 5.0.0/beta2

wu-sheng commented on issue #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178#issuecomment-395725070 @hanahmily Merge is OK to me. Thise three could be considered, because @peng-yongsheng can't be ready in this week. So, consider at least one more week

[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor

wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395660899 @ascrutae What do you mean about `event should be display in the trace topology`? Event of a new local span?

[GitHub] haotian2015 opened a new issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document.

haotian2015 opened a new issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document. URL: https://github.com/apache/incubator-skywalking/issues/1326 linux 环境下，tomcat 7和tomcat8的探针配置应该是一样的，文档中tomcat8的配置应该是windows系统的配置

[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor

wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395676001 I am saying, creating span for `forward` is high payload for agent. It is not necessary. Please consider 1. Use RuntimeContext to

[GitHub] SoberChina commented on a change in pull request #1331: modify the document

SoberChina commented on a change in pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331#discussion_r194000297 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,10 @@ CATALINA_OPTS="$CATALINA_OPTS

[GitHub] wu-sheng commented on issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans

wu-sheng commented on issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332#issuecomment-395706125 I understood and received this feedback before. @hanahmily Please make the

[GitHub] hanahmily opened a new pull request #178: 5.0.0/beta2

hanahmily opened a new pull request #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178 Merge to master This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] candyleer commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor

candyleer commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#discussion_r194208823 ## File path:

[GitHub] wu-sheng commented on issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans

wu-sheng commented on issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332#issuecomment-395929732 Moved to UI issue already.

[GitHub] wu-sheng closed issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans

wu-sheng closed issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332 This is an automated message from the

[GitHub] wu-sheng closed issue #1304: UNIMPLEMENTED: Method not found: ApplicationRegisterService/applicationCodeRegister

wu-sheng closed issue #1304: UNIMPLEMENTED: Method not found: ApplicationRegisterService/applicationCodeRegister URL: https://github.com/apache/incubator-skywalking/issues/1304 This is an automated message from the Apache

[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor

ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395921149 @wu-sheng @candyleer I had change the code. and now the spring mvc plugin will not create the entry span when every forward even

[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor

ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395921149 @wu-sheng @candyleer I had change the code. and now the spring mvc plugin will not create the entry span when every forward

[GitHub] wu-sheng opened a new issue #179: Change chars to black from white in trace page

wu-sheng opened a new issue #179: Change chars to black from white in trace page URL: https://github.com/apache/incubator-skywalking-ui/issues/179 This is the feedback from community. This is an automated message from the

[GitHub] wu-sheng opened a new issue #180: Improve user experience of span detail in trace page

wu-sheng opened a new issue #180: Improve user experience of span detail in trace page URL: https://github.com/apache/incubator-skywalking-ui/issues/180 If there are many spans in trace, span detail is at the bottom of page, even can't see in default page. Need to scroll page to see.

[GitHub] wu-sheng closed issue #1279: trace graphql query error..

wu-sheng closed issue #1279: trace graphql query error.. URL: https://github.com/apache/incubator-skywalking/issues/1279 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ascrutae commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor

ascrutae commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#discussion_r194212804 ## File path:

[GitHub] peng-yongsheng commented on issue #1262: Filter non-active service name when UI query.

peng-yongsheng commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-395940126 1. Add application id to be a query condition of searchService method. 2. Filter service name by given time which

[GitHub] wu-sheng commented on issue #1262: Filter non-active service name when UI query.

wu-sheng commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-395940726 @peng-yongsheng ci fails. This is an automated message

[GitHub] coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor

coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395941131 [](https://coveralls.io/builds/17403776) Coverage

[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor

ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395940948 I had test this PR in the following scenarios: **Scenario One**: 1. visit `http://localhost:8080/test3` by using browser