[GitHub] coveralls commented on issue #1741: Add alarm timestamp

2018-10-10 Thread GitBox
coveralls commented on issue #1741: Add alarm timestamp URL: https://github.com/apache/incubator-skywalking/pull/1741#issuecomment-428448615 [![Coverage Status](https://coveralls.io/builds/19440227/badge)](https://coveralls.io/builds/19440227) Coverage increased (+0.003%) to

[incubator-skywalking] branch fix-alarm-time deleted (was 4921c0c)

2018-10-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch fix-alarm-time in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was 4921c0c Merge branch 'master' into fix-alarm-time The revisions that were on this branch

[GitHub] nize1989 commented on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue #

2018-10-10 Thread GitBox
nize1989 commented on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue # URL: https://github.com/apache/incubator-skywalking/pull/1740#issuecomment-428460043 @wu-sheng Thanks for your suggestion,I will take

[GitHub] wu-sheng commented on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue #

2018-10-10 Thread GitBox
wu-sheng commented on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue # URL: https://github.com/apache/incubator-skywalking/pull/1740#issuecomment-428460364 > I will take it. But the static method of

[GitHub] coveralls edited a comment on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue #

2018-10-10 Thread GitBox
coveralls edited a comment on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue # URL: https://github.com/apache/incubator-skywalking/pull/1740#issuecomment-428435744 [![Coverage

[GitHub] peng-yongsheng opened a new pull request #1742: The heartbeat implementation for all the scopes.

2018-10-10 Thread GitBox
peng-yongsheng opened a new pull request #1742: The heartbeat implementation for all the scopes. URL: https://github.com/apache/incubator-skywalking/pull/1742 This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng commented on issue #1742: The heartbeat implementation for all the scopes.

2018-10-10 Thread GitBox
wu-sheng commented on issue #1742: The heartbeat implementation for all the scopes. URL: https://github.com/apache/incubator-skywalking/pull/1742#issuecomment-428470816 FYI @hanahmily Heartbeat(new and old protocols) has been supported with a test case.

[GitHub] DylanLees opened a new issue #1743: can't build the skywalking project

2018-10-10 Thread GitBox
DylanLees opened a new issue #1743: can't build the skywalking project URL: https://github.com/apache/incubator-skywalking/issues/1743 Mr.wu,i just pull the skywalking from github,and build it according to offical document in IntelliJ,but it occurs a problem as following. `[ERROR]

[GitHub] wu-sheng closed pull request #1742: The heartbeat implementation for all the scopes.

2018-10-10 Thread GitBox
wu-sheng closed pull request #1742: The heartbeat implementation for all the scopes. URL: https://github.com/apache/incubator-skywalking/pull/1742 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] wu-sheng commented on issue #1743: can't build the skywalking project

2018-10-10 Thread GitBox
wu-sheng commented on issue #1743: can't build the skywalking project URL: https://github.com/apache/incubator-skywalking/issues/1743#issuecomment-428484381 First, our compile is tested for each release by Travis CI, https://travis-ci.org/apache/incubator-skywalking . No compiling issue.

[GitHub] hanahmily opened a new issue #1746: Test: No cpm and sla value on Topology metric

2018-10-10 Thread GitBox
hanahmily opened a new issue #1746: Test: No cpm and sla value on Topology metric URL: https://github.com/apache/incubator-skywalking/issues/1746 Refer to #1710 ## Requst ### Query ```graphql query TopologyMetric($duration: Duration!, $ids: [ID!]!, $idsS: [ID!]!, $idsC:

[GitHub] caowenyan opened a new issue #1744: trace topology is sometimes incorrect.

2018-10-10 Thread GitBox
caowenyan opened a new issue #1744: trace topology is sometimes incorrect. URL: https://github.com/apache/incubator-skywalking/issues/1744 Now I deploy the skywalking into the produce environment, topologies are mostly correct, but occasionally are incorrect, as shown in Figure . What

[GitHub] wu-sheng closed issue #1743: can't build the skywalking project

2018-10-10 Thread GitBox
wu-sheng closed issue #1743: can't build the skywalking project URL: https://github.com/apache/incubator-skywalking/issues/1743 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-skywalking] branch master updated: The heartbeat implementation for all the scopes. (#1742)

2018-10-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new ef63bc6 The heartbeat

[GitHub] wu-sheng commented on issue #1744: trace topology is sometimes incorrect.

2018-10-10 Thread GitBox
wu-sheng commented on issue #1744: trace topology is sometimes incorrect. URL: https://github.com/apache/incubator-skywalking/issues/1744#issuecomment-428485065 That is hard to say, could you dive into the data of query result?

[GitHub] wu-sheng commented on issue #1744: trace topology is sometimes incorrect.

2018-10-10 Thread GitBox
wu-sheng commented on issue #1744: trace topology is sometimes incorrect. URL: https://github.com/apache/incubator-skywalking/issues/1744#issuecomment-428500674 I mean Topology query, the right one and wrong way. I can't find any issue about your trace data.

[GitHub] hanahmily opened a new issue #1747: Test: Service topology map contains invalid nodes

2018-10-10 Thread GitBox
hanahmily opened a new issue #1747: Test: Service topology map contains invalid nodes URL: https://github.com/apache/incubator-skywalking/issues/1747 Refer to #1710 ## Requst ### Query ```graphql query Service($serviceId: ID!, $duration: Duration!) {

[GitHub] nize1989 edited a comment on issue #1724: Got null when method parameter is modified by @RequestBody, in a controller method.

2018-10-10 Thread GitBox
nize1989 edited a comment on issue #1724: Got null when method parameter is modified by @RequestBody,in a controller method. URL: https://github.com/apache/incubator-skywalking/issues/1724#issuecomment-425649681

[GitHub] SkyWalkingRobot commented on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue #

2018-10-10 Thread GitBox
SkyWalkingRobot commented on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue # URL: https://github.com/apache/incubator-skywalking/pull/1740#issuecomment-428515640 Here is the [test

[GitHub] hanahmily opened a new issue #1748: Test: No service instances

2018-10-10 Thread GitBox
hanahmily opened a new issue #1748: Test: No service instances URL: https://github.com/apache/incubator-skywalking/issues/1748 Refer to #1710 ## Requst ### Query ```graphql query Service($serviceId: ID!, $duration: Duration!) { getServiceInstances(duration:

[GitHub] nize1989 edited a comment on issue #1724: Got null when method parameter is modified by @RequestBody, in a controller method.

2018-10-10 Thread GitBox
nize1989 edited a comment on issue #1724: Got null when method parameter is modified by @RequestBody,in a controller method. URL: https://github.com/apache/incubator-skywalking/issues/1724#issuecomment-425649681

[GitHub] hanahmily opened a new issue #1750: Test: No trace id in Trace

2018-10-10 Thread GitBox
hanahmily opened a new issue #1750: Test: No trace id in Trace URL: https://github.com/apache/incubator-skywalking/issues/1750 Refer to #1710 ## Requst ### Query ```graphql query BasicTraces($condition: TraceQueryCondition) { queryBasicTraces(condition: $condition)

[GitHub] caowenyan commented on issue #1744: trace topology is sometimes incorrect.

2018-10-10 Thread GitBox
caowenyan commented on issue #1744: trace topology is sometimes incorrect. URL: https://github.com/apache/incubator-skywalking/issues/1744#issuecomment-428559983 this is current topology:

[GitHub] wu-sheng commented on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue #

2018-10-10 Thread GitBox
wu-sheng commented on issue #1740: Lost parameter annotation in method, when enhance the superclass's method in subclass. More details to see the issue # URL: https://github.com/apache/incubator-skywalking/pull/1740#issuecomment-428564938 @nize1989 Based on our autotests, these changes

[GitHub] coveralls commented on issue #1751: Update link to Skywalking Logo in README.md

2018-10-10 Thread GitBox
coveralls commented on issue #1751: Update link to Skywalking Logo in README.md URL: https://github.com/apache/incubator-skywalking/pull/1751#issuecomment-428632254 [![Coverage Status](https://coveralls.io/builds/19449556/badge)](https://coveralls.io/builds/19449556) Coverage

[GitHub] lunchboxav opened a new pull request #1751: Update link to Skywalking Logo in README.md

2018-10-10 Thread GitBox
lunchboxav opened a new pull request #1751: Update link to Skywalking Logo in README.md URL: https://github.com/apache/incubator-skywalking/pull/1751 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [*] New feature

[incubator-skywalking-ui] branch 6.0.0/dev updated: Fix bugs about integration test

2018-10-10 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch 6.0.0/dev in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-ui.git The following commit(s) were added to refs/heads/6.0.0/dev by this push: new 91961c5 Fix bugs

[incubator-skywalking] branch master updated: Update link to Skywalking Logo in README.md (#1751)

2018-10-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 59961b5 Update link to

[GitHub] wu-sheng closed pull request #1751: Update link to Skywalking Logo in README.md

2018-10-10 Thread GitBox
wu-sheng closed pull request #1751: Update link to Skywalking Logo in README.md URL: https://github.com/apache/incubator-skywalking/pull/1751 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-skywalking] 01/01: Alarm silence init wrong.

2018-10-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch fix-alarm-silence in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit 793401a0f7d3c90205445dfedadb03fa85b97d56 Author: Wu Sheng AuthorDate: Thu Oct 11 08:42:31

[incubator-skywalking] branch fix-alarm-silence created (now 793401a)

2018-10-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch fix-alarm-silence in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at 793401a Alarm silence init wrong. This branch includes the following new commits:

[GitHub] wu-sheng opened a new pull request #1752: Alarm silence init wrong.

2018-10-10 Thread GitBox
wu-sheng opened a new pull request #1752: Alarm silence init wrong. URL: https://github.com/apache/incubator-skywalking/pull/1752 Silence should be -1 if don't set from yml. This is an automated message from the Apache Git

[GitHub] coveralls commented on issue #1752: Alarm silence init wrong.

2018-10-10 Thread GitBox
coveralls commented on issue #1752: Alarm silence init wrong. URL: https://github.com/apache/incubator-skywalking/pull/1752#issuecomment-428784239 [![Coverage Status](https://coveralls.io/builds/19459603/badge)](https://coveralls.io/builds/19459603) Coverage increased (+0.003%)

[GitHub] peng-yongsheng closed pull request #1752: Alarm silence init wrong.

2018-10-10 Thread GitBox
peng-yongsheng closed pull request #1752: Alarm silence init wrong. URL: https://github.com/apache/incubator-skywalking/pull/1752 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-skywalking] branch master updated: Alarm silence init wrong. (#1752)

2018-10-10 Thread pengys
This is an automated email from the ASF dual-hosted git repository. pengys pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 3f8af95 Alarm silence init

[incubator-skywalking] branch fix-alarm-silence deleted (was 793401a)

2018-10-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch fix-alarm-silence in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was 793401a Alarm silence init wrong. The revisions that were on this branch are still