[GitHub] coveralls edited a comment on issue #2052: Update How-to-release.md

2018-12-15 Thread GitBox
coveralls edited a comment on issue #2052: Update How-to-release.md URL: https://github.com/apache/incubator-skywalking/pull/2052#issuecomment-447615326 [![Coverage Status](https://coveralls.io/builds/20657630/badge)](https://coveralls.io/builds/20657630) Coverage increased

[GitHub] wu-sheng opened a new issue #2053: Grafana integration

2018-12-15 Thread GitBox
wu-sheng opened a new issue #2053: Grafana integration URL: https://github.com/apache/incubator-skywalking/issues/2053 @JaredTan95 @TinyAllen @hanahmily We have known, [Grafana](https://github.com/grafana/grafana) is a beautiful monitoring. @hanahmily used to propose to use it as

[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-15 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-447623704 @ASCE1885 Please answer @candyleer question, to make sure whether this PR is ready to merge.

[GitHub] wu-sheng commented on issue #2051: Move node type from network address to service level

2018-12-15 Thread GitBox
wu-sheng commented on issue #2051: Move node type from network address to service level URL: https://github.com/apache/incubator-skywalking/pull/2051#issuecomment-447611747 @liuhaoyang Please consider the proposal in ml and here(same) is just suggestion. I am doing this pull request just

[GitHub] coveralls edited a comment on issue #2052: Update How-to-release.md

2018-12-15 Thread GitBox
coveralls edited a comment on issue #2052: Update How-to-release.md URL: https://github.com/apache/incubator-skywalking/pull/2052#issuecomment-447615326 [![Coverage Status](https://coveralls.io/builds/20657647/badge)](https://coveralls.io/builds/20657647) Coverage increased

[GitHub] peng-yongsheng commented on issue #2051: Move node type from network address to service level

2018-12-15 Thread GitBox
peng-yongsheng commented on issue #2051: Move node type from network address to service level URL: https://github.com/apache/incubator-skywalking/pull/2051#issuecomment-447612915 Maybe we should better discuss the SQL and database analysis in a specific issue or pull request. The

[incubator-skywalking] branch peng-yongsheng-patch-1 updated (5e94ebc -> da49ec8)

2018-12-15 Thread pengys
This is an automated email from the ASF dual-hosted git repository. pengys pushed a change to branch peng-yongsheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from 5e94ebc Update How-to-release.md add d47937b Add https://www.wochu.cn to

[incubator-skywalking] branch master updated: Add https://www.wochu.cn to powered-by list (#2050)

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new d47937b Add

[incubator-skywalking] branch peng-yongsheng-patch-1 updated (aab53de -> 5e94ebc)

2018-12-15 Thread pengys
This is an automated email from the ASF dual-hosted git repository. pengys pushed a change to branch peng-yongsheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from aab53de Update How-to-release.md add 5e94ebc Update How-to-release.md No new

[GitHub] peng-yongsheng commented on issue #2051: Move node type from network address to service level

2018-12-15 Thread GitBox
peng-yongsheng commented on issue #2051: Move node type from network address to service level URL: https://github.com/apache/incubator-skywalking/pull/2051#issuecomment-447615198 All right. I'm not good at the name definition. This break change is not difficult for users to upgrade

[incubator-skywalking] branch nodetype updated (df9396c -> f822ee1)

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch nodetype in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from df9396c Fix compile issue. add d47937b Add https://www.wochu.cn to powered-by list (#2050)

[GitHub] wu-sheng commented on issue #2051: Move node type from network address to service level

2018-12-15 Thread GitBox
wu-sheng commented on issue #2051: Move node type from network address to service level URL: https://github.com/apache/incubator-skywalking/pull/2051#issuecomment-447613002 Which name? Layer? That is from tracing field. Adrian gave that name. But only make sense in trace, not inventory.

[incubator-skywalking] branch peng-yongsheng-patch-1 updated (da49ec8 -> 041a4c7)

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch peng-yongsheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from da49ec8 Merge branch 'master' into peng-yongsheng-patch-1 add 041a4c7 Update

[GitHub] coveralls commented on issue #2051: Move node type from network address to service level

2018-12-15 Thread GitBox
coveralls commented on issue #2051: Move node type from network address to service level URL: https://github.com/apache/incubator-skywalking/pull/2051#issuecomment-447591701 [![Coverage Status](https://coveralls.io/builds/20655117/badge)](https://coveralls.io/builds/20655117)

[GitHub] wu-sheng commented on issue #2050: Add https://www.wochu.cn to powered-by list

2018-12-15 Thread GitBox
wu-sheng commented on issue #2050: Add https://www.wochu.cn to powered-by list URL: https://github.com/apache/incubator-skywalking/pull/2050#issuecomment-447613593 @peng-yongsheng highlight added. This is an automated

[GitHub] wu-sheng commented on issue #2050: Add https://www.wochu.cn to powered-by list

2018-12-15 Thread GitBox
wu-sheng commented on issue #2050: Add https://www.wochu.cn to powered-by list URL: https://github.com/apache/incubator-skywalking/pull/2050#issuecomment-447613490 @wenjianzhang Change the order for you. It is ready to merge.

[GitHub] coveralls edited a comment on issue #2050: Add https://www.wochu.cn to powered-by list

2018-12-15 Thread GitBox
coveralls edited a comment on issue #2050: Add https://www.wochu.cn to powered-by list URL: https://github.com/apache/incubator-skywalking/pull/2050#issuecomment-447548638 [![Coverage Status](https://coveralls.io/builds/20657546/badge)](https://coveralls.io/builds/20657546)

[GitHub] wu-sheng closed pull request #2050: Add https://www.wochu.cn to powered-by list

2018-12-15 Thread GitBox
wu-sheng closed pull request #2050: Add https://www.wochu.cn to powered-by list URL: https://github.com/apache/incubator-skywalking/pull/2050 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-skywalking] branch peng-yongsheng-patch-1 updated (df754eb -> aab53de)

2018-12-15 Thread pengys
This is an automated email from the ASF dual-hosted git repository. pengys pushed a change to branch peng-yongsheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from df754eb Update How-to-release.md add aab53de Update How-to-release.md No new

[GitHub] coveralls commented on issue #2052: Update How-to-release.md

2018-12-15 Thread GitBox
coveralls commented on issue #2052: Update How-to-release.md URL: https://github.com/apache/incubator-skywalking/pull/2052#issuecomment-447615326 [![Coverage Status](https://coveralls.io/builds/20657598/badge)](https://coveralls.io/builds/20657598) Coverage remained the same at

[GitHub] wu-sheng commented on issue #2050: Update powered-by.md

2018-12-15 Thread GitBox
wu-sheng commented on issue #2050: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2050#issuecomment-447613279 > We should highlight the sorting rule. Of course, we should. This is an

[GitHub] wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available

2018-12-15 Thread GitBox
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447617010 My key points 1. different entity to save span of OC, Zipkin and Jaeger. In some storage for

[incubator-skywalking] 01/01: Update How-to-release.md

2018-12-15 Thread pengys
This is an automated email from the ASF dual-hosted git repository. pengys pushed a commit to branch peng-yongsheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit df754eb428c48e625144d4be0120dd4e6b70aada Author: 彭勇升 pengys AuthorDate: Sun Dec 16

[GitHub] peng-yongsheng opened a new pull request #2052: Update How-to-release.md

2018-12-15 Thread GitBox
peng-yongsheng opened a new pull request #2052: Update How-to-release.md URL: https://github.com/apache/incubator-skywalking/pull/2052 The public gpg file name should be KEYS, not KEY. It will contains other PMCs public key in this file after you export from the gpg tools.

[incubator-skywalking] branch peng-yongsheng-patch-1 created (now df754eb)

2018-12-15 Thread pengys
This is an automated email from the ASF dual-hosted git repository. pengys pushed a change to branch peng-yongsheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at df754eb Update How-to-release.md This branch includes the following new commits:

[GitHub] peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available

2018-12-15 Thread GitBox
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447616745 I'm understand what you designed. 1. The metrics exclude relation analysis are no

[GitHub] wu-sheng edited a comment on issue #2051: Move node type from network address to service level

2018-12-15 Thread GitBox
wu-sheng edited a comment on issue #2051: Move node type from network address to service level URL: https://github.com/apache/incubator-skywalking/pull/2051#issuecomment-447589902 This is my proposal mail thread. Consider this PR is step 1, **Inventory changes (PROPOSAL ONLY)**.

[GitHub] wu-sheng commented on issue #2051: Move node type from network address to service level

2018-12-15 Thread GitBox
wu-sheng commented on issue #2051: Move node type from network address to service level URL: https://github.com/apache/incubator-skywalking/pull/2051#issuecomment-447611914 I am moving to adjust Zipkin, Jaeger and OC format analysis :)

[GitHub] coveralls commented on issue #2050: Update powered-by.md

2018-12-15 Thread GitBox
coveralls commented on issue #2050: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2050#issuecomment-447548638 [![Coverage Status](https://coveralls.io/builds/20650504/badge)](https://coveralls.io/builds/20650504) Coverage increased (+0.002%) to

[GitHub] wu-sheng closed pull request #2049: Add documents for clear things.

2018-12-15 Thread GitBox
wu-sheng closed pull request #2049: Add documents for clear things. URL: https://github.com/apache/incubator-skywalking/pull/2049 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-skywalking] branch master updated: Add documents for clear things. (#2049)

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new e1baa9b Add documents for clear

[incubator-skywalking] branch doc-improve deleted (was 229c689)

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch doc-improve in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was 229c689 Add documents for clear things. The revisions that were on this branch are still

[GitHub] coveralls edited a comment on issue #2050: Update powered-by.md

2018-12-15 Thread GitBox
coveralls edited a comment on issue #2050: Update powered-by.md URL: https://github.com/apache/incubator-skywalking/pull/2050#issuecomment-447548638 [![Coverage Status](https://coveralls.io/builds/20653167/badge)](https://coveralls.io/builds/20653167) Coverage increased

[GitHub] wu-sheng commented on issue #1934: Provide plugin for ShardingSphere

2018-12-15 Thread GitBox
wu-sheng commented on issue #1934: Provide plugin for ShardingSphere URL: https://github.com/apache/incubator-skywalking/pull/1934#issuecomment-447579845 Any progress? This is an automated message from the Apache Git

[incubator-skywalking] 01/01: Change srcLayer to nodeType. Add nodeType in service inventory entity.

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch nodetype in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit b4a6b6a3bc4962ff6ec2d1f230b016be11640812 Author: Wu Sheng AuthorDate: Sat Dec 15 09:46:49 2018 -0800

[incubator-skywalking] branch nodetype created (now b4a6b6a)

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch nodetype in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at b4a6b6a Change srcLayer to nodeType. Add nodeType in service inventory entity. This branch

[incubator-skywalking] branch nodetype updated: NodeType value refactor.

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch nodetype in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/nodetype by this push: new ebc49d9 NodeType value

[incubator-skywalking] branch nodetype updated: Format codes.

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch nodetype in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/nodetype by this push: new c366dfd Format codes.

[GitHub] wu-sheng opened a new pull request #2051: Move node type from network address to service level

2018-12-15 Thread GitBox
wu-sheng opened a new pull request #2051: Move node type from network address to service level URL: https://github.com/apache/incubator-skywalking/pull/2051 Update in this pull request 1. Rename `src_layer` to `node_type` for NetworkAddressInventory. **Break change**, need

[GitHub] wu-sheng commented on issue #2051: Move node type from network address to service level

2018-12-15 Thread GitBox
wu-sheng commented on issue #2051: Move node type from network address to service level URL: https://github.com/apache/incubator-skywalking/pull/2051#issuecomment-447589902 This is my proposal mail thread. Consider this PR is step 1, **Inventory changes**. I am

[incubator-skywalking] branch nodetype updated (c366dfd -> df9396c)

2018-12-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch nodetype in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from c366dfd Format codes. add df9396c Fix compile issue. No new revisions were added by this