[GitHub] [skywalking] wu-sheng commented on a change in pull request #3273: Support Zookeeper ACL

2019-08-15 Thread GitBox
wu-sheng commented on a change in pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#discussion_r314294990 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #443: Which companies are using SkyWalking

2019-08-15 Thread GitBox
wu-sheng commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/skywalking/issues/443#issuecomment-521547836 GOME. (gome.com.cn) This is an automated message from the Apache Git Service.

[GitHub] [skywalking] dmsolr opened a new pull request #3273: Support Zookeeper ACL

2019-08-15 Thread GitBox
dmsolr opened a new pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance

[GitHub] [skywalking] dmsolr commented on a change in pull request #3273: Support Zookeeper ACL

2019-08-15 Thread GitBox
dmsolr commented on a change in pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#discussion_r314281520 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3274: Check license header strictly

2019-08-15 Thread GitBox
wu-sheng commented on a change in pull request #3274: Check license header strictly URL: https://github.com/apache/skywalking/pull/3274#discussion_r314306602 ## File path: apm-checkstyle/checkStyle.xml ## @@ -110,4 +110,11 @@ + +

[skywalking] branch wu-sheng-patch-1 deleted (was 578a2f5)

2019-08-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. was 578a2f5 Update powered-by.md The revisions that were on this branch are still contained in other

[skywalking] branch master updated: Update powered-by.md (#3272)

2019-08-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 9161c47 Update powered-by.md (#3272)

[GitHub] [skywalking] wu-sheng merged pull request #3272: Add GOME to powered-by.md

2019-08-15 Thread GitBox
wu-sheng merged pull request #3272: Add GOME to powered-by.md URL: https://github.com/apache/skywalking/pull/3272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3274: Check license header strictly

2019-08-15 Thread GitBox
wu-sheng commented on a change in pull request #3274: Check license header strictly URL: https://github.com/apache/skywalking/pull/3274#discussion_r314300439 ## File path: apm-checkstyle/checkStyle.xml ## @@ -110,4 +110,11 @@ + + +

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3273: Support Zookeeper ACL

2019-08-15 Thread GitBox
kezhenxu94 commented on a change in pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#discussion_r314246288 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3274: Check license header strictly

2019-08-15 Thread GitBox
kezhenxu94 commented on a change in pull request #3274: Check license header strictly URL: https://github.com/apache/skywalking/pull/3274#discussion_r314300933 ## File path: apm-checkstyle/checkStyle.xml ## @@ -110,4 +110,11 @@ + +

[GitHub] [skywalking] dmsolr commented on a change in pull request #3273: Support Zookeeper ACL

2019-08-15 Thread GitBox
dmsolr commented on a change in pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#discussion_r314304191 ## File path:

[GitHub] [skywalking] kezhenxu94 opened a new pull request #3274: Check license header strictly

2019-08-15 Thread GitBox
kezhenxu94 opened a new pull request #3274: Check license header strictly URL: https://github.com/apache/skywalking/pull/3274 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] [skywalking] bugCreate closed issue #3270: URLClassLoader can't load remote jar when application start with skywalking agent

2019-08-15 Thread GitBox
bugCreate closed issue #3270: URLClassLoader can't load remote jar when application start with skywalking agent URL: https://github.com/apache/skywalking/issues/3270 This is an automated message from the Apache Git Service.

[GitHub] [skywalking] bugCreate commented on issue #3270: URLClassLoader can't load remote jar when application start with skywalking agent

2019-08-15 Thread GitBox
bugCreate commented on issue #3270: URLClassLoader can't load remote jar when application start with skywalking agent URL: https://github.com/apache/skywalking/issues/3270#issuecomment-521527487 bad english,sorry. don't need help,just want to remind you a bug, never mind. best

[GitHub] [skywalking] wu-sheng commented on issue #3271: 6.2release upgrade to 6.3question

2019-08-15 Thread GitBox
wu-sheng commented on issue #3271: 6.2release upgrade to 6.3question URL: https://github.com/apache/skywalking/issues/3271#issuecomment-521536427 All upgrade before 6.3.0 running, the safest way is reboot agents. Or use blue-green deployment solution. Move the target service to 6.3.0 when

[GitHub] [skywalking] wu-sheng closed issue #3271: 6.2release upgrade to 6.3question

2019-08-15 Thread GitBox
wu-sheng closed issue #3271: 6.2release upgrade to 6.3question URL: https://github.com/apache/skywalking/issues/3271 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3273: Support Zookeeper ACL

2019-08-15 Thread GitBox
wu-sheng commented on a change in pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#discussion_r314208393 ## File path:

[GitHub] [skywalking] Dauber01 commented on issue #3268: nacos and 6.2.0

2019-08-15 Thread GitBox
Dauber01 commented on issue #3268: nacos and 6.2.0 URL: https://github.com/apache/skywalking/issues/3268#issuecomment-521533156 k8s coordinator create by rancher This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] kezhenxu94 commented on issue #3272: Add GOME to powered-by.md

2019-08-15 Thread GitBox
kezhenxu94 commented on issue #3272: Add GOME to powered-by.md URL: https://github.com/apache/skywalking/pull/3272#issuecomment-521549226 /run ci This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3272: Add GOME to powered-by.md

2019-08-15 Thread GitBox
kezhenxu94 removed a comment on issue #3272: Add GOME to powered-by.md URL: https://github.com/apache/skywalking/pull/3272#issuecomment-521549226 /run ci This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wu-sheng commented on issue #3268: nacos and 6.2.0

2019-08-15 Thread GitBox
wu-sheng commented on issue #3268: nacos and 6.2.0 URL: https://github.com/apache/skywalking/issues/3268#issuecomment-521533537 @Dauber01 Then use SkyWalking's k8s cluster manager. It is there for a long time, then you don't need to bother all these IP things :)

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3273: Support Zookeeper ACL

2019-08-15 Thread GitBox
kezhenxu94 commented on a change in pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#discussion_r314246288 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3273: Support Zookeeper ACL

2019-08-15 Thread GitBox
kezhenxu94 commented on a change in pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#discussion_r314246288 ## File path:

[GitHub] [skywalking] Dauber01 commented on issue #3268: nacos and 6.2.0

2019-08-15 Thread GitBox
Dauber01 commented on issue #3268: nacos and 6.2.0 URL: https://github.com/apache/skywalking/issues/3268#issuecomment-521530285 Maybe , i have never read the nacos source code,and if iconfig the ip in core config ,when i use docker ,it can't start up.

[GitHub] [skywalking] wu-sheng commented on issue #3268: nacos and 6.2.0

2019-08-15 Thread GitBox
wu-sheng commented on issue #3268: nacos and 6.2.0 URL: https://github.com/apache/skywalking/issues/3268#issuecomment-521532026 @Dauber01 Yes. That is not your fault. That is what I am asking @kezhenxu94 to notice. Because as service discovery, you have to know your own IP, but when you

[GitHub] [skywalking] wentjiang opened a new issue #3271: 6.2release upgrade to 6.3question

2019-08-15 Thread GitBox
wentjiang opened a new issue #3271: 6.2release upgrade to 6.3question URL: https://github.com/apache/skywalking/issues/3271 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion ___ ### Question - What

[GitHub] [skywalking] dmsolr commented on a change in pull request #3273: Support Zookeeper ACL

2019-08-15 Thread GitBox
dmsolr commented on a change in pull request #3273: Support Zookeeper ACL URL: https://github.com/apache/skywalking/pull/3273#discussion_r314213045 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3207: [WIP] Support play 2.x

2019-08-15 Thread GitBox
kezhenxu94 commented on a change in pull request #3207: [WIP] Support play 2.x URL: https://github.com/apache/skywalking/pull/3207#discussion_r314255163 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3207: [WIP] Support play 2.x

2019-08-15 Thread GitBox
kezhenxu94 commented on a change in pull request #3207: [WIP] Support play 2.x URL: https://github.com/apache/skywalking/pull/3207#discussion_r314256598 ## File path: apm-sniffer/apm-agent-core/src/test/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/Inject.java

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3207: [WIP] Support play 2.x

2019-08-15 Thread GitBox
kezhenxu94 commented on a change in pull request #3207: [WIP] Support play 2.x URL: https://github.com/apache/skywalking/pull/3207#discussion_r314257203 ## File path: apm-sniffer/apm-agent-core/src/test/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/Inject.java

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3207: [WIP] Support play 2.x

2019-08-15 Thread GitBox
kezhenxu94 commented on a change in pull request #3207: [WIP] Support play 2.x URL: https://github.com/apache/skywalking/pull/3207#discussion_r314255700 ## File path:

[GitHub] [skywalking] Dauber01 commented on issue #3268: nacos and 6.2.0

2019-08-15 Thread GitBox
Dauber01 commented on issue #3268: nacos and 6.2.0 URL: https://github.com/apache/skywalking/issues/3268#issuecomment-521533877 thank you ,i will try it This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wu-sheng opened a new pull request #3272: Add GOME to powered-by.md

2019-08-15 Thread GitBox
wu-sheng opened a new pull request #3272: Add GOME to powered-by.md URL: https://github.com/apache/skywalking/pull/3272 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch wu-sheng-patch-1 created (now 578a2f5)

2019-08-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 578a2f5 Update powered-by.md This branch includes the following new commits: new 578a2f5

[skywalking] 01/01: Update powered-by.md

2019-08-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 578a2f52946796917af507ddb8a99862f575e46a Author: 吴晟 Wu Sheng AuthorDate: Thu Aug 15 15:41:18 2019 +0800

[GitHub] [skywalking] aiyanbo commented on a change in pull request #3207: [WIP] Support play 2.x

2019-08-15 Thread GitBox
aiyanbo commented on a change in pull request #3207: [WIP] Support play 2.x URL: https://github.com/apache/skywalking/pull/3207#discussion_r314563116 ## File path:

[GitHub] [skywalking] wu-sheng closed issue #3161: SpringCloudGateway More than 300 spans required to create

2019-08-15 Thread GitBox
wu-sheng closed issue #3161: SpringCloudGateway More than 300 spans required to create URL: https://github.com/apache/skywalking/issues/3161 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #3161: SpringCloudGateway More than 300 spans required to create

2019-08-15 Thread GitBox
wu-sheng commented on issue #3161: SpringCloudGateway More than 300 spans required to create URL: https://github.com/apache/skywalking/issues/3161#issuecomment-521844604 @DerekHQ Check the master branch please, this should be fixed by @zhaoyuguang

[GitHub] [skywalking] wu-sheng closed issue #3230: elasticsearch error log : failed to parse field [value] of type [double]

2019-08-15 Thread GitBox
wu-sheng closed issue #3230: elasticsearch error log : failed to parse field [value] of type [double] URL: https://github.com/apache/skywalking/issues/3230 This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng commented on issue #3230: elasticsearch error log : failed to parse field [value] of type [double]

2019-08-15 Thread GitBox
wu-sheng commented on issue #3230: elasticsearch error log : failed to parse field [value] of type [double] URL: https://github.com/apache/skywalking/issues/3230#issuecomment-521844390 No further detail, closing. This is an

[GitHub] [skywalking] aiyanbo commented on a change in pull request #3207: [WIP] Support play 2.x

2019-08-15 Thread GitBox
aiyanbo commented on a change in pull request #3207: [WIP] Support play 2.x URL: https://github.com/apache/skywalking/pull/3207#discussion_r314562396 ## File path:

[GitHub] [skywalking] aiyanbo commented on a change in pull request #3207: [WIP] Support play 2.x

2019-08-15 Thread GitBox
aiyanbo commented on a change in pull request #3207: [WIP] Support play 2.x URL: https://github.com/apache/skywalking/pull/3207#discussion_r314563028 ## File path: apm-sniffer/apm-agent-core/src/test/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/Inject.java ##