[GitHub] [skywalking] arugal commented on issue #3809: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
arugal commented on issue #3809: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3809#issuecomment-551913273 With the feature provided by #3802, migrating use cases becomes easier.

[GitHub] [skywalking] arugal opened a new pull request #3809: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
arugal opened a new pull request #3809: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3809 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ]

[GitHub] [skywalking] wu-sheng opened a new pull request #3810: Test Only, Update README.md

2019-11-08 Thread GitBox
wu-sheng opened a new pull request #3810: Test Only, Update README.md URL: https://github.com/apache/skywalking/pull/3810 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[skywalking] 01/01: Update README.md

2019-11-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 35c2bc8650d0140f51a07ee9a140110bc522c9a4 Author: 吴晟 Wu Sheng AuthorDate: Sat Nov 9 08:42:07 2019 +0800

[GitHub] [skywalking] wu-sheng closed pull request #3810: Test Only, Update README.md

2019-11-08 Thread GitBox
wu-sheng closed pull request #3810: Test Only, Update README.md URL: https://github.com/apache/skywalking/pull/3810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] arugal closed pull request #3812: test ci

2019-11-08 Thread GitBox
arugal closed pull request #3812: test ci URL: https://github.com/apache/skywalking/pull/3812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-cli] codecov-io commented on issue #6: [Feature] Set GraphQL client and add service ls command

2019-11-08 Thread GitBox
codecov-io commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-552066273 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/6?src=pr=h1) Report > :exclamation: No coverage uploaded

[GitHub] [skywalking] wu-sheng merged pull request #3814: Modify als docs

2019-11-08 Thread GitBox
wu-sheng merged pull request #3814: Modify als docs URL: https://github.com/apache/skywalking/pull/3814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[skywalking] branch master updated: fix als docs (#3814)

2019-11-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new e307b69 fix als docs (#3814) e307b69 is

[GitHub] [skywalking] wu-sheng commented on issue #3809: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
wu-sheng commented on issue #3809: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3809#issuecomment-552045847 Test This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wu-sheng removed a comment on issue #3809: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
wu-sheng removed a comment on issue #3809: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3809#issuecomment-552045847 Test This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] arugal closed pull request #3809: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
arugal closed pull request #3809: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3809 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] arugal opened a new pull request #3811: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
arugal opened a new pull request #3811: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3811 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ]

[GitHub] [skywalking] dmsolr commented on a change in pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
dmsolr commented on a change in pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808#discussion_r344427515 ## File path: test/plugin/archetypes/jvm/src/main/resources/archetype-resources/src/main/resources/log4j2.xml ## @@

[GitHub] [skywalking] dmsolr commented on a change in pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
dmsolr commented on a change in pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808#discussion_r344427421 ## File path: test/plugin/archetypes/jvm/src/main/resources/archetype-resources/src/main/resources/log4j2.xml ## @@

[GitHub] [skywalking] arugal commented on issue #3583: Plugin test-cases immigrate plan

2019-11-08 Thread GitBox
arugal commented on issue #3583: Plugin test-cases immigrate plan URL: https://github.com/apache/skywalking/issues/3583#issuecomment-552072911 @tomlikeyou Welcome to contribute. This is an automated message from the Apache

[GitHub] [skywalking] wu-sheng commented on issue #3809: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
wu-sheng commented on issue #3809: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3809#issuecomment-552047391 There is a license missing issue. Please recheck. This is an automated

[GitHub] [skywalking] tomlikeyou commented on issue #3583: Plugin test-cases immigrate plan

2019-11-08 Thread GitBox
tomlikeyou commented on issue #3583: Plugin test-cases immigrate plan URL: https://github.com/apache/skywalking/issues/3583#issuecomment-552072209 jdk-cross-thread-scenario for me This is an automated message from the Apache

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command

2019-11-08 Thread GitBox
kezhenxu94 commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r344428770 ## File path: commands/interceptor.go ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command

2019-11-08 Thread GitBox
kezhenxu94 commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r344428802 ## File path: scripts/build ## @@ -20,7 +20,7 @@ cli_build() { out="bin"

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command

2019-11-08 Thread GitBox
kezhenxu94 commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r344428796 ## File path: commands/service/list.go ## @@ -0,0 +1,73 @@ +/* + * Licensed to the

[GitHub] [skywalking] arugal commented on a change in pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
arugal commented on a change in pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808#discussion_r344427948 ## File path: test/plugin/archetypes/jvm/src/main/resources/archetype-resources/src/main/resources/log4j2.xml ## @@

[GitHub] [skywalking] arugal commented on a change in pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
arugal commented on a change in pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808#discussion_r344427949 ## File path: test/plugin/archetypes/jvm/src/main/resources/archetype-resources/src/main/resources/log4j2.xml ## @@

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command

2019-11-08 Thread GitBox
kezhenxu94 commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r344428706 ## File path: commands/interceptor.go ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] [skywalking] innerpeacez opened a new pull request #3814: Modify als docs

2019-11-08 Thread GitBox
innerpeacez opened a new pull request #3814: Modify als docs URL: https://github.com/apache/skywalking/pull/3814 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Bug fix - [ ] New feature provided - [ ] Improve performance

[GitHub] [skywalking-cli] codecov-io edited a comment on issue #6: [Feature] Set GraphQL client and add service ls command

2019-11-08 Thread GitBox
codecov-io edited a comment on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-552066273 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/6?src=pr=h1) Report > :exclamation: No coverage

[GitHub] [skywalking-cli] codecov-io edited a comment on issue #6: [Feature] Set GraphQL client and add service ls command

2019-11-08 Thread GitBox
codecov-io edited a comment on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-552066273 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/6?src=pr=h1) Report > :exclamation: No coverage

[GitHub] [skywalking] wu-sheng merged pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
wu-sheng merged pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch master updated: [test/plugin] fix archetypes (#3808)

2019-11-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new cbe03da [test/plugin] fix archetypes

[GitHub] [skywalking] wu-sheng closed pull request #3809: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
wu-sheng closed pull request #3809: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3809 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] arugal opened a new pull request #3809: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
arugal opened a new pull request #3809: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3809 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ]

[GitHub] [skywalking] arugal edited a comment on issue #3583: Plugin test-cases immigrate plan

2019-11-08 Thread GitBox
arugal edited a comment on issue #3583: Plugin test-cases immigrate plan URL: https://github.com/apache/skywalking/issues/3583#issuecomment-549432354 jedis scenario for me #3811 This is an automated message from the Apache

[GitHub] [skywalking] lmzhizhe opened a new issue #3813: Service list in the web UI cannot be displayed

2019-11-08 Thread GitBox
lmzhizhe opened a new issue #3813: Service list in the web UI cannot be displayed URL: https://github.com/apache/skywalking/issues/3813 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ✔] Bug - [ ]

[GitHub] [skywalking] lmzhizhe commented on issue #3813: Service list in the web UI cannot be displayed

2019-11-08 Thread GitBox
lmzhizhe commented on issue #3813: Service list in the web UI cannot be displayed URL: https://github.com/apache/skywalking/issues/3813#issuecomment-552065884 see the photoes This is an automated message from the Apache Git

[GitHub] [skywalking] arugal opened a new pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
arugal opened a new pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] [skywalking] wu-sheng closed pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
wu-sheng closed pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch wu-sheng-patch-1 created (now 35c2bc8)

2019-11-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 35c2bc8 Update README.md This branch includes the following new commits: new 35c2bc8 Update

[GitHub] [skywalking] wu-sheng commented on issue #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
wu-sheng commented on issue #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808#issuecomment-552045680 /run ci This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] arugal opened a new pull request #3812: test ci

2019-11-08 Thread GitBox
arugal opened a new pull request #3812: test ci URL: https://github.com/apache/skywalking/pull/3812 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance -

[GitHub] [skywalking] wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

2019-11-08 Thread GitBox
wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-552075212 When you update this PR as another plugin test has been added.

[GitHub] [skywalking] wu-sheng merged pull request #3811: [test/plugin] immigrate jedis scenario

2019-11-08 Thread GitBox
wu-sheng merged pull request #3811: [test/plugin] immigrate jedis scenario URL: https://github.com/apache/skywalking/pull/3811 This is an automated message from the Apache Git Service. To respond to the message, please log

[skywalking] branch master updated: [test/plugin] immigrate jedis scenario (#3811)

2019-11-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 48bcac2 [test/plugin] immigrate jedis

[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command

2019-11-08 Thread GitBox
wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r344433577 ## File path: commands/interceptor.go ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] [skywalking] wu-sheng closed issue #3806: NodeJS auto-instrument agents cannot be used as expected

2019-11-08 Thread GitBox
wu-sheng closed issue #3806: NodeJS auto-instrument agents cannot be used as expected URL: https://github.com/apache/skywalking/issues/3806 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #3806: NodeJS auto-instrument agents cannot be used as expected

2019-11-08 Thread GitBox
wu-sheng commented on issue #3806: NodeJS auto-instrument agents cannot be used as expected URL: https://github.com/apache/skywalking/issues/3806#issuecomment-551429924 NodeJS is not an official Apache repo. The issue is not managed here.

[GitHub] [skywalking] lixiv opened a new issue #3806: NodeJS auto-instrument agents cannot be used as expected

2019-11-08 Thread GitBox
lixiv opened a new issue #3806: NodeJS auto-instrument agents cannot be used as expected URL: https://github.com/apache/skywalking/issues/3806 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion ___

[GitHub] [skywalking] wu-sheng commented on issue #3806: NodeJS auto-instrument agents cannot be used as expected

2019-11-08 Thread GitBox
wu-sheng commented on issue #3806: NodeJS auto-instrument agents cannot be used as expected URL: https://github.com/apache/skywalking/issues/3806#issuecomment-551439712 There is no ThreadLocal in NodeJS. It works for some cases already, we don't need to remove it from my understanding. If

[GitHub] [skywalking] wolfguoliang commented on issue #3807: 日志里边很多这个错误,用的是ES 作为存储。偶尔会grpc full

2019-11-08 Thread GitBox
wolfguoliang commented on issue #3807: 日志里边很多这个错误,用的是ES 作为存储。偶尔会grpc full URL: https://github.com/apache/skywalking/issues/3807#issuecomment-551442318 those error is normal? This is an automated message from the Apache Git

[GitHub] [skywalking] lixiv commented on issue #3806: NodeJS auto-instrument agents cannot be used as expected

2019-11-08 Thread GitBox
lixiv commented on issue #3806: NodeJS auto-instrument agents cannot be used as expected URL: https://github.com/apache/skywalking/issues/3806#issuecomment-551431514 I mean we should modify our documents SkyWalking supports to collect telemetry (traces and metrics) data from multiple

[GitHub] [skywalking] wolfguoliang opened a new issue #3807: 日志里边很多这个错误,用的是ES 作为存储。偶尔会grpc full

2019-11-08 Thread GitBox
wolfguoliang opened a new issue #3807: 日志里边很多这个错误,用的是ES 作为存储。偶尔会grpc full URL: https://github.com/apache/skywalking/issues/3807 2019-11-08 16:17:01,628 - org.apache.skywalking.oap.server.receiver.trace.provider.handler.v6.grpc.TraceSegmentReportServiceHandler - 64

[GitHub] [skywalking] wu-sheng commented on issue #3807: 日志里边很多这个错误,用的是ES 作为存储。偶尔会grpc full

2019-11-08 Thread GitBox
wu-sheng commented on issue #3807: 日志里边很多这个错误,用的是ES 作为存储。偶尔会grpc full URL: https://github.com/apache/skywalking/issues/3807#issuecomment-551438817 English only. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng closed issue #3807: 日志里边很多这个错误,用的是ES 作为存储。偶尔会grpc full

2019-11-08 Thread GitBox
wu-sheng closed issue #3807: 日志里边很多这个错误,用的是ES 作为存储。偶尔会grpc full URL: https://github.com/apache/skywalking/issues/3807 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] arugal opened a new pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
arugal opened a new pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] [skywalking] arugal opened a new pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
arugal opened a new pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] [skywalking] wu-sheng closed pull request #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
wu-sheng closed pull request #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] arugal commented on issue #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
arugal commented on issue #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808#issuecomment-551828606 ![image](https://user-images.githubusercontent.com/26432832/68481404-10d2d000-0272-11ea-92c7-48701525258b.png) FYI @dmsolr

[GitHub] [skywalking] arugal edited a comment on issue #3808: [test/plugin] fix archetypes

2019-11-08 Thread GitBox
arugal edited a comment on issue #3808: [test/plugin] fix archetypes URL: https://github.com/apache/skywalking/pull/3808#issuecomment-551828606 The new ```generator.sh``` ![image](https://user-images.githubusercontent.com/26432832/68481404-10d2d000-0272-11ea-92c7-48701525258b.png)