[skywalking] branch percentile updated (b1e6007 -> cef90ee)

2020-01-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch percentile in repository https://gitbox.apache.org/repos/asf/skywalking.git. from b1e6007 Use avg resp time to apdex in the TTL test. add dcb71cd Optimize trace ignore plugin (#4209)

[skywalking] branch percentile updated (cef90ee -> 8cf6147)

2020-01-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch percentile in repository https://gitbox.apache.org/repos/asf/skywalking.git. from cef90ee Merge branch 'master' into percentile add 8cf6147 ADD multiple linear metrics check for

[skywalking] branch percentile updated (567621d -> c8ece13)

2020-01-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch percentile in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 567621d Support `-` to represent no threshold and doc of alarm about this. add c8ece13 Move break

[GitHub] [skywalking] codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573269476 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4214?src=pr=h1) Report > Merging

[skywalking] branch percentile updated (8cf6147 -> 567621d)

2020-01-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch percentile in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 8cf6147 ADD multiple linear metrics check for endpoint in e2e cluster. add 567621d Support `-` to

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365565822 ## File path:

[GitHub] [skywalking] codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573269476 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4214?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573269476 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4214?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365567916 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365567950 ## File path:

[GitHub] [skywalking] codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573269476 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4214?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365565043 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365564964 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365564913 ## File path:

[skywalking] branch percentile updated (c8ece13 -> d2ed279)

2020-01-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch percentile in repository https://gitbox.apache.org/repos/asf/skywalking.git. from c8ece13 Move break to right place. add d2ed279 Fix wrong break(s) No new revisions were added by

[GitHub] [skywalking] codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573269476 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4214?src=pr=h1) Report > Merging

[skywalking] branch percentile updated (d2ed279 -> da11ad3)

2020-01-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch percentile in repository https://gitbox.apache.org/repos/asf/skywalking.git. from d2ed279 Fix wrong break(s) add da11ad3 Fix break and add a test case for multiple values alarm. No

[skywalking] branch percentile updated (da11ad3 -> 35cf76e)

2020-01-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch percentile in repository https://gitbox.apache.org/repos/asf/skywalking.git. from da11ad3 Fix break and add a test case for multiple values alarm. add 35cf76e Fix format. No new

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365573087 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -51,13

[GitHub] [skywalking] aderm edited a comment on issue #4217: Add pom exclude licene file dir.

2020-01-12 Thread GitBox
aderm edited a comment on issue #4217: Add pom exclude licene file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573408013 Indeed yes This is an automated message from the Apache Git Service. To

[skywalking] branch agent_auth updated (9480420 -> 50aea09)

2020-01-12 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch agent_auth in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 9480420 Merge branch 'master' into agent_auth add 50aea09 update logical. No new revisions were

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4197: add token authentication between agent and oap receiver.

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4197: add token authentication between agent and oap receiver. URL: https://github.com/apache/skywalking/pull/4197#discussion_r365580404 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #4217: Add pom exclude licene file dir.

2020-01-12 Thread GitBox
aderm commented on a change in pull request #4217: Add pom exclude licene file dir. URL: https://github.com/apache/skywalking/pull/4217#discussion_r365584049 ## File path: pom.xml ## @@ -450,6 +450,12 @@

[GitHub] [skywalking] wu-sheng commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot

2020-01-12 Thread GitBox
wu-sheng commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573419345 Mine has been merged. This is an automated

[skywalking] branch agent_auth updated (50aea09 -> d2916a8)

2020-01-12 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch agent_auth in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 50aea09 update logical. add 9149de2 Support multiple linear values and merging p50/75/90/95/99

[GitHub] [skywalking] codecov-io commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot

2020-01-12 Thread GitBox
codecov-io commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573421072 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=h1) Report > :exclamation: No

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365572964 ## File path:

[GitHub] [skywalking] aderm opened a new pull request #4217: Add pom exclude licene file dir.

2020-01-12 Thread GitBox
aderm opened a new pull request #4217: Add pom exclude licene file dir. URL: https://github.com/apache/skywalking/pull/4217 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365572898 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -51,13

[GitHub] [skywalking] kezhenxu94 closed pull request #4218: Merge pull request #1 from apache/master

2020-01-12 Thread GitBox
kezhenxu94 closed pull request #4218: Merge pull request #1 from apache/master URL: https://github.com/apache/skywalking/pull/4218 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] aderm commented on issue #4217: Add pom exclude licene file dir.

2020-01-12 Thread GitBox
aderm commented on issue #4217: Add pom exclude licene file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573408013 > workspace Indeed yes This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng commented on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
wu-sheng commented on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573412403 @kezhenxu94 I add more docs to ease your concern, please recheck.

[GitHub] [skywalking] wu-sheng commented on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
wu-sheng commented on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573414131 @Fine0830 I will merge this tomorrow, then ask @ascrutae to deploy on the demo UI. Which will break part

[GitHub] [skywalking] mrproliu commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot

2020-01-12 Thread GitBox
mrproliu commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573417946 Now waiting for [Query profile graphQL](https://github.com/apache/skywalking-query-protocol/pull/29) merge.

[GitHub] [skywalking] akw123 commented on issue #2954: HTTP/2 client preface string missing or corrupt

2020-01-12 Thread GitBox
akw123 commented on issue #2954: HTTP/2 client preface string missing or corrupt URL: https://github.com/apache/skywalking/issues/2954#issuecomment-573420859 Hi Wu-sheng, I am currently doing a POC to adopt Skywalking in a major project. Along the setup, I;ve faced couple of

[GitHub] [skywalking] kezhenxu94 opened a new pull request #4221: Add alarm metrics OP >= and <=, and refactor the operator logics

2020-01-12 Thread GitBox
kezhenxu94 opened a new pull request #4221: Add alarm metrics OP >= and <=, and refactor the operator logics URL: https://github.com/apache/skywalking/pull/4221 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New

[GitHub] [skywalking-data-collect-protocol] arugal opened a new pull request #14: AdduniqueId for BrowserPerfData

2020-01-12 Thread GitBox
arugal opened a new pull request #14: AdduniqueId for BrowserPerfData URL: https://github.com/apache/skywalking-data-collect-protocol/pull/14 ref: [skywalking#4166](https://github.com/apache/skywalking/issues/4166) This is an

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365571766 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365571957 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -13,7

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365571790 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365572206 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -51,13

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365572111 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -13,7

[GitHub] [skywalking] codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573269476 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4214?src=pr=h1) Report > Merging

[GitHub] [skywalking] caoyongxing1985 opened a new pull request #4218: Merge pull request #1 from apache/master

2020-01-12 Thread GitBox
caoyongxing1985 opened a new pull request #4218: Merge pull request #1 from apache/master URL: https://github.com/apache/skywalking/pull/4218 test Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4197: add token authentication between agent and oap receiver.

2020-01-12 Thread GitBox
kezhenxu94 commented on a change in pull request #4197: add token authentication between agent and oap receiver. URL: https://github.com/apache/skywalking/pull/4197#discussion_r365575788 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4217: Add pom exclude licene file dir.

2020-01-12 Thread GitBox
wu-sheng commented on issue #4217: Add pom exclude licene file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573407832 I think you run the plugin test in the workspace, then this could trigger rat failure.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4217: Add pom exclude licene file dir.

2020-01-12 Thread GitBox
wu-sheng commented on a change in pull request #4217: Add pom exclude licene file dir. URL: https://github.com/apache/skywalking/pull/4217#discussion_r365581246 ## File path: pom.xml ## @@ -450,6 +450,12 @@

[GitHub] [skywalking] mrproliu opened a new pull request #4220: [WIP] sniffer processing profile task and report status and snapshot

2020-01-12 Thread GitBox
mrproliu opened a new pull request #4220: [WIP] sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ]

[GitHub] [skywalking] kezhenxu94 merged pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 merged pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214 This is an automated message from the Apache Git Service.

[skywalking] branch master updated: Support multiple linear values and merging p50/75/90/95/99 into percentile (#4214)

2020-01-12 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 9149de2 Support multiple linear values

[GitHub] [skywalking] codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573269476 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4214?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 closed issue #4190: Recommendations for reducing the number of indexes

2020-01-12 Thread GitBox
kezhenxu94 closed issue #4190: Recommendations for reducing the number of indexes URL: https://github.com/apache/skywalking/issues/4190 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] kezhenxu94 commented on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
kezhenxu94 commented on issue #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#issuecomment-573419032 I'll open a follow-up PR to do some refactoring work

[GitHub] [skywalking] codecov-io edited a comment on issue #4220: [WIP] sniffer processing profile task and report status and snapshot

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4220: [WIP] sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573421072 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=h1) Report > Merging

[GitHub] [skywalking] aderm commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
aderm commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365588946 ## File path:

[skywalking] branch master updated: add token authentication between agent and oap receiver. (#4197)

2020-01-12 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 1310719 add token authentication between

[GitHub] [skywalking] JaredTan95 merged pull request #4197: add token authentication between agent and oap receiver.

2020-01-12 Thread GitBox
JaredTan95 merged pull request #4197: add token authentication between agent and oap receiver. URL: https://github.com/apache/skywalking/pull/4197 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile

2020-01-12 Thread GitBox
wu-sheng commented on a change in pull request #4214: Support multiple linear values and merging p50/75/90/95/99 into percentile URL: https://github.com/apache/skywalking/pull/4214#discussion_r365572760 ## File path:

[GitHub] [skywalking] aderm commented on issue #4217: Add pom exclude licene file dir.

2020-01-12 Thread GitBox
aderm commented on issue #4217: Add pom exclude licene file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573402336 However, when executing this command `./mvnw install -Pagent -DskipTests`, the following error will occur. Personally, I think that a reasonable

[GitHub] [skywalking] codecov-io commented on issue #4217: Add pom exclude licene file dir.

2020-01-12 Thread GitBox
codecov-io commented on issue #4217: Add pom exclude licene file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4217: Add pom exclude licene file dir.

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4217: Add pom exclude licene file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr=h1) Report > Merging

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #4197: add token authentication between agent and oap receiver.

2020-01-12 Thread GitBox
JaredTan95 commented on a change in pull request #4197: add token authentication between agent and oap receiver. URL: https://github.com/apache/skywalking/pull/4197#discussion_r365579674 ## File path:

[skywalking] branch percentile updated (35cf76e -> cf6ea41)

2020-01-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch percentile in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 35cf76e Fix format. add cf6ea41 Add more doc for this new feature and GraphQL query protocol. No

[GitHub] [skywalking] wu-sheng opened a new issue #4219: Support new Pxx metrics in UI

2020-01-12 Thread GitBox
wu-sheng opened a new issue #4219: Support new Pxx metrics in UI URL: https://github.com/apache/skywalking/issues/4219 Due to #4214, new protocol and implementation provided for Pxx. The UI should adopt this feature. This is

[GitHub] [skywalking] wu-sheng commented on issue #4219: Support new Pxx metrics in UI

2020-01-12 Thread GitBox
wu-sheng commented on issue #4219: Support new Pxx metrics in UI URL: https://github.com/apache/skywalking/issues/4219#issuecomment-573423000 Demo env updated, please fix the UI ASAP, due to the demo is not working well. Very appreciated. @Fine0830

[GitHub] [skywalking] codecov-io edited a comment on issue #4197: add token authentication between agent and oap receiver.

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4197: add token authentication between agent and oap receiver. URL: https://github.com/apache/skywalking/pull/4197#issuecomment-57063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4197?src=pr=h1) Report > :exclamation: No coverage

[GitHub] [skywalking] codecov-io edited a comment on issue #4197: add token authentication between agent and oap receiver.

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4197: add token authentication between agent and oap receiver. URL: https://github.com/apache/skywalking/pull/4197#issuecomment-57063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4197?src=pr=h1) Report > :exclamation: No coverage

[GitHub] [skywalking-kubernetes] hanahmily commented on a change in pull request #38: 6.6.0-es6 and 6.6.0-es7

2020-01-12 Thread GitBox
hanahmily commented on a change in pull request #38: 6.6.0-es6 and 6.6.0-es7 URL: https://github.com/apache/skywalking-kubernetes/pull/38#discussion_r365622234 ## File path: README.md ## @@ -6,16 +6,24 @@ Apache SkyWalking Kubernetes To install and configure skywalking

[GitHub] [skywalking] stalary commented on issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx}

2020-01-12 Thread GitBox
stalary commented on issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx} URL: https://github.com/apache/skywalking/issues/4222#issuecomment-573486366 ` 2020-01-13 10:11:38,866 -

[GitHub] [skywalking] stalary edited a comment on issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx}

2020-01-12 Thread GitBox
stalary edited a comment on issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx} URL: https://github.com/apache/skywalking/issues/4222#issuecomment-573486366 ``` 2020-01-13 10:11:38,866 -

[GitHub] [skywalking] mrproliu commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot

2020-01-12 Thread GitBox
mrproliu commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573515947 > There is following error in CI process > > ``` > DEBUG 2020-01-13 01:03:10:798

[GitHub] [skywalking] codecov-io edited a comment on issue #4220: [WIP] sniffer processing profile task and report status and snapshot

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4220: [WIP] sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573421072 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=h1) Report > Merging

[skywalking-data-collect-protocol] branch master updated: add uniqueId (#14)

2020-01-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git The following commit(s) were added to refs/heads/master by this push: new 159c900 add

[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request #14: Add uniqueId for BrowserPerfData

2020-01-12 Thread GitBox
wu-sheng merged pull request #14: Add uniqueId for BrowserPerfData URL: https://github.com/apache/skywalking-data-collect-protocol/pull/14 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
wu-sheng commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573522600 If no client-side span, there is no client-side metrics of topology. Then you would detect the error of unreachable or network perf unstable issues from trace

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573524127 I agree with you, the error of unreachable or network perf unstable issues are also important for service. I can simplify client-side tracing for this,

[GitHub] [skywalking] wu-sheng closed issue #4195: Clicking on the search will reset the selection criteria

2020-01-12 Thread GitBox
wu-sheng closed issue #4195: Clicking on the search will reset the selection criteria URL: https://github.com/apache/skywalking/issues/4195 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573499115 In the default config, all gRPC calls are internal calls. No client-side tracing will be created. I think the default config is enough for most cases (most of

[GitHub] [skywalking] devkanro edited a comment on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
devkanro edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573499115 In the default config, all gRPC calls are internal calls. No client-side tracing will be created. I think the default config is enough for most

[GitHub] [skywalking] wu-sheng commented on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
wu-sheng commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573529288 > I can simplify client-side tracing for this, like no onMessage event, only Complete/Close event for internal client-side tracing. I think in most

[GitHub] [skywalking] wu-sheng commented on issue #4169: FAQ for backend log4j2.xml

2020-01-12 Thread GitBox
wu-sheng commented on issue #4169: FAQ for backend log4j2.xml URL: https://github.com/apache/skywalking/pull/4169#issuecomment-573477373 @seifeHu Could you update this PR? This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng commented on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
wu-sheng commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573482503 > Internal and external gRPC server tracing It is still unclear for me about this section. Client/server side tracing are both required in nearly every

[GitHub] [skywalking] stalary opened a new issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx}

2020-01-12 Thread GitBox
stalary opened a new issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx} URL: https://github.com/apache/skywalking/issues/4222 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x]

[GitHub] [skywalking] stalary commented on issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx}

2020-01-12 Thread GitBox
stalary commented on issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx} URL: https://github.com/apache/skywalking/issues/4222#issuecomment-573486788 Too many warnings made it impossible for me to view the service log properly

[GitHub] [skywalking] codecov-io edited a comment on issue #4217: Add pom exclude license file dir.

2020-01-12 Thread GitBox
codecov-io edited a comment on issue #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr=h1) Report > Merging

[GitHub] [skywalking] f02061232-1 opened a new issue #4223: What's the usage of network_address_inventory and where its data come from?

2020-01-12 Thread GitBox
f02061232-1 opened a new issue #4223: What's the usage of network_address_inventory and where its data come from? URL: https://github.com/apache/skywalking/issues/4223 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Question or

[GitHub] [skywalking] stalary closed issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx}

2020-01-12 Thread GitBox
stalary closed issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx} URL: https://github.com/apache/skywalking/issues/4222 This is an automated message from the Apache Git

[GitHub] [skywalking] stalary commented on issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx}

2020-01-12 Thread GitBox
stalary commented on issue #4222: Unexpected endpoint register, endpoint isn't detected from server side. endpoints{xxx} URL: https://github.com/apache/skywalking/issues/4222#issuecomment-573487655

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573529847 You convinced me, the client-side tracing is also important to trace. This is an automated

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573498339 @wu-sheng If you trace the both of client and server-side, you would get the tracing like blow of bi-streaming call: ``` + | +-+(Server1) Exit:

[GitHub] [skywalking] aderm commented on a change in pull request #4217: Add pom exclude license file dir.

2020-01-12 Thread GitBox
aderm commented on a change in pull request #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217#discussion_r365640282 ## File path: pom.xml ## @@ -450,6 +450,12 @@

[GitHub] [skywalking-kubernetes] hanahmily commented on issue #38: 6.6.0-es6 and 6.6.0-es7

2020-01-12 Thread GitBox
hanahmily commented on issue #38: 6.6.0-es6 and 6.6.0-es7 URL: https://github.com/apache/skywalking-kubernetes/pull/38#issuecomment-573474226 > The helm stable repo does not support es7, so I use the es official chart library, but there is no way to > denpendence on the chart to

[GitHub] [skywalking] aderm commented on a change in pull request #4217: Add pom exclude license file dir.

2020-01-12 Thread GitBox
aderm commented on a change in pull request #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217#discussion_r365640282 ## File path: pom.xml ## @@ -450,6 +450,12 @@

[GitHub] [skywalking] Fine0830 commented on issue #4219: Support new Pxx metrics in UI

2020-01-12 Thread GitBox
Fine0830 commented on issue #4219: Support new Pxx metrics in UI URL: https://github.com/apache/skywalking/issues/4219#issuecomment-573488542 OK. I will do that. 获取 Outlook for Android From: 吴晟 Wu Sheng Sent:

[GitHub] [skywalking] wu-sheng commented on issue #4223: What's the usage of network_address_inventory and where its data come from?

2020-01-12 Thread GitBox
wu-sheng commented on issue #4223: What's the usage of network_address_inventory and where its data come from? URL: https://github.com/apache/skywalking/issues/4223#issuecomment-573490842 If You want to understand this. You need to understand the topology detection. I am trying to write a

[GitHub] [skywalking] wu-sheng closed issue #4223: What's the usage of network_address_inventory and where its data come from?

2020-01-12 Thread GitBox
wu-sheng closed issue #4223: What's the usage of network_address_inventory and where its data come from? URL: https://github.com/apache/skywalking/issues/4223 This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] devkanro removed a comment on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
devkanro removed a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-57357 The original plugin doesn't provide the client-side tracing, I add it for my case and optional powerful tracing.

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

2020-01-12 Thread GitBox
devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-57357 The original plugin doesn't provide the client-side tracing, I add it for my case and optional powerful tracing.

[GitHub] [skywalking] wu-sheng commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot

2020-01-12 Thread GitBox
wu-sheng commented on issue #4220: [WIP] sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573480632 There is following error in CI process ``` DEBUG 2020-01-13 01:03:10:798

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #14: Add uniqueId for BrowserPerfData

2020-01-12 Thread GitBox
wu-sheng commented on a change in pull request #14: Add uniqueId for BrowserPerfData URL: https://github.com/apache/skywalking-data-collect-protocol/pull/14#discussion_r365624786 ## File path: browser/BrowserPerf.proto ## @@ -30,17 +30,19 @@ service BrowserPerfService {

  1   2   >