wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378088298
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/co
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378089483
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378090251
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/co
codecov-io edited a comment on issue #4239: Provide influxdb as a new storage
plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr&el=h1)
Report
> Merging
[#4239](https://codecov.io/gh/apa
JaredTan95 merged pull request #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from e5366c0 Tag annotation supports returned expression (#4327)
add 7ff9a0c supprt gRPC alarm hook. (#4344)
JaredTan95 commented on issue #3752: Add gRPCHook to alarm-settings.yml
URL: https://github.com/apache/skywalking/issues/3752#issuecomment-585086836
provided.
This is an automated message from the Apache Git Service.
To respon
JaredTan95 closed issue #3752: Add gRPCHook to alarm-settings.yml
URL: https://github.com/apache/skywalking/issues/3752
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
kezhenxu94 commented on a change in pull request #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#discussion_r378103923
##
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378091398
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/co
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378110934
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywal
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378093441
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywal
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378094991
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/co
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378094387
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywal
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378091521
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/co
wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#discussion_r378111507
##
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.j
Fine0830 commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-585121955
I add `jsErrorPv` in error log protocol to mark. @arugal You need update the
protocol as well.
-
Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-585121955
I add `jsErrorPv` in error log protocol to mark. When `jsErrorPv` equal true
in one error log, pv with JS error will be plus 1. @arugal You n
wu-sheng commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-585124578
@Fine0830 I think (isFirstPageErrorReport) should be a better name in the
protocol?
Fine0830 commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-585127170
> @Fine0830 I think (isFirstPageErrorReport) should be a better name in the
protocol?
Hmm... isFirstPageJSErrorReport ? We will have other err
Fine0830 commented on a change in pull request #6: Feat: add performance data
URL: https://github.com/apache/skywalking-client-js/pull/6#discussion_r378150699
##
File path: src/performance/index.ts
##
@@ -0,0 +1,55 @@
+
+/**
+ * Licensed to the Apache Software Foundation (A
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378153034
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378179210
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalkin
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378197273
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378197175
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378198260
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalkin
wu-sheng commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-585183984
I mean, `jsErrorPv` is not clear for its purpose. So I suggest changing it
named as `firstReportedError`.
--
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378223460
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywal
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378225818
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/co
arugal opened a new pull request #19: Add firstReportedError field
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/19
Concern at
https://github.com/apache/skywalking/pull/4228#issuecomment-584992794.
This
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch disable_profile_idx
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 3f65a73 Make Profile entities could be disable by OAL
This branch includes the following new comm
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch disable_profile_idx
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 3f65a732d01e1b14db4a8298ac3a45c414ae6b95
Author: Wu Sheng
AuthorDate: Wed Feb 12 21:38:09 2020 +0800
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch disable_profile_idx
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/disable_profile_idx by this
push:
new d1e865f Rename
wu-sheng opened a new pull request #4354: Make Profile entities could be
disable by OAL
URL: https://github.com/apache/skywalking/pull/4354
We missed the supports of `disable` for these three new entities of profile.
We provide the `disable` capability to end-users for every single o
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378255741
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378255741
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378255741
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378257166
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalkin
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch disable_profile_idx
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from d1e865f Rename a comment to avoid misguide.
add ed0ceb1 Fill commented OAL scripts.
No new
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch disable_profile_idx
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from ed0ceb1 Fill commented OAL scripts.
add da71795 Make name better rather than duplicated.
No
codecov-io commented on issue #4354: Make Profile entities could be disable by
OAL
URL: https://github.com/apache/skywalking/pull/4354#issuecomment-585228386
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4354?src=pr&el=h1)
Report
> Merging
[#4354](https://codecov.io/gh/apach
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch disable_profile_idx
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from da71795 Make name better rather than duplicated.
add 512e48f Format some files.
No new revi
wu-sheng commented on a change in pull request #19: Add firstReportedError field
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/19#discussion_r378298953
##
File path: browser/BrowserPerf.proto
##
@@ -45,15 +45,17 @@ message BrowserPerfData {
// P
wu-sheng merged pull request #4354: Make Profile entities could be disable by
OAL
URL: https://github.com/apache/skywalking/pull/4354
This is an automated message from the Apache Git Service.
To respond to the message, pleas
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 7ff9a0c supprt gRPC alarm hook. (#4344)
add 7c6016b Make Profile entities could be disable by OAL (#4354)
cui-liqiang opened a new pull request #4355: some code style and refactor
URL: https://github.com/apache/skywalking/pull/4355
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve pe
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch comments
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 7e844fd91e3ff8e6fde73339c38d7281de9ab557
Author: Wu Sheng
AuthorDate: Thu Feb 13 09:40:44 2020 +0800
Fill so
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch comments
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 7e844fd Fill some comments for core.
This branch includes the following new commits:
new 7e844fd Fill
wu-sheng opened a new pull request #4356: Fill some comments for core.
URL: https://github.com/apache/skywalking/pull/4356
Spend 1 hour to fill more comments in the core, should be helpful for people
to read the source codes.
FYI @apache/skywalking-committers Feel free to add more i
JaredTan95 commented on issue #4356: Fill some comments for core.
URL: https://github.com/apache/skywalking/pull/4356#issuecomment-585508991
seems CI is not stable~
This is an automated message from the Apache Git Service.
To
wu-sheng commented on issue #4356: Fill some comments for core.
URL: https://github.com/apache/skywalking/pull/4356#issuecomment-585509387
Checking whether there is format issue now.
This is an automated message from the Apach
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch comments
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 7e844fd Fill some comments for core.
add f0b1b9c Fix a comment issue.
No new revisions were added by t
kezhenxu94 commented on issue #4355: some code style and refactor
URL: https://github.com/apache/skywalking/pull/4355#issuecomment-585519526
All plugin tests have passed except for one, PlayFramework, just because of
network issue, and I'm sure it's not related to the changes here, I'll mer
kezhenxu94 edited a comment on issue #4355: some code style and refactor
URL: https://github.com/apache/skywalking/pull/4355#issuecomment-585519526
All plugin tests have passed except for one, PlayFramework, just because of
network issue, and I'm sure it's not related to the changes here, I
kezhenxu94 merged pull request #4355: some code style and refactor
URL: https://github.com/apache/skywalking/pull/4355
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 7c6016b Make Profile entities could be disable by OAL (#4354)
add c761f30 Some code style and refactor
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch comments
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from f0b1b9c Fix a comment issue.
add c761f30 Some code style and refactor (#4355)
add 4f9d966 Merg
wu-sheng merged pull request #19: Add firstReportedError field
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, pleas
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git
The following commit(s) were added to refs/heads/master by this push:
new 3711072 add firstRe
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 0300048 Fill some comments for core. (#435
wu-sheng merged pull request #4356: Fill some comments for core.
URL: https://github.com/apache/skywalking/pull/4356
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378636611
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalkin
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378636611
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalkin
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378636611
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalkin
aderm commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378636611
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalkin
wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378673889
##
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywal
66 matches
Mail list logo