[GitHub] [skywalking] dmsolr commented on a change in pull request #4847: [WIP]Provide kafka as collector/reporter

2020-06-22 Thread GitBox
dmsolr commented on a change in pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#discussion_r443930241 ## File path:

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #320: Feat: Add status color in trace table

2020-06-22 Thread GitBox
Fine0830 opened a new pull request #320: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/320 Reference https://github.com/apache/skywalking/issues/4861 screenshots

[GitHub] [skywalking] IanCao edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647902479 > > Also, I noticed, there is brpc 3.x, do you plan to support it too? > > ok, let me investigate This seems a bit difficult

[GitHub] [skywalking] wu-sheng closed issue #4749: [Python] Add agent plugin test tool to the Python repo

2020-06-22 Thread GitBox
wu-sheng closed issue #4749: URL: https://github.com/apache/skywalking/issues/4749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #4749: [Python] Add agent plugin test tool to the Python repo

2020-06-22 Thread GitBox
wu-sheng commented on issue #4749: URL: https://github.com/apache/skywalking/issues/4749#issuecomment-647848481 Fixed through https://github.com/apache/skywalking-python/pull/10 This is an automated message from the Apache

[GitHub] [skywalking] dmsolr commented on a change in pull request #4847: [WIP]Provide kafka as collector/reporter

2020-06-22 Thread GitBox
dmsolr commented on a change in pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#discussion_r443929097 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
wu-sheng commented on issue #4861: URL: https://github.com/apache/skywalking/issues/4861#issuecomment-647884645 @regardfs If you could the trace query result(Graphql response), it would be helpful to identify the issue.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] Fine0830 commented on issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
Fine0830 commented on issue #4861: URL: https://github.com/apache/skywalking/issues/4861#issuecomment-647887500 Probably there is another possibility that @regardfs misunderstand the trace table. Now the trace table doesn't show error status, like trace list. If it's necessary, I can

[GitHub] [skywalking] IanCao commented on a change in pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao commented on a change in pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#discussion_r443941693 ## File path: oap-server/server-core/src/test/resources/component-libraries.yml ## @@ -266,6 +266,9 @@ InfluxDB: influxdb-java: id: 90

[GitHub] [skywalking] IanCao commented on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647887378 > Also, I noticed, there is brpc 3.x, do you plan to support it too? ok, let me investigate This is an

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4847: [WIP]Provide kafka as collector/reporter

2020-06-22 Thread GitBox
wu-sheng commented on a change in pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#discussion_r443915063 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/JVMServiceSenderImpl.java ## @@ -0,0 +1,109 @@ +/* +

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
wu-sheng commented on issue #4861: URL: https://github.com/apache/skywalking/issues/4861#issuecomment-647887880 Oh, I think that is the case, let's add it in 8.1.0 This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] IanCao commented on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647902479 > > Also, I noticed, there is brpc 3.x, do you plan to support it too? > > ok, let me investigate This seems a bit difficult

[GitHub] [skywalking] wu-sheng closed issue #4872: When the redis operation is abnormal, the span information is lost

2020-06-22 Thread GitBox
wu-sheng closed issue #4872: URL: https://github.com/apache/skywalking/issues/4872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #4872: When the redis operation is abnormal, the span information is lost

2020-06-22 Thread GitBox
wu-sheng commented on issue #4872: URL: https://github.com/apache/skywalking/issues/4872#issuecomment-647847817 No update in 15 days, closing. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] IanCao commented on a change in pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao commented on a change in pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#discussion_r443941636 ## File path: oap-server/server-bootstrap/src/main/resources/component-libraries.yml ## @@ -302,6 +302,9 @@ InfluxDB: influxdb-java: id: 90

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4808: Provide client-side meter system

2020-06-22 Thread GitBox
wu-sheng commented on issue #4808: URL: https://github.com/apache/skywalking/issues/4808#issuecomment-647846882 Is there a server-side meter system issue? We need to track the process. @mrproliu This is an automated

[GitHub] [skywalking] wu-sheng closed issue #4808: Provide client-side meter system

2020-06-22 Thread GitBox
wu-sheng closed issue #4808: URL: https://github.com/apache/skywalking/issues/4808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng closed issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
wu-sheng closed issue #4861: URL: https://github.com/apache/skywalking/issues/4861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #320: Feat: Add status color in trace table

2020-06-22 Thread GitBox
wu-sheng merged pull request #320: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[skywalking-rocketbot-ui] branch master updated: feat: add status color (#320)

2020-06-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-rocketbot-ui.git The following commit(s) were added to refs/heads/master by this push: new 7bd1094 feat: add status

[skywalking-kubernetes] tag v3.0.0 created (now 25ca1ba)

2020-06-22 Thread innerpeacez
This is an automated email from the ASF dual-hosted git repository. innerpeacez pushed a change to tag v3.0.0 in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. at 25ca1ba (commit) No new revisions were added by this update.

[GitHub] [skywalking] Fine0830 commented on issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
Fine0830 commented on issue #4861: URL: https://github.com/apache/skywalking/issues/4861#issuecomment-647879190 @regardfs Now, UI according to `isError` from server data to visualize trace list. I didn't find this error case. Could you check if your data that `isError` is true but logs

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] wu-sheng commented on issue #4957: skywalking has some problem with webflux

2020-06-22 Thread GitBox
wu-sheng commented on issue #4957: URL: https://github.com/apache/skywalking/issues/4957#issuecomment-647304864 This is the case we tested, https://github.com/apache/skywalking/tree/master/test/plugin/scenarios/webflux-scenario You could cross-check the difference.

[GitHub] [skywalking] zifeihan commented on pull request #4952: Don't trace anything if the backend is not available.

2020-06-22 Thread GitBox
zifeihan commented on pull request #4952: URL: https://github.com/apache/skywalking/pull/4952#issuecomment-647329834 @wu-sheng sorry, origin code is ok, this Config.Agent.KEEP_TRACING means Keep tracing even the backend is not available... sorry.

[GitHub] [skywalking] zifeihan closed pull request #4952: Don't trace anything if the backend is not available.

2020-06-22 Thread GitBox
zifeihan closed pull request #4952: URL: https://github.com/apache/skywalking/pull/4952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking-website] BFergerson commented on pull request #93: Added new committer

2020-06-22 Thread GitBox
BFergerson commented on pull request #93: URL: https://github.com/apache/skywalking-website/pull/93#issuecomment-647329817 @wu-sheng, no worries. You just want the commits to `docs/team/README.md` and `docs/zh/team/README.md`?

[GitHub] [skywalking-website] wu-sheng merged pull request #95: Add new committer

2020-06-22 Thread GitBox
wu-sheng merged pull request #95: URL: https://github.com/apache/skywalking-website/pull/95 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[skywalking-website] branch asf-site updated (e64c6a8 -> fcd9f93)

2020-06-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard e64c6a8 Update asf-site new fcd9f93 Update asf-site This update added new revisions after

[skywalking-website] branch master updated: Add new committer (#95)

2020-06-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 0f4bd8f Add new committer (#95)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp opened a new pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
EvanLjp opened a new pull request #4959: URL: https://github.com/apache/skywalking/pull/4959 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] New feature provided - Related issues

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] EvanLjp commented on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
EvanLjp commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647418288 I will add unit tests later, thanks for review first This is an automated message from the Apache Git

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr=h1) Report > Merging

  1   2   3   >