[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
wu-sheng commented on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-651587151 CI error logs show that. Your local `mvn package` doesn't include Javadoc. I think you should try`mvn javadoc:javadoc`?

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4992: Calling Python agent failed

2020-06-30 Thread GitBox
wu-sheng commented on issue #4992: URL: https://github.com/apache/skywalking/issues/4992#issuecomment-651600714 No Django plugin, read #4744. Please don't submit duplicated issue. This is an automated message from the Apache

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng closed issue #4992: Calling Python agent failed

2020-06-30 Thread GitBox
wu-sheng closed issue #4992: URL: https://github.com/apache/skywalking/issues/4992 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking-python] wu-sheng commented on a change in pull request #27: Add docs on how to install from Pypi

2020-06-30 Thread GitBox
wu-sheng commented on a change in pull request #27: URL: https://github.com/apache/skywalking-python/pull/27#discussion_r447454283 ## File path: README.md ## @@ -13,6 +13,20 @@ microservices, cloud native and container-based (Docker, Kubernetes, Mesos) arch

[GitHub] [skywalking-python] wu-sheng commented on a change in pull request #27: Add docs on how to install from Pypi

2020-06-30 Thread GitBox
wu-sheng commented on a change in pull request #27: URL: https://github.com/apache/skywalking-python/pull/27#discussion_r447454465 ## File path: README.md ## @@ -13,6 +13,20 @@ microservices, cloud native and container-based (Docker, Kubernetes, Mesos) arch

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651567868 I also thought about making it plug-in for example: 1. the GlobalIdGenerator add a function Supplier method to To expose the algorithm implementation 2. a plugin service

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] kylixs commented on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
kylixs commented on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-651585952 > There are Java-Doc error (not warning) in your codes. where is the javadoc error? I build agent successful on my macOS.

[GitHub] [skywalking] kylixs commented on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
kylixs commented on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-651598283 > CI error logs show that. Your local `mvn package` doesn't include Javadoc. I think you should try`mvn javadoc:javadoc`? javadoc error is not easy to locate, too much

[GitHub] [skywalking] wu-sheng commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
wu-sheng commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651580558 I don't think setting the global trace id is a good idea. Basically, and mostly in SkyWalking, we do auto-instrumentation, right? The app developer is mostly impossible to set

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] yue-chao opened a new issue #4992: Calling Python agent failed

2020-06-30 Thread GitBox
yue-chao opened a new issue #4992: URL: https://github.com/apache/skywalking/issues/4992 Please answer these questions before submitting your issue. - Why do you submit this issue? - [*] Question or discussion ___ ### Question - What do you want to know?

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651592080 in our company , all pv coross bfe (cncf) ,and all the pv will be add a unique bfeid as a http header. we want to use bfeid as a part of traceid. I know this is a abnormal

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[skywalking-python] branch docs/install-from-pypi updated (f737186 -> 0e9eb6f)

2020-06-30 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch docs/install-from-pypi in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. discard f737186 Add docs on how to install from Pypi add 0e9eb6f Add docs on how to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp opened a new issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp opened a new issue #4991: URL: https://github.com/apache/skywalking/issues/4991 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion In some business scenarios, custom traceid generation rules need to

[GitHub] [skywalking] wu-sheng commented on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
wu-sheng commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-651583521 @EvanLjp Could you make this PR ready? This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
wu-sheng commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651606975 I have a feeling, you treat trace context in an easier way, which is not correct. No matter what in the header(in HTTP only), we should not use it as a trace, because

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
wu-sheng commented on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-651582442 There are Java-Doc error (not warning) in your codes. This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
wu-sheng commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651581468 `GlobalIdGenerator` should be refactored as a service, which could provide the override mechanism in the plugin system. But if this is an internal service, which generation

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651595221 I thought about it again, this thing is not suitable for appearing in the official version,If the set method is added, basically no one else will use it in official plugin

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651611657 I know your feeling,thanks for your helping This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] kylixs commented on a change in pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
kylixs commented on a change in pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#discussion_r447492784 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java ## @@

[skywalking-query-protocol] branch master updated: Provide v2 of endpoint topology query. In order to make the UI could query metrics for the endpoint dependencies in v2.

2020-06-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git The following commit(s) were added to refs/heads/master by this push: new bea847b Provide v2 of

[GitHub] [skywalking] bonnieguo commented on issue #4994: dose the OAL support the not op in filter?

2020-06-30 Thread GitBox
bonnieguo commented on issue #4994: URL: https://github.com/apache/skywalking/issues/4994#issuecomment-651700268 so you mean the percent not support for the endpoint level ? This is an automated message from the Apache Git

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4995: Fix endpoint dependency bug in MQ and uninstrumented proxy cases, and support endpoint dependency(v2 of endpoint topology cas

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4995: URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4995: Fix endpoint dependency bug in MQ and uninstrumented proxy cases, and support endpoint dependency(v2 of endpoint topology cas

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4995: URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4995: Fix endpoint dependency bug in MQ and uninstrumented proxy cases, and support endpoint dependency(v2 of endpoint topology cas

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4995: URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4995: Fix endpoint dependency bug in MQ and uninstrumented proxy cases, and support endpoint dependency(v2 of endpoint topology cas

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4995: URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4995: Fix endpoint dependency bug in MQ and uninstrumented proxy cases, and support endpoint dependency(v2 of endpoint topology cas

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4995: URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4995: Fix endpoint dependency bug in MQ and uninstrumented proxy cases, and support endpoint dependency(v2 of endpoint topology cas

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4995: URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4994: dose the OAL support the not op in filter?

2020-06-30 Thread GitBox
wu-sheng commented on issue #4994: URL: https://github.com/apache/skywalking/issues/4994#issuecomment-651672167 First of all, no matter there is or not. Your percent func usage is not correct. This is the right one. > service_sla = from(Service.*).percent(status == true); Then

[GitHub] [skywalking] IanCao opened a new issue #4996: Support GraphQL `logic-endpoint` series tag(s)

2020-06-30 Thread GitBox
IanCao opened a new issue #4996: URL: https://github.com/apache/skywalking/issues/4996 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4995: Fix endpoint dependency bug in MQ and uninstrumented proxy cases, and support endpoint dependency(v2 of endpoint topology cas

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4995: URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1) Report > Merging

[GitHub] [skywalking] bonnieguo commented on issue #4994: dose the OAL support the not op in filter?

2020-06-30 Thread GitBox
bonnieguo commented on issue #4994: URL: https://github.com/apache/skywalking/issues/4994#issuecomment-651725186 i just get it from the example: // Caculate the percent of response status is true, for each service. Endpoint_success = from(Endpoint.*).filter(status = "true").percent()

[GitHub] [skywalking] EvanLjp closed issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp closed issue #4991: URL: https://github.com/apache/skywalking/issues/4991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng opened a new issue #4993: [Python agent] Add python plugin dev doc

2020-06-30 Thread GitBox
wu-sheng opened a new issue #4993: URL: https://github.com/apache/skywalking/issues/4993 We should add this, python agent uses different instrumentation APIs and the tracing context APIs. This is an automated message from

[GitHub] [skywalking] wu-sheng opened a new pull request #4995: Fix endpoint dependency bug in MQ and uninstrumented proxy cases, and support endpoint dependency(v2 of endpoint topology case).

2020-06-30 Thread GitBox
wu-sheng opened a new pull request #4995: URL: https://github.com/apache/skywalking/pull/4995 1. Fix endpoint dependency bug in MQ and uninstrumented proxy cases. The new `MultiScopesAnalysisListenerTest` is really helpful on locating this complex analysis issue. 1. Support endpoint

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4995: Fix endpoint dependency bug in MQ and uninstrumented proxy cases, and support endpoint dependency(v2 of endpoint topology cas

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4995: URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng closed issue #4994: dose the OAL support the not op in filter?

2020-06-30 Thread GitBox
wu-sheng closed issue #4994: URL: https://github.com/apache/skywalking/issues/4994 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #4994: dose the OAL support the not op in filter?

2020-06-30 Thread GitBox
wu-sheng commented on issue #4994: URL: https://github.com/apache/skywalking/issues/4994#issuecomment-651725634 Real case is in core.oal This is an automated message from the Apache Git Service. To respond to the message,

[skywalking-python] branch master updated: Add docs on how to install from Pypi (#27)

2020-06-30 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/master by this push: new bdcf618 Add docs on how to

[GitHub] [skywalking-python] kezhenxu94 merged pull request #27: Add docs on how to install from Pypi

2020-06-30 Thread GitBox
kezhenxu94 merged pull request #27: URL: https://github.com/apache/skywalking-python/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
wu-sheng commented on a change in pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#discussion_r447485936 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java ##

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
wu-sheng commented on a change in pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#discussion_r447486623 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java ##

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4858: support class cache for ByteBuddy

2020-06-30 Thread GitBox
wu-sheng commented on a change in pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#discussion_r447485936 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java ##

  1   2   3   4   5   >