codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
wu-sheng commented on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-651587151
CI error logs show that. Your local `mvn package` doesn't include Javadoc. I
think you should try`mvn javadoc:javadoc`?
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #4992:
URL: https://github.com/apache/skywalking/issues/4992#issuecomment-651600714
No Django plugin, read #4744. Please don't submit duplicated issue.
This is an automated message from the Apache
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
wu-sheng closed issue #4992:
URL: https://github.com/apache/skywalking/issues/4992
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
wu-sheng commented on a change in pull request #27:
URL: https://github.com/apache/skywalking-python/pull/27#discussion_r447454283
##
File path: README.md
##
@@ -13,6 +13,20 @@ microservices, cloud native and container-based (Docker,
Kubernetes, Mesos) arch
wu-sheng commented on a change in pull request #27:
URL: https://github.com/apache/skywalking-python/pull/27#discussion_r447454465
##
File path: README.md
##
@@ -13,6 +13,20 @@ microservices, cloud native and container-based (Docker,
Kubernetes, Mesos) arch
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
EvanLjp commented on issue #4991:
URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651567868
I also thought about making it plug-in
for example:
1. the GlobalIdGenerator add a function Supplier method to To expose the
algorithm implementation
2. a plugin service
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
kylixs commented on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-651585952
> There are Java-Doc error (not warning) in your codes.
where is the javadoc error? I build agent successful on my macOS.
kylixs commented on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-651598283
> CI error logs show that. Your local `mvn package` doesn't include Javadoc.
I think you should try`mvn javadoc:javadoc`?
javadoc error is not easy to locate, too much
wu-sheng commented on issue #4991:
URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651580558
I don't think setting the global trace id is a good idea. Basically, and
mostly in SkyWalking, we do auto-instrumentation, right?
The app developer is mostly impossible to set
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
yue-chao opened a new issue #4992:
URL: https://github.com/apache/skywalking/issues/4992
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [*] Question or discussion
___
### Question
- What do you want to know?
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
EvanLjp commented on issue #4991:
URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651592080
in our company , all pv coross bfe (cncf) ,and all the pv will be add a
unique bfeid as a http header.
we want to use bfeid as a part of traceid.
I know this is a abnormal
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch docs/install-from-pypi
in repository https://gitbox.apache.org/repos/asf/skywalking-python.git.
discard f737186 Add docs on how to install from Pypi
add 0e9eb6f Add docs on how to
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
EvanLjp opened a new issue #4991:
URL: https://github.com/apache/skywalking/issues/4991
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
In some business scenarios, custom traceid generation rules need to
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-651583521
@EvanLjp Could you make this PR ready?
This is an automated message from the Apache Git Service.
To respond
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #4991:
URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651606975
I have a feeling, you treat trace context in an easier way, which is not
correct.
No matter what in the header(in HTTP only), we should not use it as a trace,
because
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
wu-sheng commented on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-651582442
There are Java-Doc error (not warning) in your codes.
This is an automated message from the Apache Git
wu-sheng commented on issue #4991:
URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651581468
`GlobalIdGenerator` should be refactored as a service, which could provide
the override mechanism in the plugin system. But if this is an internal
service, which generation
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
EvanLjp commented on issue #4991:
URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651595221
I thought about it again, this thing is not suitable for appearing in the
official version,If the set method is added, basically no one else will use it
in official plugin
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
EvanLjp commented on issue #4991:
URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651611657
I know your feeling,thanks for your helping
This is an automated message from the Apache Git Service.
To respond
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
kylixs commented on a change in pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#discussion_r447492784
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java
##
@@
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git
The following commit(s) were added to refs/heads/master by this push:
new bea847b Provide v2 of
bonnieguo commented on issue #4994:
URL: https://github.com/apache/skywalking/issues/4994#issuecomment-651700268
so you mean the percent not support for the endpoint level ?
This is an automated message from the Apache Git
codecov[bot] edited a comment on pull request #4995:
URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4995:
URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4995:
URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4995:
URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4995:
URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #4994:
URL: https://github.com/apache/skywalking/issues/4994#issuecomment-651672167
First of all, no matter there is or not. Your percent func usage is not
correct. This is the right one.
> service_sla = from(Service.*).percent(status == true);
Then
IanCao opened a new issue #4996:
URL: https://github.com/apache/skywalking/issues/4996
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [ ] Feature or performance
codecov[bot] edited a comment on pull request #4995:
URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1)
Report
> Merging
bonnieguo commented on issue #4994:
URL: https://github.com/apache/skywalking/issues/4994#issuecomment-651725186
i just get it from the example:
// Caculate the percent of response status is true, for each service.
Endpoint_success = from(Endpoint.*).filter(status = "true").percent()
EvanLjp closed issue #4991:
URL: https://github.com/apache/skywalking/issues/4991
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wu-sheng opened a new issue #4993:
URL: https://github.com/apache/skywalking/issues/4993
We should add this, python agent uses different instrumentation APIs and the
tracing context APIs.
This is an automated message from
wu-sheng opened a new pull request #4995:
URL: https://github.com/apache/skywalking/pull/4995
1. Fix endpoint dependency bug in MQ and uninstrumented proxy cases. The new
`MultiScopesAnalysisListenerTest` is really helpful on locating this complex
analysis issue.
1. Support endpoint
codecov[bot] edited a comment on pull request #4995:
URL: https://github.com/apache/skywalking/pull/4995#issuecomment-651698077
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4995?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
wu-sheng closed issue #4994:
URL: https://github.com/apache/skywalking/issues/4994
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wu-sheng commented on issue #4994:
URL: https://github.com/apache/skywalking/issues/4994#issuecomment-651725634
Real case is in core.oal
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-python.git
The following commit(s) were added to refs/heads/master by this push:
new bdcf618 Add docs on how to
kezhenxu94 merged pull request #27:
URL: https://github.com/apache/skywalking-python/pull/27
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
wu-sheng commented on a change in pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#discussion_r447485936
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java
##
wu-sheng commented on a change in pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#discussion_r447486623
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java
##
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
wu-sheng commented on a change in pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#discussion_r447485936
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java
##
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch endpoint-dependencies
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 224a5292540ebb61f88f0158d1e201ffb1eeb74f
Author: Wu Sheng
AuthorDate: Tue Jun 30 18:00:11 2020
1 - 100 of 423 matches
Mail list logo
