[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] lujiajing1126 commented on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
lujiajing1126 commented on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-680716384 @kezhenxu94 I have tested with `logstash` collector. Plain text will not break the log processing. Only complains will be reported if invalid json has been

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] DerekHQ opened a new issue #5387: SkyWalking 8.1.0, Mysql8.0, Table doesn't exist; Not to create table auto!

2020-08-26 Thread GitBox
DerekHQ opened a new issue #5387: URL: https://github.com/apache/skywalking/issues/5387 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ * ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5387: SkyWalking 8.1.0, Mysql8.0, Table doesn't exist; Not to create table auto!

2020-08-26 Thread GitBox
wu-sheng commented on issue #5387: URL: https://github.com/apache/skywalking/issues/5387#issuecomment-680720438 We tested it in the e2e, https://github.com/apache/skywalking/blob/master/.github/workflows/e2e.storages.yaml#L39.

[GitHub] [skywalking] wu-sheng closed issue #5387: SkyWalking 8.1.0, Mysql8.0, Table doesn't exist; Not to create table auto!

2020-08-26 Thread GitBox
wu-sheng closed issue #5387: URL: https://github.com/apache/skywalking/issues/5387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5387: SkyWalking 8.1.0, Mysql8.0, Table doesn't exist; Not to create table auto!

2020-08-26 Thread GitBox
wu-sheng commented on issue #5387: URL: https://github.com/apache/skywalking/issues/5387#issuecomment-680721443 - https://github.com/apache/skywalking/blob/master/test/e2e/e2e-test/docker/profile/docker-compose.mysql.yml -

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] DerekHQ commented on issue #5387: SkyWalking 8.1.0, Mysql8.0, Table doesn't exist; Not to create table auto!

2020-08-26 Thread GitBox
DerekHQ commented on issue #5387: URL: https://github.com/apache/skywalking/issues/5387#issuecomment-680728129 Datasource Create is OK! 2020-08-26 15:53:24,945 - com.zaxxer.hikari.HikariDataSource - 80 [main] INFO [] - HikariPool-1 - Starting... 2020-08-26 15:53:26,019 -

[GitHub] [skywalking] wu-sheng commented on issue #5387: SkyWalking 8.1.0, Mysql8.0, Table doesn't exist; Not to create table auto!

2020-08-26 Thread GitBox
wu-sheng commented on issue #5387: URL: https://github.com/apache/skywalking/issues/5387#issuecomment-680728949 We are impossible to test on your env. I just posted all test processes. Please take a look. There could be many factors and configurations to affect the result.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] mach8686devops commented on issue #4581: i use es7 When start collector server,There an error : "storage module no provider exists"

2020-08-26 Thread GitBox
mach8686devops commented on issue #4581: URL: https://github.com/apache/skywalking/issues/4581#issuecomment-680697468 > **Binary Distribution for ElasticSearch 7** instead of **Binary Distribution** from the [official download page](http://skywalking.apache.org/downloads/) what is

[GitHub] [skywalking] czs1993 opened a new issue #5384: Is there any plan to implement elasticsearch7 as backend storage ,When use zipkin receiver plugin?

2020-08-26 Thread GitBox
czs1993 opened a new issue #5384: URL: https://github.com/apache/skywalking/issues/5384 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [x] Requirement - [ ] Feature or performance

[GitHub] [skywalking] huizluo opened a new issue #5385: use skywalking reciver zipkin span

2020-08-26 Thread GitBox
huizluo opened a new issue #5385: URL: https://github.com/apache/skywalking/issues/5385 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] zifeihan opened a new pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
zifeihan opened a new pull request #5386: URL: https://github.com/apache/skywalking/pull/5386 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [skywalking] kezhenxu94 commented on issue #5384: Is there any plan to implement elasticsearch7 as backend storage ,When use zipkin receiver plugin?

2020-08-26 Thread GitBox
kezhenxu94 commented on issue #5384: URL: https://github.com/apache/skywalking/issues/5384#issuecomment-680704013 As far as I know, none of us (the committers) has plan to implement this, but we welcome users who are in need of this to implement and contribute to the project, according to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] commented on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging [#5386](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=desc) into

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on issue #5385: use skywalking reciver zipkin span

2020-08-26 Thread GitBox
kezhenxu94 commented on issue #5385: URL: https://github.com/apache/skywalking/issues/5385#issuecomment-680707198 > we deploy skywalking in k8s, I sent it to Skywalking by using the Zipkin trace of IStio, I configure storageType as zipkin-elasticsearch.An error occurred in init job. this

[GitHub] [skywalking] kezhenxu94 closed issue #5385: use skywalking reciver zipkin span

2020-08-26 Thread GitBox
kezhenxu94 closed issue #5385: URL: https://github.com/apache/skywalking/issues/5385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5384: Is there any plan to implement elasticsearch7 as backend storage ,When use zipkin receiver plugin?

2020-08-26 Thread GitBox
wu-sheng commented on issue #5384: URL: https://github.com/apache/skywalking/issues/5384#issuecomment-680710066 Zipkin receiver is experimental, also a POC. Searching the issue, we had a lot of discussion about why this is hard to be production-ready.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng closed issue #5384: Is there any plan to implement elasticsearch7 as backend storage ,When use zipkin receiver plugin?

2020-08-26 Thread GitBox
wu-sheng closed issue #5384: URL: https://github.com/apache/skywalking/issues/5384 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
kezhenxu94 commented on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-680679958 > What about postponing log output in this class or globally with a so-called DelayedLogger? For example, push the logs into a queue. That makes things too

[GitHub] [skywalking] kezhenxu94 edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
kezhenxu94 edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-680679958 > What about postponing log output in this class or globally with a so-called DelayedLogger? For example, push the logs into a queue. That makes things too

[GitHub] [skywalking] kezhenxu94 edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
kezhenxu94 edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-680679958 > What about postponing log output in this class or globally with a so-called DelayedLogger? For example, push the logs into a queue. That makes things too

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] commented on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging [#5389](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=desc) into

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] arugal opened a new pull request #5390: Support in filter expressions in OAL

2020-08-26 Thread GitBox
arugal opened a new pull request #5390: URL: https://github.com/apache/skywalking/pull/5390 Support `in` expression and fix some question. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

  1   2   3   4   5   6   >