[GitHub] [skywalking] JaredTan95 opened a new pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
JaredTan95 opened a new pull request #5844: URL: https://github.com/apache/skywalking/pull/5844 ### Fix https://github.com/apache/skywalking/pull/5754, https://github.com/apache/skywalking/issues/5749 - [ ] Add a unit test to verify that the fix works.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[skywalking] 01/03: Merge remote-tracking branch 'origin/master' into dev-fix-tdb

2020-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch tidb_provider in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 546416efe61312e89445808012e6cf45567c00db Merge: 8b13719 4a01f80 Author: JaredTan95 AuthorDate: Tue Nov 10

[skywalking] 02/03: Merge branch 'master' into dev-fix-tdb

2020-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch tidb_provider in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 6f832a0197bace1f968187b996d1e963e302f905 Merge: 546416e edf0bce Author: JaredTan95 AuthorDate: Sat Nov 14

[skywalking] branch tidb_provider created (now 7187c7e)

2020-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch tidb_provider in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 7187c7e add tidb storage provider module. This branch includes the following new commits: new

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #370: Add logo for SQLServer.

2020-11-14 Thread GitBox
wu-sheng commented on pull request #370: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/370#issuecomment-727218368 Where do you get this logo? SQLServer should be a commercial license. We should be very careful about adding its logo.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5839: Fix request url traceId sometimes shows "Ignored_Trace"

2020-11-14 Thread GitBox
wu-sheng commented on a change in pull request #5839: URL: https://github.com/apache/skywalking/pull/5839#discussion_r523424525 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManagerExtendService.java ## @@ -27,8

[skywalking] 03/03: add tidb storage provider module.

2020-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch tidb_provider in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 7187c7e54451547f24f82c4a555fb7b9db48765c Author: JaredTan95 AuthorDate: Sat Nov 14 20:37:25 2020 +0800

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] commented on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[skywalking] 01/01: add e2e.

2020-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch dev-fix-tdb in repository https://gitbox.apache.org/repos/asf/skywalking.git commit c887749781e71370ab85af952500b301b8719622 Author: JaredTan95 AuthorDate: Sun Nov 15 10:32:47 2020 +0800

[skywalking] branch dev-fix-tdb created (now c887749)

2020-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch dev-fix-tdb in repository https://gitbox.apache.org/repos/asf/skywalking.git. at c887749 add e2e. This branch includes the following new commits: new c887749 add e2e. The 1

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[skywalking] branch tidb_provider updated (8171ee1 -> 0926e4c)

2020-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch tidb_provider in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 8171ee1 revert ui submodule. add 0926e4c fix license. No new revisions were added by this

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
wu-sheng commented on a change in pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#discussion_r523679698 ## File path:

[GitHub] [skywalking] wu-sheng commented on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
wu-sheng commented on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727342871 The key to GPL/LGPL dependency restriction is, we can't ask the user has to use this lib. But in the plugin system, we don't depend on the lib, the user did before use, we

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
wu-sheng commented on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727341287 > https://github.com/milesibastos/jTDS checked this lib, it's under license LGPL 2.1, which is not allowed to be included in this repository @kezhenxu94 LGPL

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
wu-sheng commented on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727343713 Also, at the same time, I assume the logo is not allowed(rocketbot-ui), it is not just GPL/LGPL, it is totally commercial.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] xbkaishui commented on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
xbkaishui commented on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727408747 Due to tidb not do well on batch delete, is it better we use partition table? tiflash is suitable for olap related task. do we need integrate it in e2e test case?

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5845: URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5845: URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5845: URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5845: URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5845: URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5845: URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
kezhenxu94 commented on a change in pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#discussion_r523690770 ## File path: .github/workflows/plugins-test.0.yaml ## @@ -70,6 +70,7 @@ jobs: - gson-scenario - elasticjob-3.x-scenario

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5846: fix flaky test in comsumerTest

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5846: URL: https://github.com/apache/skywalking/pull/5846#issuecomment-727482903 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5846?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5846: fix flaky test in comsumerTest

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5846: URL: https://github.com/apache/skywalking/pull/5846#issuecomment-727482903 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5846?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5846: fix flaky test in comsumerTest

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5846: URL: https://github.com/apache/skywalking/pull/5846#issuecomment-727482903 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5846?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5846: fix flaky test in comsumerTest

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5846: URL: https://github.com/apache/skywalking/pull/5846#issuecomment-727482903 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5846?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[skywalking] branch tidb_provider updated (8171ee1 -> 0926e4c)

2020-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch tidb_provider in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 8171ee1 revert ui submodule. add 0926e4c fix license. No new revisions were added by this

[GitHub] [skywalking] kezhenxu94 commented on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
kezhenxu94 commented on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727352068 > > https://github.com/milesibastos/jTDS checked this lib, it's under license LGPL 2.1, which is not allowed to be included in this repository > > @kezhenxu94 LGPL

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
JaredTan95 commented on a change in pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#discussion_r523703723 ## File path:

[GitHub] [skywalking] codecov[bot] commented on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

2020-11-14 Thread GitBox
codecov[bot] commented on pull request #5845: URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr=h1) Report > Merging [#5845](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5845: URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5846: fix flaky test in comsumerTest

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5846: URL: https://github.com/apache/skywalking/pull/5846#issuecomment-727482903 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5846?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5845: URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5846: fix flaky test in comsumerTest

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5846: URL: https://github.com/apache/skywalking/pull/5846#issuecomment-727482903 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5846?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5846: fix flaky test in comsumerTest

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5846: URL: https://github.com/apache/skywalking/pull/5846#issuecomment-727482903 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5846?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5846: fix flaky test in comsumerTest

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5846: URL: https://github.com/apache/skywalking/pull/5846#issuecomment-727482903 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5846: fix flaky test in comsumerTest

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5846: URL: https://github.com/apache/skywalking/pull/5846#issuecomment-727482903 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5842: Add the plugin for mssql-jtds 1.x plugin.

2020-11-14 Thread GitBox
codecov[bot] edited a comment on pull request #5842: URL: https://github.com/apache/skywalking/pull/5842#issuecomment-727150584 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5842?src=pr=h1) Report > Merging

  1   2   3   >