[GitHub] [skywalking-python] kezhenxu94 merged pull request #83: Refactor: moved exception check to Span.__exit__

2020-11-19 Thread GitBox
kezhenxu94 merged pull request #83: URL: https://github.com/apache/skywalking-python/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-python] tom-pytel commented on pull request #83: Refactor: moved exception check to Span.__exit__

2020-11-19 Thread GitBox
tom-pytel commented on pull request #83: URL: https://github.com/apache/skywalking-python/pull/83#issuecomment-730515535 > @tom-pytel could you please kindly refactor the counterpart in `context.new_entry_span` as well? Now you just refactored the `context.new_exit_span`, really

[GitHub] [skywalking-python] tom-pytel commented on pull request #84: [Plugin] moved Method & Url tags before requests

2020-11-19 Thread GitBox
tom-pytel commented on pull request #84: URL: https://github.com/apache/skywalking-python/pull/84#issuecomment-730578719 I expect these changes to change some test results, adding HttpMethod and HttpUrl tags in places where they may not have been before and changing some endpoint names

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #83: Refactor: moved exception check to Span.__exit__

2020-11-19 Thread GitBox
kezhenxu94 commented on pull request #83: URL: https://github.com/apache/skywalking-python/pull/83#issuecomment-730517403 > The exception checking is in class `Span` which is base for `EntrySpan`, `ExitSpan` and `NoopSpan` so it should work for all. I meant removing the `try-catch`

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #83: Refactor: moved exception check to Span.__exit__

2020-11-19 Thread GitBox
kezhenxu94 commented on a change in pull request #83: URL: https://github.com/apache/skywalking-python/pull/83#discussion_r527047958 ## File path: skywalking/trace/span.py ## @@ -117,6 +117,8 @@ def __enter__(self): return self def __exit__(self, exc_type,

[GitHub] [skywalking-python] tom-pytel commented on a change in pull request #83: Refactor: moved exception check to Span.__exit__

2020-11-19 Thread GitBox
tom-pytel commented on a change in pull request #83: URL: https://github.com/apache/skywalking-python/pull/83#discussion_r527049684 ## File path: skywalking/trace/span.py ## @@ -117,6 +117,8 @@ def __enter__(self): return self def __exit__(self, exc_type,

[skywalking-python] branch master updated: Refactor: moved exception check to Span.__exit__ (#83)

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/master by this push: new b101320 Refactor: moved

[GitHub] [skywalking] rohan2546 commented on issue #5865: [Python] Not getting db data while using pymysql or pymongo inside flask server

2020-11-19 Thread GitBox
rohan2546 commented on issue #5865: URL: https://github.com/apache/skywalking/issues/5865#issuecomment-730487521 The same code is not showing database in my local This is an automated message from the Apache Git Service. To

[GitHub] [skywalking-python] tom-pytel opened a new pull request #84: [Plugin] moved Method & Url tags before requests

2020-11-19 Thread GitBox
tom-pytel opened a new pull request #84: URL: https://github.com/apache/skywalking-python/pull/84 * Moved set of HttpMethod and HttpUrl tags to before requests to make sure they are recorded even if request fails. * Specifically catching HTTPError in `sw_urllib_request.py` to properly

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #83: Refactor: moved exception check to Span.__exit__

2020-11-19 Thread GitBox
kezhenxu94 commented on a change in pull request #83: URL: https://github.com/apache/skywalking-python/pull/83#discussion_r527050221 ## File path: skywalking/trace/span.py ## @@ -117,6 +117,8 @@ def __enter__(self): return self def __exit__(self, exc_type,

[GitHub] [skywalking-python] tom-pytel commented on pull request #83: Refactor: moved exception check to Span.__exit__

2020-11-19 Thread GitBox
tom-pytel commented on pull request #83: URL: https://github.com/apache/skywalking-python/pull/83#issuecomment-730519871 > Thanks No problem  This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking-python] tom-pytel commented on pull request #84: [Plugin] moved Method & Url tags before requests

2020-11-19 Thread GitBox
tom-pytel commented on pull request #84: URL: https://github.com/apache/skywalking-python/pull/84#issuecomment-730752688 > > any way to see if these test failures are that or something else? > > Here it is

[GitHub] [skywalking] vcjmhg commented on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
vcjmhg commented on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730810324 > Though again, my only question would be whether or not the stack trace was always included regardless of log level. @BFergerson , I am not sure if there will be the

[GitHub] [skywalking] vcjmhg edited a comment on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
vcjmhg edited a comment on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730807806 > Yes, my understanding is `pattern` is the `message` in the log. The `expression` still doesn't make sense to me. How do we plan to do that? @wu-sheng , the

[GitHub] [skywalking-cli] hanahmily commented on pull request #73: Add list metrics command

2020-11-19 Thread GitBox
hanahmily commented on pull request #73: URL: https://github.com/apache/skywalking-cli/pull/73#issuecomment-730670837 > Can you please update the doc as well? done. This is an automated message from the Apache Git

[skywalking-cli] branch master updated: Add list metrics command (#73)

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new aaf8a55 Add list metrics command

[GitHub] [skywalking-cli] kezhenxu94 merged pull request #73: Add list metrics command

2020-11-19 Thread GitBox
kezhenxu94 merged pull request #73: URL: https://github.com/apache/skywalking-cli/pull/73 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] kezhenxu94 commented on issue #5865: [Python] Not getting db data while using pymysql or pymongo inside flask server

2020-11-19 Thread GitBox
kezhenxu94 commented on issue #5865: URL: https://github.com/apache/skywalking/issues/5865#issuecomment-730809810 Also, I noticed that your SQL is ```sql SELECT `*` FROM `doctors` ``` FWIK, `*` doesn't need the backticks if you want to query all fields ```diff

[GitHub] [skywalking] rohan2546 commented on issue #5865: [Python] Not getting db data while using pymysql or pymongo inside flask server

2020-11-19 Thread GitBox
rohan2546 commented on issue #5865: URL: https://github.com/apache/skywalking/issues/5865#issuecomment-730818887 skywalking.agent.protocol.grpc [Thread-2 ] [DEBUG ] grpc channel connectivity changed, [None -> ChannelConnectivity.IDLE] skywalking.agent.protocol.grpc [Thread-3

[GitHub] [skywalking] JiGW24 commented on issue #5163: skywalking upgrade 7 to 8

2020-11-19 Thread GitBox
JiGW24 commented on issue #5163: URL: https://github.com/apache/skywalking/issues/5163#issuecomment-730821597 I have upgrade problem like this. For SK8, what suitable ES version can I use? or give some other advice. > agent version 7.0 > oap 8.1.0 ui 8.1.0 > es 7.9.1 >

[GitHub] [skywalking] kezhenxu94 commented on issue #5865: [Python] Not getting db data while using pymysql or pymongo inside flask server

2020-11-19 Thread GitBox
kezhenxu94 commented on issue #5865: URL: https://github.com/apache/skywalking/issues/5865#issuecomment-730821470 > I don't know why plugin sw_pymysql not getting installed From the logs, seems you only have very limited plugins installed. Which version are you using? How did you

[GitHub] [skywalking-data-collect-protocol] Shikugawa opened a new pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
Shikugawa opened a new pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33 To fix https://github.com/SkyAPM/cpp2sky/issues/6. Introduced to generate C++ gRPC definition for skywalking C++ SDK.

[GitHub] [skywalking] taoyuyu opened a new issue #5867: java start agent with exception

2020-11-19 Thread GitBox
taoyuyu opened a new issue #5867: URL: https://github.com/apache/skywalking/issues/5867 ### Question ```java ERROR 2020-11-19 20:27:08:133 main SkyWalkingAgent : Enhance class org.apache.http.impl.client.AbstractHttpClient error.

[GitHub] [skywalking] taoyuyu commented on issue #5867: java start agent with exception

2020-11-19 Thread GitBox
taoyuyu commented on issue #5867: URL: https://github.com/apache/skywalking/issues/5867#issuecomment-730792322 jre versoin ```shell java version "1.8.0_45" Java(TM) SE Runtime Environment (build 1.8.0_45-b14) Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode) ```

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #84: [Plugin] moved Method & Url tags before requests

2020-11-19 Thread GitBox
kezhenxu94 commented on a change in pull request #84: URL: https://github.com/apache/skywalking-python/pull/84#discussion_r527348094 ## File path: skywalking/plugins/sw_urllib_request.py ## @@ -38,15 +39,22 @@ def _sw_open(this: OpenerDirector, fullurl, data, timeout):

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #84: [Plugin] moved Method & Url tags before requests

2020-11-19 Thread GitBox
kezhenxu94 commented on a change in pull request #84: URL: https://github.com/apache/skywalking-python/pull/84#discussion_r527348094 ## File path: skywalking/plugins/sw_urllib_request.py ## @@ -38,15 +39,22 @@ def _sw_open(this: OpenerDirector, fullurl, data, timeout):

[GitHub] [skywalking] kezhenxu94 commented on issue #5865: [Python] Not getting db data while using pymysql or pymongo inside flask server

2020-11-19 Thread GitBox
kezhenxu94 commented on issue #5865: URL: https://github.com/apache/skywalking/issues/5865#issuecomment-730808945 > The same code is not showing database in my local The codes @alonelaval pasted work for me, please provide more context/information if it doesn't work at your side,

[GitHub] [skywalking] kezhenxu94 closed issue #5865: [Python] Not getting db data while using pymysql or pymongo inside flask server

2020-11-19 Thread GitBox
kezhenxu94 closed issue #5865: URL: https://github.com/apache/skywalking/issues/5865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking] rohan2546 edited a comment on issue #5865: [Python] Not getting db data while using pymysql or pymongo inside flask server

2020-11-19 Thread GitBox
rohan2546 edited a comment on issue #5865: URL: https://github.com/apache/skywalking/issues/5865#issuecomment-730818887 skywalking.agent.protocol.grpc [Thread-2 ] [DEBUG ] grpc channel connectivity changed, [None -> ChannelConnectivity.IDLE] skywalking.agent.protocol.grpc

[GitHub] [skywalking] JiGW24 commented on issue #5163: skywalking upgrade 7 to 8

2020-11-19 Thread GitBox
JiGW24 commented on issue #5163: URL: https://github.com/apache/skywalking/issues/5163#issuecomment-730821710 > agent version 7.0 > oap 8.1.0 ui 8.1.0 > es 7.9.1 > 也遇到了上述问题,请问可以解决吗?或者说能够提供一个相对比较新的配套的版本,我部署下 I have upgrade problem like this. For SK8, what suitable ES version

[GitHub] [skywalking] JiGW24 removed a comment on issue #5163: skywalking upgrade 7 to 8

2020-11-19 Thread GitBox
JiGW24 removed a comment on issue #5163: URL: https://github.com/apache/skywalking/issues/5163#issuecomment-730821597 I have upgrade problem like this. For SK8, what suitable ES version can I use? or give some other advice. > agent version 7.0 > oap 8.1.0 ui 8.1.0 > es 7.9.1

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #84: [Plugin] moved Method & Url tags before requests

2020-11-19 Thread GitBox
kezhenxu94 commented on pull request #84: URL: https://github.com/apache/skywalking-python/pull/84#issuecomment-730742813 > any way to see if these test failures are that or something else? Here it is https://github.com/apache/skywalking-python/pull/84/checks?check_run_id=1426036106

[GitHub] [skywalking] wu-sheng closed issue #5867: java start agent with exception

2020-11-19 Thread GitBox
wu-sheng closed issue #5867: URL: https://github.com/apache/skywalking/issues/5867 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5867: java start agent with exception

2020-11-19 Thread GitBox
wu-sheng commented on issue #5867: URL: https://github.com/apache/skywalking/issues/5867#issuecomment-730796204 Please don't submit duplicated issue. This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wu-sheng commented on issue #5861: start java agent with exception

2020-11-19 Thread GitBox
wu-sheng commented on issue #5861: URL: https://github.com/apache/skywalking/issues/5861#issuecomment-730797856 #5734 would break the booting. The error still makes me feel, you are using ext class loader. Please recheck your classloader.

[GitHub] [skywalking-python] kezhenxu94 edited a comment on pull request #84: [Plugin] moved Method & Url tags before requests

2020-11-19 Thread GitBox
kezhenxu94 edited a comment on pull request #84: URL: https://github.com/apache/skywalking-python/pull/84#issuecomment-730742813 > any way to see if these test failures are that or something else? Here it is

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #5865: [Python] Not getting db data while using pymysql or pymongo inside flask server

2020-11-19 Thread GitBox
kezhenxu94 edited a comment on issue #5865: URL: https://github.com/apache/skywalking/issues/5865#issuecomment-730808945 > The same code is not showing database in my local @rohan2546 The codes @alonelaval pasted work for me, please provide more context/information if it doesn't

[GitHub] [skywalking] BFergerson commented on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
BFergerson commented on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730837374 @vcjmhg, fair enough. My reason for asking was mainly due to my interest in being able to correlate which line the log came from. It would be helpful for a project I'm working

[GitHub] [skywalking] JiGW24 commented on issue #5482: skywalking upgrade from 6.5 to 8.1.0

2020-11-19 Thread GitBox
JiGW24 commented on issue #5482: URL: https://github.com/apache/skywalking/issues/5482#issuecomment-730837164 > > thank you ,Let me try > > This "Can 't split the instance id into 2 parts" error solved How you slove this problem? I tried to solve like this but ineffective.

[GitHub] [skywalking] taoyuyu edited a comment on issue #5867: java start agent with exception

2020-11-19 Thread GitBox
taoyuyu edited a comment on issue #5867: URL: https://github.com/apache/skywalking/issues/5867#issuecomment-730792322 jre versoin ```shell java version "1.8.0_45" Java(TM) SE Runtime Environment (build 1.8.0_45-b14) Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)

[GitHub] [skywalking] rohan2546 edited a comment on issue #5865: [Python] Not getting db data while using pymysql or pymongo inside flask server

2020-11-19 Thread GitBox
rohan2546 edited a comment on issue #5865: URL: https://github.com/apache/skywalking/issues/5865#issuecomment-730818887 skywalking.agent.protocol.grpc [Thread-2 ] [DEBUG ] grpc channel connectivity changed, [None -> ChannelConnectivity.IDLE] skywalking.agent.protocol.grpc

[GitHub] [skywalking-cli] hanahmily commented on pull request #73: Add list metrics command

2020-11-19 Thread GitBox
hanahmily commented on pull request #73: URL: https://github.com/apache/skywalking-cli/pull/73#issuecomment-730682512 > Just curious, the HAP adaptor will use CLI internally? Here is the HPA external metrics we could opt to ``` metric: name: queue_messages_ready

[GitHub] [skywalking] vcjmhg commented on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
vcjmhg commented on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730807806 > Yes, my understanding is `pattern` is the `message` in the log. The `expression` still doesn't make sense to me. How do we plan to do that? The `expression` is mainly to

[GitHub] [skywalking] vcjmhg edited a comment on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
vcjmhg edited a comment on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730807806 > Yes, my understanding is `pattern` is the `message` in the log. The `expression` still doesn't make sense to me. How do we plan to do that? The `expression` is

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
wu-sheng commented on pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730899267 @kezhenxu94 Could we use a shell tool to set up CI for this repo too? This is an

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
wu-sheng commented on pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730898192 You need to add Apache 2.0 header to all new files, otherwise, the mainrepo(includes many other agent repos) will compile failed because the header check

[GitHub] [skywalking] vcjmhg commented on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
vcjmhg commented on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730940001 > OK, I got your time. But, regex match would be a big performance impact on the target system. The log should follow the same logic as the log filter system originally, such as,

[skywalking-data-collect-protocol] branch chore updated (dc68d33 -> d08c191)

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git. discard dc68d33 Create check-license-header discard d64597d Update .asf.yaml new

[skywalking-data-collect-protocol] 01/01: Add license header checker

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch chore in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git commit d08c19116a70ffb4e5f517f2ac40a6d02d1c9330 Author: Zhenxu Ke AuthorDate: Fri Nov 20

[skywalking-data-collect-protocol] branch master updated: Add license header checker (#34)

2020-11-19 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git The following commit(s) were added to refs/heads/master by this push: new ab1c418 Add

[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request #34: Add license header checker

2020-11-19 Thread GitBox
wu-sheng merged pull request #34: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking-data-collect-protocol] kezhenxu94 opened a new pull request #34: Add license header checker

2020-11-19 Thread GitBox
kezhenxu94 opened a new pull request #34: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[skywalking-data-collect-protocol] branch master updated: build: Add bazel support to generate C++ gRPC definition (#33)

2020-11-19 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git The following commit(s) were added to refs/heads/master by this push: new 754995b build: Add

[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
wu-sheng merged pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
wu-sheng commented on pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730963745 @Shikugawa Please there is a way, please add a CI to compiling this as C++ codes, as a check that we wouldn't break it accidentally.(Expect this could do

[skywalking-data-collect-protocol] branch chore created (now d64597d)

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git. at d64597d Update .asf.yaml This branch includes the following new commits: new

[skywalking-data-collect-protocol] 01/01: Update .asf.yaml

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch chore in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git commit d64597df5a249f3af64199ad089ed657c51a4005 Author: Zhenxu Ke AuthorDate: Fri Nov 20

[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
kezhenxu94 commented on pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730953239 It's weird that the PR don't need to "Update branch", the CI checks are latest after reopening. Anyway, it works now

[GitHub] [skywalking] wu-sheng commented on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
wu-sheng commented on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730910424 > the expression is mainly to increase the flexibility of the function. In a certain situation, we may need to only record log information containing certain keywords.For

[GitHub] [skywalking-data-collect-protocol] kezhenxu94 closed pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
kezhenxu94 closed pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
kezhenxu94 commented on pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730911884 > @kezhenxu94 Could we use a shell tool to set up CI for this repo too? Sure, we can get this

[GitHub] [skywalking] JianghuiGuo opened a new issue #5868: agent plugin: add logback plugin

2020-11-19 Thread GitBox
JianghuiGuo opened a new issue #5868: URL: https://github.com/apache/skywalking/issues/5868 add a logback plugin to collect the logs in the trace. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng closed issue #5868: agent plugin: add logback plugin

2020-11-19 Thread GitBox
wu-sheng closed issue #5868: URL: https://github.com/apache/skywalking/issues/5868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5868: agent plugin: add logback plugin

2020-11-19 Thread GitBox
wu-sheng commented on issue #5868: URL: https://github.com/apache/skywalking/issues/5868#issuecomment-730962911 Please follow #4545 and #5863 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
wu-sheng commented on pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730915132 Great, let's add this .py file and set up CI first, also include the `.asf.yml` file set up(reviewer and ci passed). Then, once your great idea lands, we

[GitHub] [skywalking-data-collect-protocol] Shikugawa commented on pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
Shikugawa commented on pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730959233 @kezhenxu94 seems header checker works fine. Thanks. This is an automated message from

[skywalking-data-collect-protocol] branch chore updated: Create check-license-header

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch chore in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git The following commit(s) were added to refs/heads/chore by this push: new dc68d33 Create

[GitHub] [skywalking] vcjmhg commented on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
vcjmhg commented on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730932116 @BFergerson , ok,`logback` supports the function that collects the line number from where the logging request was issued (the conversion word is

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
wu-sheng commented on pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730950071 @kezhenxu94 Look like no branch update? This is an automated message from the Apache Git

[GitHub] [skywalking-data-collect-protocol] wu-sheng edited a comment on pull request #33: build: Add bazel support to generate C++ gRPC definition

2020-11-19 Thread GitBox
wu-sheng edited a comment on pull request #33: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/33#issuecomment-730963745 @Shikugawa If there is a way, please add a CI to compiling this as C++ codes, as a check that we wouldn't break it accidentally.(Expect this could

[GitHub] [skywalking] 1314cc commented on issue #5862: Cross-room monitoring service

2020-11-19 Thread GitBox
1314cc commented on issue #5862: URL: https://github.com/apache/skywalking/issues/5862#issuecomment-730212257 There are not enough machines in the client room, and there is not enough budget. Therefore, it is put in a unified center to collect and monitor service

[GitHub] [skywalking] wu-sheng commented on issue #5862: Cross-room monitoring service

2020-11-19 Thread GitBox
wu-sheng commented on issue #5862: URL: https://github.com/apache/skywalking/issues/5862#issuecomment-730226093 Then you have to provide enough network. I don't know your system load/traffic. This is an automated message

[GitHub] [skywalking] MrSiLu commented on issue #5864: Is there a plan to support DM7 or DM8

2020-11-19 Thread GitBox
MrSiLu commented on issue #5864: URL: https://github.com/apache/skywalking/issues/5864#issuecomment-730250898 Sorry , I didn't make it clear . DM is a database , like oracle . But DM was designed by the Chinese . so some projects need use DM. I want one Java agent plugin

[skywalking-python] annotated tag v0.4.0 updated (5dbb9db -> e9b4d1d)

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to annotated tag v0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. *** WARNING: tag v0.4.0 was modified! *** from 5dbb9db (commit) to e9b4d1d (tag) tagging

[GitHub] [skywalking] wu-sheng closed issue #5862: Cross-room monitoring service

2020-11-19 Thread GitBox
wu-sheng closed issue #5862: URL: https://github.com/apache/skywalking/issues/5862 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5862: Cross-room monitoring service

2020-11-19 Thread GitBox
wu-sheng commented on issue #5862: URL: https://github.com/apache/skywalking/issues/5862#issuecomment-730199753 If the internet is good enough for you, it is fine. Basically, the question is, whether do you want to collect all data to one SkyWalking cluster.

[GitHub] [skywalking] wu-sheng commented on issue #5864: Is there a plan to support DM7 or DM8

2020-11-19 Thread GitBox
wu-sheng commented on issue #5864: URL: https://github.com/apache/skywalking/issues/5864#issuecomment-730235196 What is the DM? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] MrSiLu opened a new issue #5864: Is there a plan to support DM7 or DM8

2020-11-19 Thread GitBox
MrSiLu opened a new issue #5864: URL: https://github.com/apache/skywalking/issues/5864 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [x] Feature or performance

[GitHub] [skywalking] wu-sheng commented on issue #5864: Is there a plan to support DM7 or DM8

2020-11-19 Thread GitBox
wu-sheng commented on issue #5864: URL: https://github.com/apache/skywalking/issues/5864#issuecomment-730241552 Could you provide more information? You are giving very few word about your context. This is an automated

[GitHub] [skywalking] wu-sheng closed issue #5864: Is there a plan to support DM7 or DM8

2020-11-19 Thread GitBox
wu-sheng closed issue #5864: URL: https://github.com/apache/skywalking/issues/5864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] MrSiLu commented on issue #5864: Is there a plan to support DM7 or DM8

2020-11-19 Thread GitBox
MrSiLu commented on issue #5864: URL: https://github.com/apache/skywalking/issues/5864#issuecomment-73023 A database This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking-python] annotated tag 0.4.0 updated (5dbb9db -> 76bfa07)

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to annotated tag 0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. *** WARNING: tag 0.4.0 was modified! *** from 5dbb9db (commit) to 76bfa07 (tag) tagging

[skywalking-python] annotated tag v0.4.0 updated (5dbb9db -> 5696bcc)

2020-11-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to annotated tag v0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. *** WARNING: tag v0.4.0 was modified! *** from 5dbb9db (commit) to 5696bcc (tag) tagging

[GitHub] [skywalking] MrSiLu commented on issue #5864: Is there a plan to support DM7 or DM8

2020-11-19 Thread GitBox
MrSiLu commented on issue #5864: URL: https://github.com/apache/skywalking/issues/5864#issuecomment-730260905 OK , I will try to build the plugin by myself . Thanks again . This is an automated message from the Apache Git

[GitHub] [skywalking] rohan2546 opened a new issue #5865: [Python]

2020-11-19 Thread GitBox
rohan2546 opened a new issue #5865: URL: https://github.com/apache/skywalking/issues/5865 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] wu-sheng commented on issue #5864: Is there a plan to support DM7 or DM8

2020-11-19 Thread GitBox
wu-sheng commented on issue #5864: URL: https://github.com/apache/skywalking/issues/5864#issuecomment-730257406 As an open source project, we don't have any interest or plan to work on the commercial database. Also, you should understand, all plugins of SkyWalking come from contributors

[GitHub] [skywalking] wu-sheng commented on issue #5865: [Python]

2020-11-19 Thread GitBox
wu-sheng commented on issue #5865: URL: https://github.com/apache/skywalking/issues/5865#issuecomment-730304697 Please update the title This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] BFergerson commented on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
BFergerson commented on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730348829 I can't think of a good reason why the logging framework should matter and I was unaware of the format `AbstractSpan.error()` was already using. I believe that format is just

[skywalking-query-protocol] branch master updated: Add `listMetrics` service

2020-11-19 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git The following commit(s) were added to refs/heads/master by this push: new d3608e8 Add `listMetrics`

[GitHub] [skywalking-python] fgksgf opened a new pull request #82: Add How-to-release doc

2020-11-19 Thread GitBox
fgksgf opened a new pull request #82: URL: https://github.com/apache/skywalking-python/pull/82 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking-python] fgksgf commented on a change in pull request #82: Add How-to-release doc

2020-11-19 Thread GitBox
fgksgf commented on a change in pull request #82: URL: https://github.com/apache/skywalking-python/pull/82#discussion_r526872293 ## File path: docs/How-to-release.md ## @@ -0,0 +1,224 @@ +# Apache SkyWalking Python Release Guide + +This documentation guides the release manager

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5866: Provide `listMetrics` GraphQL query service.

2020-11-19 Thread GitBox
codecov[bot] edited a comment on pull request #5866: URL: https://github.com/apache/skywalking/pull/5866#issuecomment-730369885 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5866?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5866: Provide `listMetrics` GraphQL query service.

2020-11-19 Thread GitBox
codecov[bot] commented on pull request #5866: URL: https://github.com/apache/skywalking/pull/5866#issuecomment-730369885 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5866?src=pr=h1) Report > Merging [#5866](https://codecov.io/gh/apache/skywalking/pull/5866?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5866: Provide `listMetrics` GraphQL query service.

2020-11-19 Thread GitBox
codecov[bot] edited a comment on pull request #5866: URL: https://github.com/apache/skywalking/pull/5866#issuecomment-730369885 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5866?src=pr=h1) Report > Merging

[GitHub] [skywalking] vcjmhg edited a comment on issue #4545: add error log(log4j,logback) to span log event

2020-11-19 Thread GitBox
vcjmhg edited a comment on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-729419758 # Summary The plug-in can store the logs generated by the program during the call, such as the content of the error log, into the span log. And the plug-in provides

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5866: Provide `listMetrics` GraphQL query service.

2020-11-19 Thread GitBox
codecov[bot] edited a comment on pull request #5866: URL: https://github.com/apache/skywalking/pull/5866#issuecomment-730369885 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5866?src=pr=h1) Report > Merging

[GitHub] [skywalking] vcjmhg edited a comment on issue #5863: What format should we have in mind for logging to spans?

2020-11-19 Thread GitBox
vcjmhg edited a comment on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730384448 > I was unaware of the format `AbstractSpan.error()` was already using @BFergerson, The result of the previous discussion is that we don’t care about the format

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5866: Provide `listMetrics` GraphQL query service.

2020-11-19 Thread GitBox
codecov[bot] edited a comment on pull request #5866: URL: https://github.com/apache/skywalking/pull/5866#issuecomment-730369885 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5866?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5866: Provide `listMetrics` GraphQL query service.

2020-11-19 Thread GitBox
codecov[bot] edited a comment on pull request #5866: URL: https://github.com/apache/skywalking/pull/5866#issuecomment-730369885 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5866?src=pr=h1) Report > Merging

[skywalking-python] branch doc/release updated (6929cd5 -> 2ba0f83)

2020-11-19 Thread hoshea
This is an automated email from the ASF dual-hosted git repository. hoshea pushed a change to branch doc/release in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. from 6929cd5 Add release doc add 2ba0f83 Delete vote thread No new revisions were added by this

  1   2   >