[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5914: [WIP]add error log(log4j,logback) to span log event

kezhenxu94 commented on a change in pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#discussion_r532056781 ## File path: apm-sniffer/apm-sdk-plugin/logger-plugin/pom.xml ## @@ -0,0 +1,65 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5915: Make meter receiver support MAL

kezhenxu94 commented on a change in pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#discussion_r532059762 ## File path: oap-server/analyzer/agent-analyzer/pom.xml ## @@ -39,8 +39,9 @@ ${project.version} -

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5915: Make meter receiver support MAL

kezhenxu94 commented on a change in pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#discussion_r532059762 ## File path: oap-server/analyzer/agent-analyzer/pom.xml ## @@ -39,8 +39,9 @@ ${project.version} -

[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #2: Make async stuff work reliably

tom-pytel commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735255536 > > * Context.capture() and restore() will be made redundant / unnecessary by this? > > Yes I believe they're unnecessary after this PR, feel free to remove them

[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #2: Make async stuff work reliably

tom-pytel commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735256060 Ready for merge I think, tests need to be changed since I added tags which weren't previously being returned. I couldn't really come up with a ready-to-use example vs.

[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #2: Make async stuff work reliably

tom-pytel edited a comment on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735256060 Ready for merge I think, tests need to be changed since I added tags which weren't previously being returned. I couldn't really come up with a ready-to-use example

[GitHub] [skywalking-nodejs] tom-pytel commented on a change in pull request #2: Make async stuff work reliably

tom-pytel commented on a change in pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#discussion_r532060352 ## File path: src/trace/context/ContextManager.ts ## @@ -18,19 +18,74 @@ */ import Context from '../../trace/context/Context'; +import Span

[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #2: Make async stuff work reliably

tom-pytel edited a comment on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735256060 Ready for merge I think, tests need to be changed since I added tags which weren't previously being returned. I couldn't really come up with a ready-to-use example

[GitHub] [skywalking] BFergerson commented on pull request #5914: [WIP]add error log(log4j,logback) to span log event

BFergerson commented on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735128018 Added [implementation](https://github.com/vcjmhg/skywalking/pull/8) for most versions of each log system being monitored via this plugin

[GitHub] [skywalking] mrproliu commented on a change in pull request #5915: Make meter receiver support MAL

mrproliu commented on a change in pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#discussion_r532025739 ## File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java ## @@ -233,12 +234,29

[GitHub] [skywalking] mrproliu commented on a change in pull request #5915: Make meter receiver support MAL

mrproliu commented on a change in pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#discussion_r532025649 ## File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java ## @@ -233,12 +234,29

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #5: Add API && Plugin framework registry

EvanLjp commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532034993 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,74 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #5: Add API && Plugin framework registry

wu-sheng commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532002585 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,74 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] zifeihan commented on pull request #5914: [WIP]add error log(log4j,logback) to span log event

zifeihan commented on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735098818 > > Hello, I have a question. If an exception occurs in async thread, means ContextManager.activeSpan() is null, Isn't this error log recorded? > > This is out of

[GitHub] [skywalking-satellite] hanahmily commented on a change in pull request #5: Add API && Plugin framework registry

hanahmily commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532007749 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,74 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[skywalking] branch 8.3.0-release updated: [maven-release-plugin] prepare for next development iteration

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch 8.3.0-release in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/8.3.0-release by this push: new a299ab5

[skywalking] branch 8.3.0-release created (now d93ffed)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch 8.3.0-release in repository https://gitbox.apache.org/repos/asf/skywalking.git. at d93ffed [maven-release-plugin] prepare release v8.3.0 No new revisions were added by this update.

[skywalking] annotated tag v8.3.0 updated (d93ffed -> e9ab4bb)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to annotated tag v8.3.0 in repository https://gitbox.apache.org/repos/asf/skywalking.git. *** WARNING: tag v8.3.0 was modified! *** from d93ffed (commit) to e9ab4bb (tag) tagging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] mrproliu opened a new issue #5918: The Profile and Trace Table UI seems the Exec(%) column is not vertically

mrproliu opened a new issue #5918: URL: https://github.com/apache/skywalking/issues/5918 - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirement - [ ] Feature or performance improvement ### Bug - Version: SkyWalking 8.2.0, Chrome

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #5: Add API && Plugin framework registry

EvanLjp commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532039980 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,74 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #5: Add API && Plugin framework registry

EvanLjp commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532040371 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,74 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #2: Make async stuff work reliably

kezhenxu94 commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735231523 > Configuration error I think, I don't get the "no-shadowed-variable Shadowed name: ?" error locally when I build or lint. What IDE are you using? I'm using

[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #2: Make async stuff work reliably

tom-pytel commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735231626 > What IDE are you using? I'm using WebStorm, make sure to enable tslint and prettier, or run `npm run lint` in the command line, also please rebase on the master (I

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng closed issue #5904: [UI Enhancement] Elasticsearch exception type=index_not_found_exception

wu-sheng closed issue #5904: URL: https://github.com/apache/skywalking/issues/5904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng opened a new issue #5919: [JDK11] Javadoc doesn't work out.

wu-sheng opened a new issue #5919: URL: https://github.com/apache/skywalking/issues/5919 I was facing this in the 8.3.0 release. Let's fix this and add `check` in the CI process. This is an automated message from the Apache

[skywalking-satellite] branch plugin-framework updated (4bc63a9 -> 3d364c4)

This is an automated email from the ASF dual-hosted git repository. liujiapeng pushed a change to branch plugin-framework in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. from 4bc63a9 add more detailed comments add 3d364c4 Remove unclear concepts No new

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #2: Make async stuff work reliably

tom-pytel commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735230668 Configuration error I think, I don't get the "no-shadowed-variable Shadowed name: ?" error locally when I build or lint.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #5: Add API && Plugin framework registry

EvanLjp commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532039980 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,74 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[skywalking-satellite] branch plugin-framework updated (1f0dbf0 -> e260532)

This is an automated email from the ASF dual-hosted git repository. liujiapeng pushed a change to branch plugin-framework in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. from 1f0dbf0 Remove unclear concepts add e260532 add more comments No new revisions

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #5: Add API && Plugin framework registry

wu-sheng commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532044255 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,74 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #2: Make async stuff work reliably

kezhenxu94 commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735242587 @tom-pytel is it ready to review/merge now? This is an automated message from the Apache Git Service. To

[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #2: Make async stuff work reliably

tom-pytel commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735243064 But if you want to have a quick look, questions / comments are always welcome. This is an automated

[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #2: Make async stuff work reliably

tom-pytel commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735242964 No not quite ready to merge, need to show cases where this works and previous one doesn't and want to export `ContextManager` for user specified spans. Hoping for later

[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #5: Add API && Plugin framework registry

EvanLjp commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532052890 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,74 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #5: Add API && Plugin framework registry

EvanLjp commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532053497 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,74 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[skywalking-satellite] branch plugin-framework updated (3d364c4 -> 1f0dbf0)

This is an automated email from the ASF dual-hosted git repository. liujiapeng pushed a change to branch plugin-framework in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. from 3d364c4 Remove unclear concepts add 1f0dbf0 Remove unclear concepts No new

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[skywalking] 01/01: [maven-release-plugin] prepare for next development iteration

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch 8.3.0-release in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 8f815912a5e316535dffe9a4aa74ad5341364574 Author: wu-sheng AuthorDate: Sat Nov 28 15:07:49 2020 +

[skywalking] branch 8.3.0-release created (now 8f81591)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch 8.3.0-release in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 8f81591 [maven-release-plugin] prepare for next development iteration This branch includes the

[skywalking] annotated tag v8.3.0 updated (cb76ba4 -> e54f693)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to annotated tag v8.3.0 in repository https://gitbox.apache.org/repos/asf/skywalking.git. *** WARNING: tag v8.3.0 was modified! *** from cb76ba4 (commit) to e54f693 (tag) tagging

[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #2: Make async stuff work reliably

kezhenxu94 commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735243085 > No not quite ready to merge, need to show cases where this works and previous one doesn't and want to export `ContextManager` for user specified spans. Hoping for

[GitHub] [skywalking-nodejs] kezhenxu94 edited a comment on pull request #2: Make async stuff work reliably

kezhenxu94 edited a comment on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735243085 > No not quite ready to merge, need to show cases where this works and previous one doesn't and want to export `ContextManager` for user specified spans. Hoping

[GitHub] [skywalking-nodejs] kezhenxu94 commented on a change in pull request #2: Make async stuff work reliably

kezhenxu94 commented on a change in pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#discussion_r532052444 ## File path: src/trace/context/ContextManager.ts ## @@ -18,19 +18,74 @@ */ import Context from '../../trace/context/Context'; +import Span

[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #2: Make async stuff work reliably

kezhenxu94 commented on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735248247 > * Context.capture() and restore() will be made redundant / unnecessary by this? Yes I believe they're unnecessary after this PR, feel free to remove them

[GitHub] [skywalking-nodejs] tom-pytel commented on a change in pull request #2: Make async stuff work reliably

tom-pytel commented on a change in pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#discussion_r532060369 ## File path: src/trace/context/ContextManager.ts ## @@ -18,19 +18,74 @@ */ import Context from '../../trace/context/Context'; +import Span

[GitHub] [skywalking-nodejs] tom-pytel commented on a change in pull request #2: Make async stuff work reliably

tom-pytel commented on a change in pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#discussion_r532060352 ## File path: src/trace/context/ContextManager.ts ## @@ -18,19 +18,74 @@ */ import Context from '../../trace/context/Context'; +import Span

  1   2   >