[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-19 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r456986342 ## File path: docs/en/setup/backend/dynamic-config.md ## @@ -103,3 +103,20 @@ configuration: appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-19 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r456984069 ## File path: docs/en/setup/backend/dynamic-config.md ## @@ -103,3 +103,20 @@ configuration: appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-14 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r454208379 ## File path:

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-12 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r453316526 ## File path: oap-server/server-bootstrap/src/main/resources/application.yml ## @@ -264,6 +264,10 @@ configuration: period:

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451276365 ## File path:

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451234306 ## File path:

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451227086 ## File path:

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451227147 ## File path: docs/en/setup/backend/dynamic-config.md ## @@ -102,3 +102,16 @@ configuration: appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r443522852 ## File path: oap-server/server-configuration/configuration-configmap/pom.xml ## @@ -0,0 +1,31 @@ + Review comment: sorry, i would be fix