[GitHub] [skywalking] Jargon96 edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox 


Jargon96 edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723450985


   > Seems you forgot to update this 
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Supported-list.md
   
   Dear sir, Is cache classification appropriate？or create a new classification 
named DBCP?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] Jargon96 edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-10-23 Thread GitBox 


Jargon96 edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-715423610


   I updated plugin and modified some inappropriate places, please review.
   
   The statements I executed in test case：
   * CREATE TABLE test_DBCP
   * INSERT INTO test_DBCP(id, value) VALUES(1,1)
   * SELECT id, value FROM test_DBCP WHERE id=1
   * DELETE FROM test_DBCP WHERE id=1
   * DROP table test_DBCP
   
   After the statement is executed, I closed the connection and returned it to 
the connection pool.
   
![test_case](https://user-images.githubusercontent.com/40067375/97024987-1102d300-158a-11eb-9a4c-48a11f8991b8.png)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] Jargon96 edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-10-23 Thread GitBox 


Jargon96 edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-715423610


   I updated plugin and modified some inappropriate places, please review.
   
   These are the statements I executed in test case：
   * CREATE TABLE test_DBCP
   * INSERT INTO test_DBCP(id, value) VALUES(1,1)
   * SELECT id, value FROM test_DBCP WHERE id=1
   * DELETE FROM test_DBCP WHERE id=1
   * DROP table test_DBCP
   
   After the statement is executed, I closed the connection and returned it to 
the connection pool.
   
![test_case](https://user-images.githubusercontent.com/40067375/97024987-1102d300-158a-11eb-9a4c-48a11f8991b8.png)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] Jargon96 edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-10-23 Thread GitBox 


Jargon96 edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-715423610


   I updated plugin and modified some inappropriate places, please review.
   
   This is the statement I executed in test case：
   * CREATE TABLE test_DBCP
   * INSERT INTO test_DBCP(id, value) VALUES(1,1)
   * SELECT id, value FROM test_DBCP WHERE id=1
   * DELETE FROM test_DBCP WHERE id=1
   * DROP table test_DBCP
   
   After the statement is executed, I closed the connection and returned it to 
the connection pool.
   
![test_case](https://user-images.githubusercontent.com/40067375/97024987-1102d300-158a-11eb-9a4c-48a11f8991b8.png)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org