[GitHub] [skywalking] codecov-io edited a comment on issue #4555: Correlation protocol implement

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #4555: Correlation protocol implement
URL: https://github.com/apache/skywalking/pull/4555#issuecomment-602475846
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=h1) 
Report
   > Merging 
[#4555](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e7f66c911eaf18a14793e5edf09788cb5f391f29=desc)
 will **increase** coverage by `0.12%`.
   > The diff coverage is `52.04%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4555/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4555  +/-   ##
   ==
   + Coverage   25.57%   25.69%   +0.12% 
   ==
 Files1246 1250   +4 
 Lines   2897529071  +96 
 Branches 3974 3990  +16 
   ==
   + Hits 7410 7471  +61 
   - Misses  2087320909  +36 
   + Partials  692  691   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh)
 | `50.00% <0.00%> (-2.39%)` | :arrow_down: |
   | 
[...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ng/apm/agent/core/context/MockContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRlc3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Nb2NrQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0R2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextPutInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0UHV0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...olkit/activation/trace/TraceContextActivation.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvVHJhY2VDb250ZXh0QWN0aXZhdGlvbi5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh)
 | `71.42% <40.00%> (ø)` | |
   | 
[...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh)
 | `61.66% <60.00%> (+0.22%)` | :arrow_up: |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `66.66% <66.66%> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `70.17% <100.00%> (+1.08%)` | :arrow_up: |
   | ... and [11 
more](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=continue).
   > 

[GitHub] [skywalking] codecov-io edited a comment on issue #4555: Correlation protocol implement

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #4555: Correlation protocol implement
URL: https://github.com/apache/skywalking/pull/4555#issuecomment-602475846
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=h1) 
Report
   > Merging 
[#4555](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/f1b2b298b1dcb75f5c211c71b0b956d447859d1d=desc)
 will **increase** coverage by `0.09%`.
   > The diff coverage is `51.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4555/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4555  +/-   ##
   ==
   + Coverage   25.57%   25.67%   +0.09% 
   ==
 Files1246 1251   +5 
 Lines   2897529073  +98 
 Branches 3974 3990  +16 
   ==
   + Hits 7410 7464  +54 
   - Misses  2087320918  +45 
   + Partials  692  691   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh)
 | `50.00% <0.00%> (-2.39%)` | :arrow_down: |
   | 
[...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ng/apm/agent/core/context/MockContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRlc3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Nb2NrQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...activation/trace/CorrelationContextActivation.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0QWN0aXZhdGlvbi5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0R2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextSetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0U2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh)
 | `71.42% <40.00%> (ø)` | |
   | 
[...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh)
 | `61.66% <60.00%> (+0.22%)` | :arrow_up: |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `66.66% <66.66%> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `70.17% <100.00%> (+1.08%)` | :arrow_up: |
   | ... and [13 
more](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=continue).
   > 

[GitHub] [skywalking] codecov-io edited a comment on issue #4555: Correlation protocol implement

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #4555: Correlation protocol implement
URL: https://github.com/apache/skywalking/pull/4555#issuecomment-602475846
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=h1) 
Report
   > Merging 
[#4555](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/f1b2b298b1dcb75f5c211c71b0b956d447859d1d?src=pr=desc)
 will **increase** coverage by `0.1%`.
   > The diff coverage is `54.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4555/graphs/tree.svg?width=650=qrILxY5yA8=150=pr)](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#4555 +/-   ##
   =
   + Coverage   25.57%   25.67%   +0.1% 
   =
 Files1246 1251  +5 
 Lines   2897529066 +91 
 Branches 3974 3987 +13 
   =
   + Hits 7410 7464 +54 
   - Misses  2087320913 +40 
   + Partials  692  689  -3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ng/apm/agent/core/context/MockContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRlc3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Nb2NrQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...vation/trace/CorrelationContextGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0R2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0% <0%> (ø)` | |
   | 
[...vation/trace/CorrelationContextSetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0U2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0% <0%> (ø)` | |
   | 
[...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...activation/trace/CorrelationContextActivation.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0QWN0aXZhdGlvbi5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh)
 | `50% <0%> (-2.39%)` | :arrow_down: |
   | 
[.../agent/core/context/SW7CorrelationCarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzdDb3JyZWxhdGlvbkNhcnJpZXJJdGVtLmphdmE=)
 | `100% <100%> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `70.17% <100%> (+1.08%)` | :arrow_up: |
   | 
[...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh)
 | `70.96% <100%> (+0.96%)` | :arrow_up: |
   | 
[...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh)
 | `71.42% <40%> (ø)` | :arrow_up: |
   | ... and [13 
more](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=continue).
   > **Legend** - 

[GitHub] [skywalking] codecov-io edited a comment on issue #4555: Correlation protocol implement

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #4555: Correlation protocol implement
URL: https://github.com/apache/skywalking/pull/4555#issuecomment-602475846
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=h1) 
Report
   > Merging 
[#4555](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/7c9b6cf054f8e534afcc5366e01858b384fd7e8d=desc)
 will **increase** coverage by `0.12%`.
   > The diff coverage is `54.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4555/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4555  +/-   ##
   ==
   + Coverage   25.54%   25.67%   +0.12% 
   ==
 Files1246 1251   +5 
 Lines   2897529066  +91 
 Branches 3974 3987  +13 
   ==
   + Hits 7403 7464  +61 
   - Misses  2088020913  +33 
   + Partials  692  689   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh)
 | `50.00% <0.00%> (-2.39%)` | :arrow_down: |
   | 
[...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ng/apm/agent/core/context/MockContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRlc3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Nb2NrQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...activation/trace/CorrelationContextActivation.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0QWN0aXZhdGlvbi5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0R2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextSetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0U2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh)
 | `71.42% <40.00%> (ø)` | |
   | 
[...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh)
 | `61.66% <60.00%> (+0.22%)` | :arrow_up: |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `76.59% <76.59%> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `70.17% <100.00%> (+1.08%)` | :arrow_up: |
   | ... and [12 
more](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=continue).
   > 

[GitHub] [skywalking] codecov-io edited a comment on issue #4555: Correlation protocol implement

2020-03-23 Thread GitBox
codecov-io edited a comment on issue #4555: Correlation protocol implement
URL: https://github.com/apache/skywalking/pull/4555#issuecomment-602475846
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=h1) 
Report
   > Merging 
[#4555](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/7c9b6cf054f8e534afcc5366e01858b384fd7e8d=desc)
 will **increase** coverage by `0.12%`.
   > The diff coverage is `53.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4555/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4555  +/-   ##
   ==
   + Coverage   25.54%   25.67%   +0.12% 
   ==
 Files1246 1251   +5 
 Lines   2897529068  +93 
 Branches 3974 3987  +13 
   ==
   + Hits 7403 7464  +61 
   - Misses  2088020915  +35 
   + Partials  692  689   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh)
 | `50.00% <0.00%> (-2.39%)` | :arrow_down: |
   | 
[...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ng/apm/agent/core/context/MockContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRlc3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Nb2NrQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...activation/trace/CorrelationContextActivation.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0QWN0aXZhdGlvbi5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0R2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextSetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0U2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh)
 | `71.42% <40.00%> (ø)` | |
   | 
[...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh)
 | `61.66% <60.00%> (+0.22%)` | :arrow_up: |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `76.59% <76.59%> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `70.17% <100.00%> (+1.08%)` | :arrow_up: |
   | ... and [12 
more](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=continue).
   > 

[GitHub] [skywalking] codecov-io edited a comment on issue #4555: Correlation protocol implement

2020-03-23 Thread GitBox
codecov-io edited a comment on issue #4555: Correlation protocol implement
URL: https://github.com/apache/skywalking/pull/4555#issuecomment-602475846
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=h1) 
Report
   > Merging 
[#4555](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/7c9b6cf054f8e534afcc5366e01858b384fd7e8d=desc)
 will **increase** coverage by `0.12%`.
   > The diff coverage is `52.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4555/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4555  +/-   ##
   ==
   + Coverage   25.54%   25.67%   +0.12% 
   ==
 Files1246 1251   +5 
 Lines   2897529070  +95 
 Branches 3974 3987  +13 
   ==
   + Hits 7403 7463  +60 
   - Misses  2088020917  +37 
   + Partials  692  690   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh)
 | `50.00% <0.00%> (-2.39%)` | :arrow_down: |
   | 
[...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ng/apm/agent/core/context/MockContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRlc3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Nb2NrQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...activation/trace/CorrelationContextActivation.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0QWN0aXZhdGlvbi5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0R2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextSetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0U2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh)
 | `71.42% <40.00%> (ø)` | |
   | 
[...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh)
 | `61.66% <60.00%> (+0.22%)` | :arrow_up: |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `76.59% <76.59%> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `70.17% <100.00%> (+1.08%)` | :arrow_up: |
   | ... and [13 
more](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=continue).
   > 

[GitHub] [skywalking] codecov-io edited a comment on issue #4555: Correlation protocol implement

2020-03-23 Thread GitBox
codecov-io edited a comment on issue #4555: Correlation protocol implement
URL: https://github.com/apache/skywalking/pull/4555#issuecomment-602475846
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=h1) 
Report
   > Merging 
[#4555](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/954eede0ec727222d14cdb41ab584e6354776c49=desc)
 will **increase** coverage by `0.10%`.
   > The diff coverage is `52.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4555/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4555  +/-   ##
   ==
   + Coverage   25.57%   25.67%   +0.10% 
   ==
 Files1246 1251   +5 
 Lines   2897529070  +95 
 Branches 3974 3987  +13 
   ==
   + Hits 7410 7464  +54 
   - Misses  2087320917  +44 
   + Partials  692  689   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh)
 | `50.00% <0.00%> (-2.39%)` | :arrow_down: |
   | 
[...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ng/apm/agent/core/context/MockContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRlc3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Nb2NrQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...activation/trace/CorrelationContextActivation.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0QWN0aXZhdGlvbi5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0R2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextSetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0U2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh)
 | `71.42% <40.00%> (ø)` | |
   | 
[...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh)
 | `61.66% <60.00%> (+0.22%)` | :arrow_up: |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `76.59% <76.59%> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `70.17% <100.00%> (+1.08%)` | :arrow_up: |
   | ... and [13 
more](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=continue).
   > 

[GitHub] [skywalking] codecov-io edited a comment on issue #4555: Correlation protocol implement

2020-03-23 Thread GitBox
codecov-io edited a comment on issue #4555: Correlation protocol implement
URL: https://github.com/apache/skywalking/pull/4555#issuecomment-602475846
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=h1) 
Report
   > Merging 
[#4555](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/2ec8e2ad7b67d3f1e5d551b33151922448fd8309=desc)
 will **increase** coverage by `0.11%`.
   > The diff coverage is `57.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4555/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4555  +/-   ##
   ==
   + Coverage   25.57%   25.68%   +0.11% 
   ==
 Files1246 1251   +5 
 Lines   2897529067  +92 
 Branches 3974 3988  +14 
   ==
   + Hits 7410 7467  +57 
   - Misses  2087320911  +38 
   + Partials  692  689   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh)
 | `50.00% <0.00%> (-2.39%)` | :arrow_down: |
   | 
[...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ng/apm/agent/core/context/MockContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRlc3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Nb2NrQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...activation/trace/CorrelationContextActivation.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0QWN0aXZhdGlvbi5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0R2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...vation/trace/CorrelationContextSetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvQ29ycmVsYXRpb25Db250ZXh0U2V0SW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh)
 | `71.42% <40.00%> (ø)` | |
   | 
[...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh)
 | `61.66% <60.00%> (+0.22%)` | :arrow_up: |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `88.63% <88.63%> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `70.17% <100.00%> (+1.08%)` | :arrow_up: |
   | ... and [13 
more](https://codecov.io/gh/apache/skywalking/pull/4555/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4555?src=pr=continue).
   >