[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-03-02 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-593429451 > The configuration my.cnf of ShardingProxy is supposed to locate in

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-23 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-590200076 We keep doing as we planned, all these discussions are improvements. We could set up the table one by one

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-23 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-590192000 > How to make proxy know there is a to-check table which is not existing in configuration? You

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-23 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-590066045 @tristaZero Please feel free to go by following your existing plan. All I asked are about I want the

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-22 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-589949730 Based on the description, if there is a new dynamic table we missed on the config file, the system still

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-20 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-589526437 OK. Then the question will be, how to check the configuration is still good for every commit in the e2e?

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-20 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-589509147 > Using a Regex or expression to represent the tables on configuration of sharding proxy? Yes. I

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-20 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-589140762 Can't you use a Regex or expression to represent the tables? I was assuming we could do that.

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-19 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588134088 I mean config the table names with some rules(Regex), or exclusion rule is better. Such as `all table

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-19 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588105831 > My first idea of sharding stratergy is to shard certain table, taking alarm_record for example, into 4

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588049040 > What you concerned is to provide certain rules for tables without sharding, right? No, the

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587410043 Most of SkyWalking tables are created by OAL scripts. Do you know what is it? Limited tables are

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-17 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587321026 > From my point, it seems time_bucket and id are feasible for tables to do range sharding. I can

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584610355 > Sharding-algorithm implements interface of ShardingSphere, which means ShardingSphere pom will be

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584537206 > ShardingSphere is planning to do some optimization for sharding algorithm. And the main idea is to

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584534922 Then the expected module will be `oap-server/server-storage-plugin/storage-shardingsphere-algorithms`.

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584530629 There are some options 1. As you said, you could provide the source codes hosted in SkyWalking main

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584524257 If this runs into the release process, it seems you need another repo? If that, I would like to ask you

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584523846 `sharding-algorithm.jar` needs to be taken care of differently. It is a binary distribution, so it can't

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-09 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-583974818 I think the configuration should be placed in `install/shardingsphere/proxy/my.cnf`. At the same time,