[GitHub] [skywalking] wu-sheng commented on pull request #4958: add brpc-java plugin

2020-06-23 Thread GitBox
wu-sheng commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-648529442 Let's skip that version for now. We could copy/paste that method and change codes, but as this plugin is not that popular, let's wait.

[GitHub] [skywalking] wu-sheng commented on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
wu-sheng commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647483228 Also, I noticed, there is brpc 3.x, do you plan to support it too? This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
wu-sheng commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647379994 What is a surprise, you are doing this. This is an automated message from the Apache Git Service. To