wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660736322
@EvanLjp Still need you to polish this PR.
This is an automated message from the Apache Git Service.
To resp
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660097453
Let's make that decision first, then back to this feature.
This is an automated message from the Apache Git
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660097268
By thinking the PR and Kafka transport PR, I prefer you work on a new PR.
Introduce a new SPI service, called ConfigInitService. All plugins and core
could provide their s
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-658031498
@innerpeacez Please recheck.
This is an automated message from the Apache Git Service.
To respond to the mes
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657240474
It is required, such as local mini kube. We can't afford very pr repeatedly
by committer. They are busy too.
---
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657237166
Please provide your local test logs to prove you have tested the codes.
Otherwise, I would not recommend our committer to spend time on reviewing this
PR.
Changing th
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657236965
And, you don't need
`org.apache.skywalking.oap.server.library.module.ModuleProvider` duplicated in
the test folder. They should share the same one in the `src`.
--
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657236863
I am pretty sure you have not tested the codes locally. P
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657235551
I and @innerpeacez are still trying to bootstrap the codes. The OAP even
can't start up by your pull request. Please recheck locally, and save our time.
---
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657230730
> yes , this code has been already running on our production env
That is why I asked you make sure, the open source version should be tested
again.
-
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657223329
> i would like to fix this little bugs now , and i don't know how to add the
e2e process .
Recently, i am so busy on my work . prefer to add the e2e process in the
next p
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657179933
I guess these codes maybe run in your private env, because every time, you
want to push the changes in the upstream, you should and need to test again on
the new codebase. O
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-656529033
@innerpeacez More importantly, once it is changed, the OAP should receive
that notification, and behavior should be changed, such as sampling rate.
Switching to 10% from 100
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-656522857
@innerpeacez The thing you are asking, we could discuss on another issue :)
This is an automated message fro
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-656522669
@innerpeacez He is doing dynamic configuration, not static config override.
So basically, he wants to change this in the runtime. Based on this, the name
should follow the d
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-655819719
@EvanLjp A lot of CI tasks fail, what happens? Could you fix them?
This is an automated message from the Apa
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-653268512
@EvanLjp Please update the document.
This is an automated message from the Apache Git Service.
To respond to
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-652206008
It says your codes coverage rate is lower than the whole project.
This is an automated message from the Apa
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-652118990
There are still some issues about the CI process.
This is an automated message from the Apache Git Service.
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-651583521
@EvanLjp Could you make this PR ready?
This is an automated message from the Apache Git Service.
To respond
wu-sheng commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647475836
Please run rat check, is there ASF 2.0 header missing?
This is an automated message from the Apache Git Serv
21 matches
Mail list logo
