[GitHub] [skywalking-cli] wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-552095184 @kezhenxu94 Yes, confirmed. We should begin a new pull request and write a document from now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551397201 @heyanlong It doesn't look like you approved this PR, there is still comment in your reply. Is this a mistake? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551137892 Also, unit tests, test coverage, and comment should be added. For e2e, we could add later, that is not a high priority work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551096824 > CLI is usually chained with pipe, like swctl service ls | jq, presenting the data in a table maybe another option, but that's another story Agree. Table form should be a specific parameter. Such as `--list-t` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
