[GitHub] [skywalking-python] wu-sheng commented on a change in pull request #27: Add docs on how to install from Pypi

2020-06-30 Thread GitBox


wu-sheng commented on a change in pull request #27:
URL: https://github.com/apache/skywalking-python/pull/27#discussion_r447454283



##
File path: README.md
##
@@ -13,6 +13,20 @@ microservices, cloud native and container-based (Docker, 
Kubernetes, Mesos) arch
 
 
[![Build](https://github.com/apache/skywalking-python/workflows/Build/badge.svg?branch=master)](https://github.com/apache/skywalking-python/actions?query=branch%3Amaster+event%3Apush+workflow%3A%22Build%22)
 
+## Install
+
+### From Pypi (Recommended)

Review comment:
   I think from Apache, this should not be recommended. Because at least 
for now, source codes are the only official release. Someone is asking for 
change about this, but still, it is there.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking-python] wu-sheng commented on a change in pull request #27: Add docs on how to install from Pypi

2020-06-30 Thread GitBox


wu-sheng commented on a change in pull request #27:
URL: https://github.com/apache/skywalking-python/pull/27#discussion_r447454465



##
File path: README.md
##
@@ -13,6 +13,20 @@ microservices, cloud native and container-based (Docker, 
Kubernetes, Mesos) arch
 
 
[![Build](https://github.com/apache/skywalking-python/workflows/Build/badge.svg?branch=master)](https://github.com/apache/skywalking-python/actions?query=branch%3Amaster+event%3Apush+workflow%3A%22Build%22)
 
+## Install
+
+### From Pypi (Recommended)

Review comment:
   Also, I think you should add doc about install a specific version?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org