[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391929197 OK, I'll do it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390936276 Promise This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390936276 Promise This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389725100 > Please notice, only transfer the only one you need It's hard to transfer the only one, because of the Spring `AntPathMatcher` import some util class, the other util class also import others, but they all belong to a same package, can I transfer the whole package `org.springframework.util`? exclude child package of course This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389464675 > I think should add in this plugin module. What about the distribution look like this?  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389447570 @wu-sheng Should I create a new module as a dependent transformation? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389375085 This is current `optional-plugins` look like  In the `AntPathMatcher` , the most of the code is copied form Spring Framework. I only remove the superfluous method, and make some revise in order to pass through `checkstyle`. I've never had such experience before, and I don't know what the effect of adding Apache license to the code will be. I'm sorry about that. If this can not be merged, I think it might be possible to use these extended functions in the form of third party plugins. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
