[GitHub] wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception
wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044#issuecomment-379947256 I think brave'TracingServerInterceptor can avoid "cross thread" situation. https://github.com/openzipkin/brave/blob/master/instrumentation/grpc/src/main/java/brave/grpc/TracingServerInterceptor.java I will read SkyWalking code deeply to find if it is a SkyWalking bug . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception
wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044#issuecomment-379929493 I can reproduce in my mac pro notebook, but it has not reproduce on my linux server util now . But in our grpc products, we have found that we used thread local in a wrong way. [grpc cross thread.pdf](https://github.com/apache/incubator-skywalking/files/1892337/grpc.cross.thread.pdf) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception
wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044#issuecomment-379471160 i just test skywalking using grpc self's example code "Greeter code" https://github.com/grpc/grpc-java/blob/master/examples/src/main/java/io/grpc/examples/helloworld/HelloWorldClient.java This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception
wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044#issuecomment-379471160 i just test skywalking useing grpc self's example code "Greeter code" https://github.com/grpc/grpc-java/blob/master/examples/src/main/java/io/grpc/examples/helloworld/HelloWorldClient.java This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
