[GitHub] wu-sheng commented on a change in pull request #1074: DAO interface document.
wu-sheng commented on a change in pull request #1074: DAO interface document.
URL:
https://github.com/apache/incubator-skywalking/pull/1074#discussion_r181551732
##
File path:
apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/ICpuMetricUIDAO.java
##
@@ -20,12 +20,38 @@
import java.util.List;
import org.apache.skywalking.apm.collector.storage.base.dao.DAO;
+import org.apache.skywalking.apm.collector.storage.table.jvm.CpuMetricTable;
import org.apache.skywalking.apm.collector.storage.ui.common.Step;
import org.apache.skywalking.apm.collector.storage.utils.DurationPoint;
/**
+ * Interface to be implemented for execute database query operation
+ * from {@link CpuMetricTable#TABLE}.
+ *
* @author peng-yongsheng
+ * @see org.apache.skywalking.apm.collector.storage.table.jvm.CpuMetricTable
+ * @see org.apache.skywalking.apm.collector.storage.StorageModule
*/
public interface ICpuMetricUIDAO extends DAO {
+
+/**
+ * Execute a database query operation, implemented in different
+ * storage module.
Review comment:
~~Execute a database query operation, implemented in different storage
module.~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1074: DAO interface document.
wu-sheng commented on a change in pull request #1074: DAO interface document.
URL:
https://github.com/apache/incubator-skywalking/pull/1074#discussion_r181551647
##
File path:
apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/ICpuMetricUIDAO.java
##
@@ -20,12 +20,38 @@
import java.util.List;
import org.apache.skywalking.apm.collector.storage.base.dao.DAO;
+import org.apache.skywalking.apm.collector.storage.table.jvm.CpuMetricTable;
import org.apache.skywalking.apm.collector.storage.ui.common.Step;
import org.apache.skywalking.apm.collector.storage.utils.DurationPoint;
/**
+ * Interface to be implemented for execute database query operation
+ * from {@link CpuMetricTable#TABLE}.
Review comment:
Interface to be implemented for {@link CpuMetricTable#TABLE} related
queries.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1074: DAO interface document.
wu-sheng commented on a change in pull request #1074: DAO interface document.
URL:
https://github.com/apache/incubator-skywalking/pull/1074#discussion_r181551647
##
File path:
apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/ICpuMetricUIDAO.java
##
@@ -20,12 +20,38 @@
import java.util.List;
import org.apache.skywalking.apm.collector.storage.base.dao.DAO;
+import org.apache.skywalking.apm.collector.storage.table.jvm.CpuMetricTable;
import org.apache.skywalking.apm.collector.storage.ui.common.Step;
import org.apache.skywalking.apm.collector.storage.utils.DurationPoint;
/**
+ * Interface to be implemented for execute database query operation
+ * from {@link CpuMetricTable#TABLE}.
Review comment:
Implement `ICpuMetricUIDAO` interface to do {@link CpuMetricTable#TABLE}
related query.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
