[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899019 ## File path: docs/cn/Shardingjdbc-CN.md ## @@ -0,0 +1,21 @@ +# 支持数据库分片存储 +除了默认的Elasticsearch存储外，还支持数据库分片存储，允许用户将数据存储在多个数据库中。 +注意：目前仅支持MYSQL数据库的分片存储，且由于license限制，需要用户手动引入mysql驱动包。 + +## 版本支持 +5.0.0-beta + + +## 配置要求 +- 手工导入MYSQL的驱动包mysql-connector-java-5.1.36.jar到collector libs目录下。 +- config/application.yml中，关闭elasticsearch配置，打开shardingjdbc配置，多个数据源配置用半角逗号隔开。 +``` javascript Review comment: It is a yml, not a javascript. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899006 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,21 @@ +# Supported Database Sharding Storage +Beside the default Elasticsearch storage, it also support the database sharding storage, it allow the users to store data in multiple databases. +Note: it only supported MYSQL database sharding, and due to the license restrictions, the users need to import MYSQL Driver manually. + +## Supported version +5.0.0-beta + + +## Requirement +- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to collector libs directory. +- In config/application.yml, close the elasticsearch configuration and open the shardingjdbc configuration, multiple data source configurations should be separated by Half Comma. +``` javascript Review comment: It is a yml, not a javascript. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898905 ## File path: docs/cn/Shardingjdbc-CN.md ## @@ -0,0 +1,21 @@ +# 支持数据库分片存储 +除了默认的Elasticsearch存储外，还支持数据库分片存储，允许用户将数据存储在多个数据库中。 +注意：目前仅支持MYSQL数据库的分片存储，且由于license限制，需要用户手动引入mysql驱动包。 + +## 版本支持 +5.0.0-beta + Review comment: beta2? beta is under release process now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898936 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,21 @@ +# Supported Database Sharding Storage +Beside the default Elasticsearch storage, it also support the database sharding storage, it allow the users to store data in multiple databases. +Note: it only supported MYSQL database sharding, and due to the license restrictions, the users need to import MYSQL Driver manually. + +## Supported version +5.0.0-beta + Review comment: beta2? beta is under release process now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898156 ## File path: docs/README_ZH.md ## @@ -1,42 +1,46 @@ -## 中文文档 -[](README.md) - - * 快速入门 -* [快速入门](cn/Quick-start-CN.md) -* [中间件，框架与类库支持列表](Supported-list.md) -* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md) - * 高级特性 -* [通过系统启动参数进行覆盖配置](cn/Setting-override-CN.md) -* [服务直连(Direct uplink)及禁用名称服务(naming service)](cn/Direct-uplink-CN.md) -* [开启TLS](cn/TLS-CN.md) -* [命名空间隔离](cn/Namespace-CN.md) -* [基于Token认证](cn/Token-auth-CN.md) - * APM相关介绍资料 -* [OpenTracing中文版](https://github.com/opentracing-contrib/opentracing-specification-zh) - * Application Toolkit，应用程序工具包 -* [概述](cn/Application-toolkit-CN.md) -* [OpenTracing Tracer](cn/Opentracing-CN.md) -* 日志组件 - * [log4j组件](cn/Application-toolkit-log4j-1.x-CN.md) - * [log4j2组件](cn/Application-toolkit-log4j-2.x-CN.md) - * [logback组件](cn/Application-toolkit-logback-1.x-CN.md) -* [Trace](cn/Application-toolkit-trace-CN.md) -* [调用链跨线程传递](cn/Application-toolkit-trace-cross-thread-CN.md) - * 测试用例 -* [插件测试](https://github.com/SkywalkingTest/agent-integration-test-report) -* [Java 探针性能测试](https://skywalkingtest.github.io/Agent-Benchmarks/README_zh.html) - * 开发指南 -* [工程编译指南](cn/How-to-build-CN.md) -* [插件开发指南](cn/Plugin-Development-Guide-CN.md) -* 交互协议 -* [Cross Process Propagation Headers Protocol, v1.0 跨进程追踪上下文传递协议](cn/Skywalking-Cross-Process-Propagation-Headers-Protocol-CN-v1.md) -* [SkyWalking Trace Data Protocol 探针与Collector间网络协议](cn/Trace-Data-Protocol-CN.md) - * [Roadmap](ROADMAP.md) - * 社区提供的共享资源 -* [公开演讲](https://github.com/OpenSkywalking/Community#public-speakings) -* [视频](https://github.com/OpenSkywalking/Community#videos) -* [文章](https://github.com/OpenSkywalking/Community#articles) - * FAQ -* [Trace查询有数据，但是没有拓扑图和JVM数据?](cn/FAQ/Why-have-traces-no-others-CN.md) -* [加载探针，Console被GRPC日志刷屏](cn/FAQ/Too-many-gRPC-logs-CN.md) -* [Kafka消息消费端链路断裂](cn/FAQ/Kafka-plugin-CN.md) +## 中文文档 +[](README.md) + + * 快速入门 +* [快速入门](cn/Quick-start-CN.md) +* [中间件，框架与类库支持列表](Supported-list.md) +* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md) +* [可选插件](cn/Optional-plugins-CN.md) + * 高级特性 +* [通过系统启动参数进行覆盖配置](cn/Setting-override-CN.md) +* [服务直连(Direct uplink)及禁用名称服务(naming service)](cn/Direct-uplink-CN.md) +* [开启TLS](cn/TLS-CN.md) +* [命名空间隔离](cn/Namespace-CN.md) +* [基于Token认证](cn/Token-auth-CN.md) +* [使用Shardingjdbc作为存储实现](cn/Shardingjdbc-CN.md) Review comment: In CN doc, also need an `孵化功能` section. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899581 ## File path: docs/README_ZH.md ## @@ -1,42 +1,46 @@ -## 中文文档 -[](README.md) - - * 快速入门 -* [快速入门](cn/Quick-start-CN.md) -* [中间件，框架与类库支持列表](Supported-list.md) -* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md) - * 高级特性 -* [通过系统启动参数进行覆盖配置](cn/Setting-override-CN.md) -* [服务直连(Direct uplink)及禁用名称服务(naming service)](cn/Direct-uplink-CN.md) -* [开启TLS](cn/TLS-CN.md) -* [命名空间隔离](cn/Namespace-CN.md) -* [基于Token认证](cn/Token-auth-CN.md) - * APM相关介绍资料 -* [OpenTracing中文版](https://github.com/opentracing-contrib/opentracing-specification-zh) - * Application Toolkit，应用程序工具包 -* [概述](cn/Application-toolkit-CN.md) -* [OpenTracing Tracer](cn/Opentracing-CN.md) -* 日志组件 - * [log4j组件](cn/Application-toolkit-log4j-1.x-CN.md) - * [log4j2组件](cn/Application-toolkit-log4j-2.x-CN.md) - * [logback组件](cn/Application-toolkit-logback-1.x-CN.md) -* [Trace](cn/Application-toolkit-trace-CN.md) -* [调用链跨线程传递](cn/Application-toolkit-trace-cross-thread-CN.md) - * 测试用例 -* [插件测试](https://github.com/SkywalkingTest/agent-integration-test-report) -* [Java 探针性能测试](https://skywalkingtest.github.io/Agent-Benchmarks/README_zh.html) - * 开发指南 -* [工程编译指南](cn/How-to-build-CN.md) -* [插件开发指南](cn/Plugin-Development-Guide-CN.md) -* 交互协议 -* [Cross Process Propagation Headers Protocol, v1.0 跨进程追踪上下文传递协议](cn/Skywalking-Cross-Process-Propagation-Headers-Protocol-CN-v1.md) -* [SkyWalking Trace Data Protocol 探针与Collector间网络协议](cn/Trace-Data-Protocol-CN.md) - * [Roadmap](ROADMAP.md) - * 社区提供的共享资源 -* [公开演讲](https://github.com/OpenSkywalking/Community#public-speakings) -* [视频](https://github.com/OpenSkywalking/Community#videos) -* [文章](https://github.com/OpenSkywalking/Community#articles) - * FAQ -* [Trace查询有数据，但是没有拓扑图和JVM数据?](cn/FAQ/Why-have-traces-no-others-CN.md) -* [加载探针，Console被GRPC日志刷屏](cn/FAQ/Too-many-gRPC-logs-CN.md) -* [Kafka消息消费端链路断裂](cn/FAQ/Kafka-plugin-CN.md) +## 中文文档 +[](README.md) + + * 快速入门 +* [快速入门](cn/Quick-start-CN.md) +* [中间件，框架与类库支持列表](Supported-list.md) +* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md) +* [可选插件](cn/Optional-plugins-CN.md) + * 高级特性 +* [通过系统启动参数进行覆盖配置](cn/Setting-override-CN.md) +* [服务直连(Direct uplink)及禁用名称服务(naming service)](cn/Direct-uplink-CN.md) +* [开启TLS](cn/TLS-CN.md) +* [命名空间隔离](cn/Namespace-CN.md) +* [基于Token认证](cn/Token-auth-CN.md) +* [使用Shardingjdbc作为存储实现](cn/Shardingjdbc-CN.md) Review comment: File name should not be shardingJDBC. Should be: Use-ShardingJDBC-as-storage-implementor.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187851353 ## File path: apm-collector/apm-collector-boot/src/main/resources/application.yml ## @@ -1,84 +1,90 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -#cluster: -# zookeeper: -#hostPort: localhost:2181 -#sessionTimeout: 10 -naming: - jetty: -host: localhost -port: 10800 -contextPath: / -cache: -# guava: - caffeine: -remote: - gRPC: -host: localhost -port: 11800 -agent_gRPC: - gRPC: -host: localhost -port: 11800 -#Set these two setting to open ssl -#sslCertChainFile: $path -#sslPrivateKeyFile: $path - -#Set your own token to active auth -#authentication: xx -agent_jetty: - jetty: -host: localhost -port: 12800 -contextPath: / -analysis_register: - default: -analysis_jvm: - default: -analysis_segment_parser: - default: -bufferFilePath: ../buffer/ -bufferOffsetMaxFileSize: 10M -bufferSegmentMaxFileSize: 500M -ui: - jetty: -host: localhost -port: 12800 -contextPath: / -storage: - elasticsearch: -clusterName: CollectorDBCluster -clusterTransportSniffer: true -clusterNodes: localhost:9300 -indexShardsNumber: 2 -indexReplicasNumber: 0 -highPerformanceMode: true -ttl: 7 -#storage: -# h2: -#url: jdbc:h2:~/memorydb -#userName: sa -configuration: - default: -# namespace: x -applicationApdexThreshold: 2000 -serviceErrorRateThreshold: 10.00 -serviceAverageResponseTimeThreshold: 2000 -instanceErrorRateThreshold: 10.00 -instanceAverageResponseTimeThreshold: 2000 -applicationErrorRateThreshold: 10.00 +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#cluster: +# zookeeper: +#hostPort: localhost:2181 +#sessionTimeout: 10 +naming: + jetty: +host: localhost +port: 10800 +contextPath: / +cache: +# guava: + caffeine: +remote: + gRPC: +host: localhost +port: 11800 +agent_gRPC: + gRPC: +host: localhost +port: 11800 +#Set these two setting to open ssl +#sslCertChainFile: $path +#sslPrivateKeyFile: $path + +#Set your own token to active auth +#authentication: xx +agent_jetty: + jetty: +host: localhost +port: 12800 +contextPath: / +analysis_register: + default: +analysis_jvm: + default: +analysis_segment_parser: + default: +bufferFilePath: ../buffer/ +bufferOffsetMaxFileSize: 10M +bufferSegmentMaxFileSize: 500M +ui: + jetty: +host: localhost +port: 12800 +contextPath: / +storage: + elasticsearch: +clusterName: CollectorDBCluster +clusterTransportSniffer: true +clusterNodes: localhost:9300 +indexShardsNumber: 2 +indexReplicasNumber: 0 +highPerformanceMode: true +ttl: 7 +#storage: +# h2: +#url: jdbc:h2:~/memorydb +#userName: sa +#storage: +# shardingjdbc: Review comment: ShardingJDBC is an incubating feature, no use cases yet. And none of the contributors are committer yet. So, by that, please don't put Sharding JDBC in default application.yml. Even it is under comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858505 ## File path: docs/README.md ## @@ -1,45 +1,46 @@ -## Documents -[](README_ZH.md) - - * Getting Started -* [Quick start](en/Quick-start.md) -* [Supported middlewares, frameworks and libraries](Supported-list.md) - * [How to disable plugins?](en/How-to-disable-plugin.md) - * Advanced Features -* [Override settings through System.properties or System.env](en/Setting-override.md) -* [Direct uplink and disable naming discovery](en/Direct-uplink.md) -* [Open TLS](en/TLS.md) -* [Namespace Isolation](en/Namespace.md) -* [Token Authentication](en/Token-auth.md) - * Incubating Features -* Abstract - * Application Toolkit -* [Overview](en/Applicaton-toolkit.md) -* [OpenTracing Tracer](en/Opentracing.md) -* Logging - * [log4j](en/Application-toolkit-log4j-1.x.md) - * [log4j2](en/Application-toolkit-log4j-2.x.md) - * [logback](en/Application-toolkit-logback-1.x.md) -* [Trace](en/Application-toolkit-trace.md) -* [Propagate Context across Thread](en/Application-toolkit-trace-cross-thread.md) - * Testing -* [Plugin Test](https://github.com/SkywalkingTest/agent-integration-test-report) -* [Java Agent Performance Test](https://skywalkingtest.github.io/Agent-Benchmarks/) - * Development Guides -* [How to build project](en/How-to-build.md) -* [Plugin development guide](en/Plugin-Development-Guide.md) -* Protocol - * [Cross Process Propagation Headers Protocol, v1.0](en/Skywalking-Cross-Process-Propagation-Headers-Protocol-v1.md) - * [SkyWalking Trace Data Protocol](en/Trace-Data-Protocol.md) -* [Release Guide](en/How-to-release.md) - * [Roadmap](ROADMAP.md) - * Resources provided by community -* [Public speakings](https://github.com/OpenSkywalking/Community#public-speakings) -* [Videos](https://github.com/OpenSkywalking/Community#videos) -* [Articles](https://github.com/OpenSkywalking/Community#articles) - * FAQ -* [Why only traces in UI?](en/FAQ/Why-have-traces-no-others.md) -* [Too many GRPC logs in the console](en/FAQ/Too-many-gRPC-logs.md) -* [The trace doesn't continue in kafka consumer side](en/FAQ/kafka-plugin.md) -* [Agent or collector version upgrade](en/FAQ/Upgrade.md) - +## Documents +[](README_ZH.md) + + * Getting Started +* [Quick start](en/Quick-start.md) +* [Supported middlewares, frameworks and libraries](Supported-list.md) + * [How to disable plugins?](en/How-to-disable-plugin.md) + * Advanced Features +* [Override settings through System.properties or System.env](en/Setting-override.md) +* [Direct uplink and disable naming discovery](en/Direct-uplink.md) +* [Open TLS](en/TLS.md) +* [Namespace Isolation](en/Namespace.md) +* [Token Authentication](en/Token-auth.md) +* [Open Database Sharding Storage](en/Shardingjdbc.md) Review comment: This should a section in `Incubating Features`. named: `Use Sharding JDBC as storage implementor`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858734 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,13 @@ +# Supported Database Sharding Storage +Beside the default Elasticsearch storage, it also support the database sharding storage, it allow the users to store data in multiple databases. +Note: it only supported MYSQL database sharding, and due to the license restrictions, the users need to import MYSQL Driver manually. + +## Supported version +5.0.0-beta + + +## Requirement +- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to collector-libs directory. Review comment: `collector-libs` is not the directory name. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858208 ## File path: apm-dist/release-docs/LICENSE ## @@ -255,6 +256,7 @@ The text of each license is also included at licenses/LICENSE-[project].txt. Apache: commons-configuration 1.8: https://github.com/apache/commons-configuration, Apache 2.0 Apache: commons-io 2.4: https://github.com/apache/commons-io, Apache 2.0 Apache: tomcat 8.5.27: https://github.com/apache/tomcat/tree/trunk, Apache 2.0 +Apache: groovy 2.4.5-indy: https://github.com/apache/groovy, Apache 2.0 Review comment: Groovy has a NOTICE file. Please change NOTICE in same folder. And follow the file structure. Ref here: https://github.com/apache/groovy/blob/master/NOTICE This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858863 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,13 @@ +# Supported Database Sharding Storage +Beside the default Elasticsearch storage, it also support the database sharding storage, it allow the users to store data in multiple databases. +Note: it only supported MYSQL database sharding, and due to the license restrictions, the users need to import MYSQL Driver manually. + +## Supported version +5.0.0-beta + + +## Requirement +- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to collector-libs directory. +- In config/application.yml, close the elasticsearch configuration and open the shardingjdbc configuration, multiple data source configurations should be separated by Half Comma. Review comment: Considering the sharding settings have been remove from application.yml. please add the settings in here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
