[GitHub] wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender

2018-05-18 Thread GitBox
wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender
URL: 
https://github.com/apache/incubator-skywalking/issues/1241#issuecomment-390366163
 
 
   Yes, we didn't want any uncertain influence to end user. So, manual setting 
is better.
   
   BTW, look like your team or company is using the project, can you submit 
your user case to the project?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender

2018-05-17 Thread GitBox
wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender
URL: 
https://github.com/apache/incubator-skywalking/issues/1241#issuecomment-390110947
 
 
   > Ok, maybe should put traceId in MDC to support Async
   
   Yes. I just don't use MDC often. But you can do that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender

2018-05-17 Thread GitBox
wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender
URL: 
https://github.com/apache/incubator-skywalking/issues/1241#issuecomment-390110244
 
 
   `AsyncAppender ` is definitely a total different story.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender

2018-05-17 Thread GitBox
wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender
URL: 
https://github.com/apache/incubator-skywalking/issues/1241#issuecomment-390110357
 
 
   And I will tag this as `enhancement`, because I didn't support that. before.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services