[GitHub] wu-sheng commented on issue #1287: kafka exception

2018-06-03 Thread GitBox
wu-sheng commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394149802 Could we close this issue? Or do you want to discuss optional kafka plugin? This is an

[GitHub] wu-sheng commented on issue #1287: kafka exception

2018-06-03 Thread GitBox
wu-sheng commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394145372 So, you should understand @ascrutae PR is not for supporting 0.10, is for avoiding exception in log. 0.10 kafka is still not under tracing.

[GitHub] wu-sheng commented on issue #1287: kafka exception

2018-06-03 Thread GitBox
wu-sheng commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394145285 I think there is no good way to trace kafka 0.10, if we don't do some assumptions or set some rules. No kafka header, no way to propagation. If