[GitHub] zone1511 commented on issue #325: Support config downstream from collector
zone1511 commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386763046 Because some plugin needs dynamic configuration. For agent configuration pushing. It needs to provide several functions - able to push config to agent when agent startup - support on the fly pushing config to connected agent - agent side support config change event listener - agent should be able to dispatch plugin specific config to particular plugin From UI side, need to provide a way for user to input the agent/plugin config Sent from my iPhone > On 4 May 2018, at 10:44 AM, 吴晟 Wu Sheng wrote: > > Why do you want to push the setting? Right now, the agent will send VM info every second, I think it is good enough. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zone1511 commented on issue #325: Support config downstream from collector
zone1511 commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386491721 One concern is if we could actively push the config. Instead of waiting for agent request and send back a response. Sent from my iPhone > On 4 May 2018, at 9:10 AM, 吴晟 Wu Sheng wrote: > > The idea is very simple. Every gRPC service has a Downstream response, of course it is NOTHING in it for now. So if the backend could provide a feature to set some settings of commands, you could use this response to send to client. At last,, client agent watches the downstream response, and react what it says. > > The idea is easy, but the process is complex. Do you want to contribute this? If so, we have to set several milestone to make the feature provided. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zone1511 commented on issue #325: Support config downstream from collector
zone1511 commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386491286 I’m interested to provide if I have more detail. Right now I use another framework to push config to agent which make the whole deployment very complicated Sent from my iPhone > On 4 May 2018, at 9:10 AM, 吴晟 Wu Sheng wrote: > > The idea is very simple. Every gRPC service has a Downstream response, of course it is NOTHING in it for now. So if the backend could provide a feature to set some settings of commands, you could use this response to send to client. At last,, client agent watches the downstream response, and react what it says. > > The idea is easy, but the process is complex. Do you want to contribute this? If so, we have to set several milestone to make the feature provided. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zone1511 commented on issue #325: Support config downstream from collector
zone1511 commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386481233 Do you have rough idea how it can be implement? Does the existing agent to collector protocol allows downstream communication? Sent from my iPhone > On 4 May 2018, at 6:01 AM, 吴晟 Wu Sheng wrote: > > it is to be decided. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zone1511 commented on issue #325: Support config downstream from collector
zone1511 commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386361955 @wu-sheng what is the direction for implementing config downstream? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services