Re: [PR] Replace '.' to '_' at OTEL metrics attributes. [skywalking]

2024-04-23 Thread via GitHub
wankai123 commented on PR #12152: URL: https://github.com/apache/skywalking/pull/12152#issuecomment-2071849065 let me check the impacts later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Replace '.' to '_' at OTEL metrics attributes. [skywalking]

2024-04-23 Thread via GitHub
yswdqz opened a new pull request, #12152: URL: https://github.com/apache/skywalking/pull/12152 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

Re: [PR] Replace '.' to '_' at OTEL metrics attributes [skywalking]

2024-04-23 Thread via GitHub
yswdqz closed pull request #12149: Replace '.' to '_' at OTEL metrics attributes URL: https://github.com/apache/skywalking/pull/12149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Replace '.' to '_' at OTEL metrics attributes [skywalking]

2024-04-23 Thread via GitHub
wu-sheng commented on PR #12149: URL: https://github.com/apache/skywalking/pull/12149#issuecomment-2071747585 Please use a new branch. Your commits are most irrelevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Replace '.' to '_' at OTEL metrics attributes [skywalking]

2024-04-23 Thread via GitHub
yswdqz opened a new pull request, #12149: URL: https://github.com/apache/skywalking/pull/12149 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`