Re: [I] [Bug] Trace disconnection between RabbitMQ producer/consumer & incomplete consumer trace stack (unresolved historical issues) [skywalking]
wu-sheng closed issue #13720: [Bug] Trace disconnection between RabbitMQ producer/consumer & incomplete consumer trace stack (unresolved historical issues) URL: https://github.com/apache/skywalking/issues/13720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Bug] Trace disconnection between RabbitMQ producer/consumer & incomplete consumer trace stack (unresolved historical issues) [skywalking]
liuhaolong10 commented on issue #13720: URL: https://github.com/apache/skywalking/issues/13720#issuecomment-4018125997 Through my tests, I found that the current method instrumentation in the RabbitMQ plugin can collect messages consumed by the native amqp-client, but cannot collect messages consumed by spring-rabbit using the @RabbitListener annotation. Therefore, I have added a new spring-rabbit plugin, and modified the code of the original RabbitMQ plugin to avoid data collection conflicts between these two plugins. I will submit the code following the official plugin development guidelines later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Bug] Trace disconnection between RabbitMQ producer/consumer & incomplete consumer trace stack (unresolved historical issues) [skywalking]
wu-sheng commented on issue #13720: URL: https://github.com/apache/skywalking/issues/13720#issuecomment-3983763327 - https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/rocketmq-scenario - https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/rocketmq-5-grpc-scenario Two rocketMQ cases exist. They are not stable, maybe you found the reason. You could learn how to run this test via this doc, https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/plugin-test/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Bug] Trace disconnection between RabbitMQ producer/consumer & incomplete consumer trace stack (unresolved historical issues) [skywalking]
liuhaolong10 commented on issue #13720: URL: https://github.com/apache/skywalking/issues/13720#issuecomment-3983302469 After troubleshooting, I found that the old RabbitMQ instrumentation is executed in a dedicated thread pool for RabbitMQ message processing, which is not the same thread where the consumer runs the real business logic. Because of this, the old instrumentation can only capture that a message was consumed, but cannot continue tracing the subsequent business traces such as database or Redis operations. In my opinion, this old instrumentation is no longer meaningful. I suggest removing the old instrumentation code and its related unit tests, and replacing them with the new instrumentation logic I have implemented. I have already written the unit tests for the new instrumentation. Since I have not maintained the SkyWalking Java agent before, I would appreciate it if you could review the code I will submit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Bug] Trace disconnection between RabbitMQ producer/consumer & incomplete consumer trace stack (unresolved historical issues) [skywalking]
wu-sheng commented on issue #13720: URL: https://github.com/apache/skywalking/issues/13720#issuecomment-3982826152 Note, we already have plugin tests for it. So, the old one maybe work for some cases, but not the cases you used. You need to update test-scenarios of plugin when you submit a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Bug] Trace disconnection between RabbitMQ producer/consumer & incomplete consumer trace stack (unresolved historical issues) [skywalking]
liuhaolong10 commented on issue #13720: URL: https://github.com/apache/skywalking/issues/13720#issuecomment-3982810261 Yes, I have identified the root cause. The original instrumentation method in the RabbitMQ plugin does not work correctly. I have replaced it with a new instrumentation method, which can now resolve the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Bug] Trace disconnection between RabbitMQ producer/consumer & incomplete consumer trace stack (unresolved historical issues) [skywalking]
wu-sheng commented on issue #13720: URL: https://github.com/apache/skywalking/issues/13720#issuecomment-3982702704 As you mentioned, you will submit a pull request, have you already found the cause? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
