Re: [I] [Feature] support jedis-5.x [skywalking]
wu-sheng commented on issue #11747: URL: https://github.com/apache/skywalking/issues/11747#issuecomment-4213135705 Jedis 5.x support has been added in apache/skywalking-java#803. The Jedis 4.x plugin is fully API-compatible with Jedis 5.x — all intercepted classes (`Connection`, `Pipeline`, `Transaction`, `ConnectionProvider`) and methods are unchanged. The plugin was silently not activating on 5.x because the witness method `Pipeline.persist(1 arg)` moved from `Pipeline` to parent `PipeliningBase` in 5.x. Fix: changed the witness to `Connection.executeCommand(1 arg)` which exists in both 4.x and 5.x but not in 3.x. Locally verified: Jedis 5.2.0 passed all test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Feature] support jedis-5.x [skywalking]
wu-sheng commented on issue #11747: URL: https://github.com/apache/skywalking/issues/11747#issuecomment-1884391630 No one is working on that. That is only thing I can say. No timeline, maybe tomorrow submit a pull request, maybe 1-2 years. No one knows. Like I said, this is not how SkyWalking works. This is not a work for anyone, including me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Feature] support jedis-5.x [skywalking]
luger1990 commented on issue #11747: URL: https://github.com/apache/skywalking/issues/11747#issuecomment-1884389003 > What do you mean my team? In a community, there is nothing about my team. SkyWalking doesn't work in this way. I want to know when will support jedis-5.x, i will roll back to use jedis-4.x if it take a long time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Feature] support jedis-5.x [skywalking]
wu-sheng commented on issue #11747: URL: https://github.com/apache/skywalking/issues/11747#issuecomment-1884383583 What do you mean my team? In a community, there is nothing about my team. SkyWalking doesn't work in this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Feature] support jedis-5.x [skywalking]
luger1990 commented on issue #11747: URL: https://github.com/apache/skywalking/issues/11747#issuecomment-1884381710 > We are open to new plugin contributions. If you want to submit a new one, welcome. But for issue tracker, unless you are going to submit one in short term, we wouldn't keep this one open. Too many kind of requests could be opened. It is hard to follow. Do your team have any time plan for release the new plugin? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Feature] support jedis-5.x [skywalking]
wu-sheng closed issue #11747: [Feature] support jedis-5.x URL: https://github.com/apache/skywalking/issues/11747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [Feature] support jedis-5.x [skywalking]
wu-sheng commented on issue #11747: URL: https://github.com/apache/skywalking/issues/11747#issuecomment-1884285601 We are open to new plugin contributions. If you want to submit a new one, welcome. But for issue tracker, unless you are going to submit one in short term, we wouldn't keep this one open. Too many kind of requests could be opened. It is hard to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
