Re: [PR] Add Rover Istio test case [skywalking-banyandb]
hanahmily merged PR #1008: URL: https://github.com/apache/skywalking-banyandb/pull/1008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Rover Istio test case [skywalking-banyandb]
hanahmily commented on PR #1008: URL: https://github.com/apache/skywalking-banyandb/pull/1008#issuecomment-4053177528 > It seems skip still works. Skipping fodc makes sense. My change made the CI pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Rover Istio test case [skywalking-banyandb]
wu-sheng commented on PR #1008: URL: https://github.com/apache/skywalking-banyandb/pull/1008#issuecomment-4052914606 It seems skip still works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Rover Istio test case [skywalking-banyandb]
hanahmily commented on PR #1008:
URL:
https://github.com/apache/skywalking-banyandb/pull/1008#issuecomment-4052408177
> https://private-user-images.githubusercontent.com/5441976/562677906-0a29d0a2-2a30-40cc-9bc8-de38ce4790ed.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzMzNzMzMjMsIm5iZiI6MTc3MzM3MzAyMywicGF0aCI6Ii81NDQxOTc2LzU2MjY3NzkwNi0wYTI5ZDBhMi0yYTMwLTQwY2MtOWJjOC1kZTM4Y2U0NzkwZWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDMxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAzMTNUMDMzNzAzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWUyYzNmMDhiMzZkYWE4ZTNmMTY4NjIwY2I5OTY1ZjJiZTg3MTVjYWZlYjk3YjBiNjIwMjQ5YjYxODE0NzYxNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.TJuO-CiF-GRWorcmwtqMh-LLVG9mRroBlzSNumLZP2k";>
> Two skipped which is unexpected.
FODC is skipped because this changes only e2e/rover-related paths, which
don’t trigger the FODC path filter
```
if: ${{ github.event_name != 'pull_request' ||
needs.detect_fodc_e2e_changes.outputs.should_run == 'true' }}
needs: [check, detect_fodc_e2e_changes]
```
CI is skipped because it depends on test-fodc-e2e, which was skipped. I will
turn it run even fodc is skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add Rover Istio test case [skywalking-banyandb]
wu-sheng commented on PR #1008: URL: https://github.com/apache/skywalking-banyandb/pull/1008#issuecomment-4051869388 https://github.com/user-attachments/assets/0a29d0a2-2a30-40cc-9bc8-de38ce4790ed"; /> Two skipped which is unexpected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
