Re: [PR] Fix stream startup warning [skywalking-banyandb]

2024-01-24 Thread via GitHub
hanahmily merged PR #378: URL: https://github.com/apache/skywalking-banyandb/pull/378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix stream startup warning [skywalking-banyandb]

2024-01-23 Thread via GitHub
wu-sheng commented on PR #378: URL: https://github.com/apache/skywalking-banyandb/pull/378#issuecomment-1907477063 CI fails. Please recheck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix stream startup warning [skywalking-banyandb]

2024-01-23 Thread via GitHub
hanahmily commented on code in PR #378: URL: https://github.com/apache/skywalking-banyandb/pull/378#discussion_r1464340894 ## banyand/stream/tstable.go: ## @@ -180,6 +180,9 @@ func newTSTable(fileSystem fs.FileSystem, rootPath string, p common.Position, var

Re: [PR] Fix stream startup warning [skywalking-banyandb]

2024-01-23 Thread via GitHub
codecov-commenter commented on PR #378: URL: https://github.com/apache/skywalking-banyandb/pull/378#issuecomment-1907286492 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/378?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)