Re: [PR] Fix stream startup warning [skywalking-banyandb]
hanahmily merged PR #378: URL: https://github.com/apache/skywalking-banyandb/pull/378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix stream startup warning [skywalking-banyandb]
wu-sheng commented on PR #378: URL: https://github.com/apache/skywalking-banyandb/pull/378#issuecomment-1907477063 CI fails. Please recheck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix stream startup warning [skywalking-banyandb]
hanahmily commented on code in PR #378:
URL:
https://github.com/apache/skywalking-banyandb/pull/378#discussion_r1464340894
##
banyand/stream/tstable.go:
##
@@ -180,6 +180,9 @@ func newTSTable(fileSystem fs.FileSystem, rootPath string,
p common.Position,
var needToDelete []string
for i := range ee {
if ee[i].IsDir() {
+ if ee[i].Name() == "element_idx" {
Review Comment:
You should exclude directories that do not start with "part-". If any
directories do not meet this criterion, the condition will not be satisfied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix stream startup warning [skywalking-banyandb]
codecov-commenter commented on PR #378: URL: https://github.com/apache/skywalking-banyandb/pull/378#issuecomment-1907286492 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/378?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`93408dc`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/93408dc3ddf8e5039d1cf6a9c5cb0764dfa87b5c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 47.10% compared to head [(`70139d8`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/378?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 47.01%. Additional details and impacted files ```diff @@Coverage Diff @@ ## main #378 +/- ## == - Coverage 47.10% 47.01% -0.09% == Files 171 171 Lines 2120421206 +2 == - Hits 9988 9971 -17 - Misses 1037910396 +17 - Partials 837 839 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/378?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
