[GitHub] rohanagg opened a new issue #5182: Changed of Date to epoch time in Table view - Superset - 0.25.6

2018-06-12 Thread GitBox
rohanagg opened a new issue #5182: Changed of Date to epoch time in Table view - Superset - 0.25.6 URL: https://github.com/apache/incubator-superset/issues/5182 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for pyt

[GitHub] rohanagg commented on issue #5170: Missing Metric names that were created on Superset

2018-06-12 Thread GitBox
rohanagg commented on issue #5170: Missing Metric names that were created on Superset URL: https://github.com/apache/incubator-superset/issues/5170#issuecomment-396491734 Issue is resolved. I had again updated the superset version --

[GitHub] liyuance opened a new pull request #5183: fetch datasources from broker endpoint when refresh new datasources

2018-06-12 Thread GitBox
liyuance opened a new pull request #5183: fetch datasources from broker endpoint when refresh new datasources URL: https://github.com/apache/incubator-superset/pull/5183 We should fetch all datasources from broker endpoint when refresh new datasources. Otherwise superset will not scan o

[GitHub] codecov-io commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources

2018-06-12 Thread GitBox
codecov-io commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources URL: https://github.com/apache/incubator-superset/pull/5183#issuecomment-396507953 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5183?src=pr&el=h1) Report > Merg

[GitHub] codecov-io commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources

2018-06-12 Thread GitBox
codecov-io commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources URL: https://github.com/apache/incubator-superset/pull/5183#issuecomment-396507953 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5183?src=pr&el=h1) Report > Merg

[GitHub] MTShannon commented on issue #3013: New chart type : Chord Diagrams

2018-06-12 Thread GitBox
MTShannon commented on issue #3013: New chart type : Chord Diagrams URL: https://github.com/apache/incubator-superset/pull/3013#issuecomment-396598585 Have the file locations changed? I can't find "controls.jsx" in the stores folder. ---

[GitHub] ledor473 opened a new pull request #5184: Pin botocore version

2018-06-12 Thread GitBox
ledor473 opened a new pull request #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184 Fixes for #5175 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] codecov-io commented on issue #5184: Pin botocore version

2018-06-12 Thread GitBox
codecov-io commented on issue #5184: Pin botocore version URL: https://github.com/apache/incubator-superset/pull/5184#issuecomment-396614071 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5184?src=pr&el=h1) Report > Merging [#5184](https://codecov.io/gh/apache/incuba

[GitHub] mistercrunch commented on issue #5178: [wip][sql] Correct SQL parameter formatting

2018-06-12 Thread GitBox
mistercrunch commented on issue #5178: [wip][sql] Correct SQL parameter formatting URL: https://github.com/apache/incubator-superset/pull/5178#issuecomment-396632460 Very bice. Happy to see this as `read_sql` has been getting in the way of getting consistency across SQL Lab & charts. --

[GitHub] mistercrunch commented on a change in pull request #5183: fetch datasources from broker endpoint when refresh new datasources

2018-06-12 Thread GitBox
mistercrunch commented on a change in pull request #5183: fetch datasources from broker endpoint when refresh new datasources URL: https://github.com/apache/incubator-superset/pull/5183#discussion_r194785964 ## File path: superset/connectors/druid/models.py ## @@ -126,14

[GitHub] john-bodley commented on issue #5178: [wip][sql] Correct SQL parameter formatting

2018-06-12 Thread GitBox
john-bodley commented on issue #5178: [wip][sql] Correct SQL parameter formatting URL: https://github.com/apache/incubator-superset/pull/5178#issuecomment-396649643 @mistercruch this still needs some work due to the percent escaping. I hope to update the logic and descruption later today

[GitHub] jasnovak commented on issue #5172: Filters not saved when visualization changed

2018-06-12 Thread GitBox
jasnovak commented on issue #5172: Filters not saved when visualization changed URL: https://github.com/apache/incubator-superset/issues/5172#issuecomment-396659015 I was informed that this commit is what caused the issue: https://github.com/apache/incubator-superset/pull/4909 ---

[GitHub] Lynnlan commented on issue #2394: Metric should offer a new "Legend Name" attribute

2018-06-12 Thread GitBox
Lynnlan commented on issue #2394: Metric should offer a new "Legend Name" attribute URL: https://github.com/apache/incubator-superset/issues/2394#issuecomment-396678721 +1 This is an automated message from the Apache Git Ser

[GitHub] codecov-io commented on issue #5179: [Tests] Adding column to test data only if it doesn't already exist

2018-06-12 Thread GitBox
codecov-io commented on issue #5179: [Tests] Adding column to test data only if it doesn't already exist URL: https://github.com/apache/incubator-superset/pull/5179#issuecomment-396680726 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5179?src=pr&el=h1) Report > Merg

[GitHub] codecov-io commented on issue #5179: [Tests] Adding column to test data only if it doesn't already exist

2018-06-12 Thread GitBox
codecov-io commented on issue #5179: [Tests] Adding column to test data only if it doesn't already exist URL: https://github.com/apache/incubator-superset/pull/5179#issuecomment-396680726 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5179?src=pr&el=h1) Report > Merg

[GitHub] john-bodley commented on issue #5178: [wip][sql] Correct SQL parameter formatting

2018-06-12 Thread GitBox
john-bodley commented on issue #5178: [wip][sql] Correct SQL parameter formatting URL: https://github.com/apache/incubator-superset/pull/5178#issuecomment-396649643 @mistercruch this still needs some work due to the percent escaping. I hope to update the logic and descruption later today

[GitHub] leorochael closed pull request #4631: Fix flower broker configuration

2018-06-12 Thread GitBox
leorochael closed pull request #4631: Fix flower broker configuration URL: https://github.com/apache/incubator-superset/pull/4631 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreig

[GitHub] leorochael commented on issue #4631: Fix flower broker configuration

2018-06-12 Thread GitBox
leorochael commented on issue #4631: Fix flower broker configuration URL: https://github.com/apache/incubator-superset/pull/4631#issuecomment-396694718 The `cli` one is not actually an import from `sql_lab` but it is true that `sql_lab` is the only place other than `cli` that uses `get_cel

[GitHub] john-bodley closed pull request #5167: [migrations] Cleaning up migration logic

2018-06-12 Thread GitBox
john-bodley closed pull request #5167: [migrations] Cleaning up migration logic URL: https://github.com/apache/incubator-superset/pull/5167 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[GitHub] john-bodley closed pull request #5155: [migrations] Cleanup recent migrations

2018-06-12 Thread GitBox
john-bodley closed pull request #5155: [migrations] Cleanup recent migrations URL: https://github.com/apache/incubator-superset/pull/5155 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] pauldx commented on issue #4394: Implement the column config and row config in pivot table

2018-06-12 Thread GitBox
pauldx commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-396703637 @xiaohanyu Hi , Like the new PR. Any ETA when and what Superset release will have it ? thanks and good work . - Pau

[GitHub] mstump commented on issue #5180: Can't add table with more than 1000 columns

2018-06-12 Thread GitBox
mstump commented on issue #5180: Can't add table with more than 1000 columns URL: https://github.com/apache/incubator-superset/issues/5180#issuecomment-396705433 Three resolutions exist: 1. Modify superset metadata query so that select statement is split across several sub-queries keepi

[GitHub] pauldx opened a new issue #5185: Ability to change the Grey Color in FilterBox visulalization on click

2018-06-12 Thread GitBox
pauldx opened a new issue #5185: Ability to change the Grey Color in FilterBox visulalization on click URL: https://github.com/apache/incubator-superset/issues/5185 Make sure these boxes are checked before submitting your issue - thank you! - [ x] I have checked the superset logs for

[GitHub] betodealmeida commented on issue #5177: Time shift difference

2018-06-12 Thread GitBox
betodealmeida commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396713012 > I think this is effectively the same as a superior Period Ratio isn't it? If so we should db migrate to translate the slices. I'm not fa

[GitHub] codecov-io commented on issue #5178: [sql] Correct SQL parameter formatting

2018-06-12 Thread GitBox
codecov-io commented on issue #5178: [sql] Correct SQL parameter formatting URL: https://github.com/apache/incubator-superset/pull/5178#issuecomment-396741949 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5178?src=pr&el=h1) Report > Merging [#5178](https://codecov.

[GitHub] vylc commented on issue #5177: Time shift difference

2018-06-12 Thread GitBox
vylc commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396756922 Some updates to the AA section to improve usability https://user-images.githubusercontent.com/33429480/41320960-a81df5ea-6e56-11e8-8fdc-9b4b62c1bbe6.png

[GitHub] jake-barry commented on issue #4666: Sessions still active on Datasource

2018-06-12 Thread GitBox
jake-barry commented on issue #4666: Sessions still active on Datasource URL: https://github.com/apache/incubator-superset/issues/4666#issuecomment-396764179 This issue, at least I think that it is the same issue, seems to still be open in 0.25.6. To reproduce, query: select count(*) fro

[GitHub] john-bodley commented on a change in pull request #5178: [sql] Correct SQL parameter formatting

2018-06-12 Thread GitBox
john-bodley commented on a change in pull request #5178: [sql] Correct SQL parameter formatting URL: https://github.com/apache/incubator-superset/pull/5178#discussion_r194939505 ## File path: superset/models/core.py ## @@ -706,15 +703,36 @@ def needs_conversion(df_series

[GitHub] liyuance commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources

2018-06-12 Thread GitBox
liyuance commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources URL: https://github.com/apache/incubator-superset/pull/5183#issuecomment-396795373 @mistercrunch Fine, I have updated this PR, please review again, Thx --

[GitHub] liyuance commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources

2018-06-12 Thread GitBox
liyuance commented on issue #5183: fetch datasources from broker endpoint when refresh new datasources URL: https://github.com/apache/incubator-superset/pull/5183#issuecomment-396800721 @mistercrunch Hi, I am confused about the "check failed" on test_urls, why cluster.get_base_broker_ur

[GitHub] mistercrunch opened a new pull request #5186: [WiP] a React-based table editor

2018-06-12 Thread GitBox
mistercrunch opened a new pull request #5186: [WiP] a React-based table editor URL: https://github.com/apache/incubator-superset/pull/5186 ![](http://g.recordit.co/L8PHZpeshE.gif) TODO: * add button/logic to pull and refresh columns from database * test/tune with Druid * ensu

[GitHub] mistercrunch opened a new pull request #5187: Repoint .istambul.yml to the right location

2018-06-12 Thread GitBox
mistercrunch opened a new pull request #5187: Repoint .istambul.yml to the right location URL: https://github.com/apache/incubator-superset/pull/5187 Never did this when I renamed the folder. `npm run cover` currently doesn't generate a proper coverage report, this fixes it

[GitHub] codecov-io commented on issue #5187: Repoint .istambul.yml to the right location

2018-06-12 Thread GitBox
codecov-io commented on issue #5187: Repoint .istambul.yml to the right location URL: https://github.com/apache/incubator-superset/pull/5187#issuecomment-396821190 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5187?src=pr&el=h1) Report > Merging [#5187](https://code

[GitHub] pexpert9 commented on issue #533: Caravel with HTTPS in gunicorn

2018-06-12 Thread GitBox
pexpert9 commented on issue #533: Caravel with HTTPS in gunicorn URL: https://github.com/apache/incubator-superset/issues/533#issuecomment-396832674 Hi, 1. How can i set SSL certificate files setting in gunicorn ? 2. Is any specific command or file for SSL configuration, If yes pleas

[GitHub] ajgil opened a new issue #5188: Bullet chart unhashable type: 'dict'

2018-06-12 Thread GitBox
ajgil opened a new issue #5188: Bullet chart unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/5188 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it