[GitHub] [incubator-superset] serenajiang opened a new pull request #8139: [sqllab] add retries for stop_query

2019-08-29 Thread GitBox
serenajiang opened a new pull request #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ]

[GitHub] [incubator-superset] kristw opened a new pull request #8140: remove unused files

2019-08-29 Thread GitBox
kristw opened a new pull request #8140: remove unused files URL: https://github.com/apache/incubator-superset/pull/8140 ### CATEGORY Choose one - [X] Build / Development Environment ### SUMMARY These files were migrated to `@superset-ui` and no longer used.

[GitHub] [incubator-superset] codecov-io commented on issue #8140: remove unused files

2019-08-29 Thread GitBox
codecov-io commented on issue #8140: remove unused files URL: https://github.com/apache/incubator-superset/pull/8140#issuecomment-526075770 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8140?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password

2019-08-29 Thread GitBox
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their

[GitHub] [incubator-superset] Giuzzilla commented on issue #2731: Give users the rights to change their password

2019-08-29 Thread GitBox
Giuzzilla commented on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their own

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8139: [sqllab] add retries for stop_query

2019-08-29 Thread GitBox
codecov-io edited a comment on issue #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139#issuecomment-526066743 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] syazwan0913 opened a new issue #8141: What is the CSV file limit size for upload?

2019-08-29 Thread GitBox
syazwan0913 opened a new issue #8141: What is the CSV file limit size for upload? URL: https://github.com/apache/incubator-superset/issues/8141 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] malazbw opened a new issue #8142: Normal_distribution over bar chart

2019-08-29 Thread GitBox
malazbw opened a new issue #8142: Normal_distribution over bar chart URL: https://github.com/apache/incubator-superset/issues/8142 Hi, is it possible, to draw normal_distribution over barchart by sperset ? This is

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8142: Normal_distribution over bar chart

2019-08-29 Thread GitBox
issue-label-bot[bot] commented on issue #8142: Normal_distribution over bar chart URL: https://github.com/apache/incubator-superset/issues/8142#issuecomment-526132287 Issue Label Bot is not confident enough to auto-label this issue. See

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8141: What is the CSV file limit size for upload?

2019-08-29 Thread GitBox
issue-label-bot[bot] commented on issue #8141: What is the CSV file limit size for upload? URL: https://github.com/apache/incubator-superset/issues/8141#issuecomment-526105567 Issue Label Bot is not confident enough to auto-label this issue. See

[GitHub] [incubator-superset] request-info[bot] commented on issue #8141: What is the CSV file limit size for upload?

2019-08-29 Thread GitBox
request-info[bot] commented on issue #8141: What is the CSV file limit size for upload? URL: https://github.com/apache/incubator-superset/issues/8141#issuecomment-526105574 We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the `title`

[GitHub] [incubator-superset] syazwan0913 commented on issue #8141: What is the CSV file limit size for upload?

2019-08-29 Thread GitBox
syazwan0913 commented on issue #8141: What is the CSV file limit size for upload? URL: https://github.com/apache/incubator-superset/issues/8141#issuecomment-526105894 Is there any limit for the CSV file size to be uploaded in Superset?

[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password

2019-08-29 Thread GitBox
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their

[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password

2019-08-29 Thread GitBox
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their

[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password

2019-08-29 Thread GitBox
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their

[GitHub] [incubator-superset] klazaj commented on issue #8127: Frontend not built after installing Superset with Docker

2019-08-29 Thread GitBox
klazaj commented on issue #8127: Frontend not built after installing Superset with Docker URL: https://github.com/apache/incubator-superset/issues/8127#issuecomment-526211745 @dpgaspar updated the post with the logs after deleting the image and reinstalling

[GitHub] [incubator-superset] stale[bot] closed pull request #7757: Update druid.rst

2019-08-29 Thread GitBox
stale[bot] closed pull request #7757: Update druid.rst URL: https://github.com/apache/incubator-superset/pull/7757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-superset] smokemonster99 commented on issue #8102: Dashboard filters do not persist on page refresh

2019-08-29 Thread GitBox
smokemonster99 commented on issue #8102: Dashboard filters do not persist on page refresh URL: https://github.com/apache/incubator-superset/issues/8102#issuecomment-52621 Yes but this does not work on v0.26.3. This is

[GitHub] [incubator-superset] etr2460 opened a new pull request #8143: [Codemod] Rename react unsafe lifecycles

2019-08-29 Thread GitBox
etr2460 opened a new pull request #8143: [Codemod] Rename react unsafe lifecycles URL: https://github.com/apache/incubator-superset/pull/8143 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ]

[GitHub] [incubator-superset] codecov-io commented on issue #8139: [sqllab] add retries for stop_query

2019-08-29 Thread GitBox
codecov-io commented on issue #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139#issuecomment-526066743 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password

2019-08-29 Thread GitBox
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report >

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report >

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319264510 ## File path: superset/common/query_object.py ## @@ -34,12 +35,28 @@

[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items

2019-08-29 Thread GitBox
ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-526361104 I figured - yeah - it may have just slipped under his radar.

[GitHub] [incubator-superset] kristw merged pull request #8140: remove unused files

2019-08-29 Thread GitBox
kristw merged pull request #8140: remove unused files URL: https://github.com/apache/incubator-superset/pull/8140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-superset] stale[bot] closed pull request #7758: Update gallery.rst

2019-08-29 Thread GitBox
stale[bot] closed pull request #7758: Update gallery.rst URL: https://github.com/apache/incubator-superset/pull/7758 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-superset] betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend

2019-08-29 Thread GitBox
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-526388534 @etr2460, do you want to take another stab at reviewing this? I'm currently working on fixing the failing unit

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319208187 ## File path: superset/common/query_context.py ## @@ -109,17 +114,17

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319210270 ## File path: superset/common/query_object.py ## @@ -34,12 +35,28 @@

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319224456 ## File path: superset/common/query_context.py ## @@ -150,8 +155,8

[GitHub] [incubator-superset] codecov-io commented on issue #8143: [Codemod] Rename react unsafe lifecycles

2019-08-29 Thread GitBox
codecov-io commented on issue #8143: [Codemod] Rename react unsafe lifecycles URL: https://github.com/apache/incubator-superset/pull/8143#issuecomment-526351465 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319220516 ## File path: superset/common/query_object.py ## @@ -34,12 +35,28 @@

[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items

2019-08-29 Thread GitBox
ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-526340562 @dpgaspar / @villebro - what's the process for merging this?

[GitHub] [incubator-superset] villebro commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items

2019-08-29 Thread GitBox
villebro commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-526347785 LGTM, but I don't feel comfortable merging before @dpgaspar approves this, as he is more knowledgeable on

[GitHub] [incubator-superset] serenajiang opened a new pull request #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
serenajiang opened a new pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor

[GitHub] [incubator-superset] serenajiang closed pull request #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
serenajiang closed pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319206814 ## File path: superset/common/query_context.py ## @@ -40,8 +42,13 @@

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319226410 ## File path: superset/common/query_context.py ## @@ -150,8 +155,8 @@

[GitHub] [incubator-superset] villebro commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database

2019-08-29 Thread GitBox
villebro commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database URL: https://github.com/apache/incubator-superset/issues/8074#issuecomment-526344999 Looking more closely at this problem, it seems MSSQL is one of the few engines that

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression

2019-08-29 Thread GitBox
codecov-io edited a comment on issue #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression URL: https://github.com/apache/incubator-superset/pull/8080#issuecomment-526346690 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=h1) Report >

[GitHub] [incubator-superset] codecov-io commented on issue #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression

2019-08-29 Thread GitBox
codecov-io commented on issue #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression URL: https://github.com/apache/incubator-superset/pull/8080#issuecomment-526346690 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] kuckjwi0928 commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard

2019-08-29 Thread GitBox
kuckjwi0928 commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-526408484 Default permissions will be created when superset init is performed. ~~~python def

[GitHub] [incubator-superset] betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend

2019-08-29 Thread GitBox
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-526401610 I added new integration tests, but looks like Travis is not running them. I ran them locally and they passed:

[GitHub] [incubator-superset] codecov-io commented on issue #8060: SIP-23: Persist SQL Lab state in the backend

2019-08-29 Thread GitBox
codecov-io commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-526402924 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io commented on issue #8060: SIP-23: Persist SQL Lab state in the backend

2019-08-29 Thread GitBox
codecov-io commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-526402926 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report >

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common

2019-08-29 Thread GitBox
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report >

[GitHub] [incubator-superset] mistercrunch commented on issue #7611: [sqllab] Cancel database query on stop

2019-08-29 Thread GitBox
mistercrunch commented on issue #7611: [sqllab] Cancel database query on stop URL: https://github.com/apache/incubator-superset/pull/7611#issuecomment-526408890 It'd be great to enable the true killing of queries, sorry I missed this back in May...

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-08-29 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r319344408 ## File path: superset/assets/spec/javascripts/sqllab/reducers/sqlLab_spec.js ## @@

[GitHub] [incubator-superset] mistercrunch merged pull request #8130: removes unused state values and redundant presence checks

2019-08-29 Thread GitBox
mistercrunch merged pull request #8130: removes unused state values and redundant presence checks URL: https://github.com/apache/incubator-superset/pull/8130 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-08-29 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r319344271 ## File path: superset/assets/spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx ## @@

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-08-29 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r319344326 ## File path: superset/assets/spec/javascripts/sqllab/reducers/sqlLab_spec.js ## @@

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-08-29 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r319344608 ## File path: superset/migrations/versions/02f260780a2b_add_tables_for_sql_lab_state.py

[GitHub] [incubator-superset] squalou commented on issue #7406: Pivot table null values in columns

2019-08-29 Thread GitBox
squalou commented on issue #7406: Pivot table null values in columns URL: https://github.com/apache/incubator-superset/issues/7406#issuecomment-526441881 @ngritsuk : since #8040 , apparently the `dropna = False` option disappears enirely from viz.py You may want to check with

[GitHub] [incubator-superset] mistercrunch merged pull request #8136: Add duration formatter for numeric data

2019-08-29 Thread GitBox
mistercrunch merged pull request #8136: Add duration formatter for numeric data URL: https://github.com/apache/incubator-superset/pull/8136 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] villebro commented on issue #8139: [sqllab] add retries for stop_query

2019-08-29 Thread GitBox
villebro commented on issue #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139#issuecomment-526458368 @smacker is this related to #7611 ? This is an automated message from

[GitHub] [incubator-superset] tanmaykul commented on issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component

2019-08-29 Thread GitBox
tanmaykul commented on issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component URL: https://github.com/apache/incubator-superset/issues/8091#issuecomment-526464279 This is done. Closing this issue.

[GitHub] [incubator-superset] tanmaykul closed issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component

2019-08-29 Thread GitBox
tanmaykul closed issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component URL: https://github.com/apache/incubator-superset/issues/8091 This is an automated message from the

[GitHub] [incubator-superset] squalou commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard

2019-08-29 Thread GitBox
squalou commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-526042035 Damn ! indeed. Must have forgotten it. (spent so long restarting different versions,

[GitHub] [incubator-superset] squalou edited a comment on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard

2019-08-29 Thread GitBox
squalou edited a comment on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-526042035 Damn ! indeed. Must have forgotten it. (spent so long restarting different

[GitHub] [incubator-superset] squalou edited a comment on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard

2019-08-29 Thread GitBox
squalou edited a comment on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-526042035 Damn ! indeed. Must have forgotten it. (spent so long restarting different