[GitHub] [incubator-superset] etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

2019-09-20 Thread GitBox
etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533664418 As for the autoflush, I'm not sure why we didn't disable it before, perhaps @mistercrunch can provide some insight

[GitHub] [incubator-superset] etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

2019-09-20 Thread GitBox
etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533663542 I think we'd still want the previous commit in case an exception is raised in the execute function (like not allowing dml

[GitHub] [incubator-superset] KKcorps opened a new pull request #8271: Fix: Missing time series datapoints in druid show up as absurd values in line chart

2019-09-20 Thread GitBox
KKcorps opened a new pull request #8271: Fix: Missing time series datapoints in druid show up as absurd values in line chart URL: https://github.com/apache/incubator-superset/pull/8271 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) -

[GitHub] [incubator-superset] villebro opened a new pull request #8272: Refine release instructions

2019-09-20 Thread GitBox
villebro opened a new pull request #8272: Refine release instructions URL: https://github.com/apache/incubator-superset/pull/8272 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [x] Build /

[GitHub] [incubator-superset] kristw closed issue #8266: Histogram visualization error when using numeric type.

2019-09-20 Thread GitBox
kristw closed issue #8266: Histogram visualization error when using numeric type. URL: https://github.com/apache/incubator-superset/issues/8266 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] villebro commented on issue #6587: Can't upload CSV in Apache Superset

2019-09-20 Thread GitBox
villebro commented on issue #6587: Can't upload CSV in Apache Superset URL: https://github.com/apache/incubator-superset/issues/6587#issuecomment-533703022 Can you provide a short example snippet/csv file that makes it possible to replicate the problem? Would make it much easier to debug.

[GitHub] [incubator-superset] bbhuston commented on issue #6587: Can't upload CSV in Apache Superset

2019-09-20 Thread GitBox
bbhuston commented on issue #6587: Can't upload CSV in Apache Superset URL: https://github.com/apache/incubator-superset/issues/6587#issuecomment-533701095 Bump. I am hitting this as well. Hoping someone has insight into what the culprit is

[GitHub] [incubator-superset] villebro commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

2019-09-20 Thread GitBox
villebro commented on issue #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533710106 I reread the code carefully and brushed up on docs regarding flushing and committing, and I agree, this makes sense, i.e.

[GitHub] [incubator-superset] villebro commented on issue #8183: How to pass time filters to SQL Lab queries

2019-09-20 Thread GitBox
villebro commented on issue #8183: How to pass time filters to SQL Lab queries URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-533713023 Ok, I didn't know that, very interesting. Is there any particular reason for not upgrading? Given this restriction, it feels

[GitHub] [incubator-superset] etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

2019-09-20 Thread GitBox
etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533651389 @villebro There is a commit prior to calling `execute_sql_statement`, but then the query object is potentially modified

[GitHub] [incubator-superset] villebro commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

2019-09-20 Thread GitBox
villebro commented on issue #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533655581 Ah, right you are, my bad. Weird that this hasn't caused more problems over the years. To keep the code clean, perhaps we

[GitHub] [incubator-superset] rubypollev commented on issue #8183: How to pass time filters to SQL Lab queries

2019-09-20 Thread GitBox
rubypollev commented on issue #8183: How to pass time filters to SQL Lab queries URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-533677514 @villebro MySQL 5.6 does not do predicate pushdown for derived tables. ☹️

[GitHub] [incubator-superset] stale[bot] commented on issue #7914: Support for PrestoSQL (https://prestosql.io) instead of PrestoDB

2019-09-20 Thread GitBox
stale[bot] commented on issue #7914: Support for PrestoSQL (https://prestosql.io) instead of PrestoDB URL: https://github.com/apache/incubator-superset/issues/7914#issuecomment-533738374 This issue has been automatically marked as stale because it has not had recent activity. It will be

[GitHub] [incubator-superset] davidhassan commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells

2019-09-20 Thread GitBox
davidhassan commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-533763017 Is someone able to convert these into a plugin. Does this PR help with this? #8222

[GitHub] [incubator-superset] davidhassan edited a comment on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells

2019-09-20 Thread GitBox
davidhassan edited a comment on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-533763017 Is someone able to convert these into a plugin? Does this PR help with this? #8222

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8265: Fixed korean translation error.

2019-09-20 Thread GitBox
dpgaspar commented on a change in pull request #8265: Fixed korean translation error. URL: https://github.com/apache/incubator-superset/pull/8265#discussion_r326560762 ## File path: superset/translations/ko/LC_MESSAGES/messages.po ## @@ -917,4027 +917,3125 @@ msgstr ""

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8265: Fixed korean translation error.

2019-09-20 Thread GitBox
dpgaspar commented on a change in pull request #8265: Fixed korean translation error. URL: https://github.com/apache/incubator-superset/pull/8265#discussion_r326560762 ## File path: superset/translations/ko/LC_MESSAGES/messages.po ## @@ -917,4027 +917,3125 @@ msgstr ""

[GitHub] [incubator-superset] dpgaspar edited a comment on issue #8254: Avoid circular dependency between superset config and superset package

2019-09-20 Thread GitBox
dpgaspar edited a comment on issue #8254: Avoid circular dependency between superset config and superset package URL: https://github.com/apache/incubator-superset/pull/8254#issuecomment-533137242 I would rename `superset/security/security.py` to `superset/security/manager.py`. You

[GitHub] [incubator-superset] dpgaspar edited a comment on issue #8254: Avoid circular dependency between superset config and superset package

2019-09-20 Thread GitBox
dpgaspar edited a comment on issue #8254: Avoid circular dependency between superset config and superset package URL: https://github.com/apache/incubator-superset/pull/8254#issuecomment-533137242 I would rename `superset/security/security.py` to `superset/security/manager.py`. You

[GitHub] [incubator-superset] dpgaspar commented on issue #8254: Avoid circular dependency between superset config and superset package

2019-09-20 Thread GitBox
dpgaspar commented on issue #8254: Avoid circular dependency between superset config and superset package URL: https://github.com/apache/incubator-superset/pull/8254#issuecomment-533495126 Yep, just edited my previous reply

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8268: Fix no data in Presto

2019-09-20 Thread GitBox
codecov-io edited a comment on issue #8268: Fix no data in Presto URL: https://github.com/apache/incubator-superset/pull/8268#issuecomment-533498597 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8268?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io commented on issue #8268: Fix no data in Presto

2019-09-20 Thread GitBox
codecov-io commented on issue #8268: Fix no data in Presto URL: https://github.com/apache/incubator-superset/pull/8268#issuecomment-533498597 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8268?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8268: Fix no data in Presto

2019-09-20 Thread GitBox
codecov-io edited a comment on issue #8268: Fix no data in Presto URL: https://github.com/apache/incubator-superset/pull/8268#issuecomment-533498597 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8268?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] kuckjwi0928 commented on a change in pull request #8265: Fixed korean translation error.

2019-09-20 Thread GitBox
kuckjwi0928 commented on a change in pull request #8265: Fixed korean translation error. URL: https://github.com/apache/incubator-superset/pull/8265#discussion_r326570368 ## File path: superset/translations/ko/LC_MESSAGES/messages.po ## @@ -917,4027 +917,3125 @@ msgstr

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8269: JavaScript heap out of memory when run dev server

2019-09-20 Thread GitBox
issue-label-bot[bot] commented on issue #8269: JavaScript heap out of memory when run dev server URL: https://github.com/apache/incubator-superset/issues/8269#issuecomment-533502118 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.82.

[GitHub] [incubator-superset] lshunran opened a new issue #8269: JavaScript heap out of memory when run dev server

2019-09-20 Thread GitBox
lshunran opened a new issue #8269: JavaScript heap out of memory when run dev server URL: https://github.com/apache/incubator-superset/issues/8269 A clear and concise description of what the bug is. **Sometimes**.when I run npm run dev-server. My JS engine report a error

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8265: Fixed korean translation error.

2019-09-20 Thread GitBox
dpgaspar commented on a change in pull request #8265: Fixed korean translation error. URL: https://github.com/apache/incubator-superset/pull/8265#discussion_r326572679 ## File path: superset/translations/ko/LC_MESSAGES/messages.po ## @@ -917,4027 +917,3125 @@ msgstr ""

[GitHub] [incubator-superset] lshunran commented on issue #8269: JavaScript heap out of memory when run dev server

2019-09-20 Thread GitBox
lshunran commented on issue #8269: JavaScript heap out of memory when run dev server URL: https://github.com/apache/incubator-superset/issues/8269#issuecomment-533504228 when report this error, add parameter --max_old_space_size=4096 would fix it: `"dev-server": "node

[GitHub] [incubator-superset] lshunran opened a new pull request #8270: fix for issue#8269

2019-09-20 Thread GitBox
lshunran opened a new pull request #8270: fix for issue#8269 URL: https://github.com/apache/incubator-superset/pull/8270 ### CATEGORY Choose one - [T] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development

[GitHub] [incubator-superset] codecov-io commented on issue #8270: fix for issue#8269

2019-09-20 Thread GitBox
codecov-io commented on issue #8270: fix for issue#8269 URL: https://github.com/apache/incubator-superset/pull/8270#issuecomment-533507459 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8270?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] kuckjwi0928 commented on a change in pull request #8265: Fixed korean translation error.

2019-09-20 Thread GitBox
kuckjwi0928 commented on a change in pull request #8265: Fixed korean translation error. URL: https://github.com/apache/incubator-superset/pull/8265#discussion_r326580235 ## File path: superset/translations/ko/LC_MESSAGES/messages.po ## @@ -917,4027 +917,3125 @@ msgstr

[GitHub] [incubator-superset] kuckjwi0928 opened a new issue #8266: Histogram visualization error when using numeric type.

2019-09-20 Thread GitBox
kuckjwi0928 opened a new issue #8266: Histogram visualization error when using numeric type. URL: https://github.com/apache/incubator-superset/issues/8266 Histogram visualization error when using numeric type. Query parameter e.g. Numeric Columns: Numeric type columns

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8266: Histogram visualization error when using numeric type.

2019-09-20 Thread GitBox
issue-label-bot[bot] commented on issue #8266: Histogram visualization error when using numeric type. URL: https://github.com/apache/incubator-superset/issues/8266#issuecomment-533435233 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.98.

[GitHub] [incubator-superset] kuckjwi0928 commented on issue #8266: Histogram visualization error when using numeric type.

2019-09-20 Thread GitBox
kuckjwi0928 commented on issue #8266: Histogram visualization error when using numeric type. URL: https://github.com/apache/incubator-superset/issues/8266#issuecomment-533437162 This problem will be solved by checking the instance of numeric type.

[GitHub] [incubator-superset] kuckjwi0928 commented on issue #8077: Fixed Histogram visualization bug.

2019-09-20 Thread GitBox
kuckjwi0928 commented on issue #8077: Fixed Histogram visualization bug. URL: https://github.com/apache/incubator-superset/pull/8077#issuecomment-533439189 @villebro I will soon open a PR that has solved this problem properly. related issue :

[GitHub] [incubator-superset] Mikky72 opened a new issue #8267: radio or checkbox in filter-box

2019-09-20 Thread GitBox
Mikky72 opened a new issue #8267: radio or checkbox in filter-box URL: https://github.com/apache/incubator-superset/issues/8267 **Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8267: radio or checkbox in filter-box

2019-09-20 Thread GitBox
issue-label-bot[bot] commented on issue #8267: radio or checkbox in filter-box URL: https://github.com/apache/incubator-superset/issues/8267#issuecomment-533451443 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.89. Please mark this

[GitHub] [incubator-superset] kalimuthu123 commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells

2019-09-20 Thread GitBox
kalimuthu123 commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-533469493 yes row configuration was not merged yet ,u need to configure manually to get these options

[GitHub] [incubator-superset] CoryChaplin commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells

2019-09-20 Thread GitBox
CoryChaplin commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-533474806 The PR says that will not be merged as it is, it needs to be converted to a plugin before.

[GitHub] [incubator-superset] kuckjwi0928 closed issue #8263: Login Page Default Focus.

2019-09-20 Thread GitBox
kuckjwi0928 closed issue #8263: Login Page Default Focus. URL: https://github.com/apache/incubator-superset/issues/8263 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-superset] betodealmeida opened a new pull request #8268: Fix no data in Presto

2019-09-20 Thread GitBox
betodealmeida opened a new pull request #8268: Fix no data in Presto URL: https://github.com/apache/incubator-superset/pull/8268 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build /

[GitHub] [incubator-superset] dpgaspar commented on issue #8259: unable to display data table in sqlite

2019-09-20 Thread GitBox
dpgaspar commented on issue #8259: unable to display data table in sqlite URL: https://github.com/apache/incubator-superset/issues/8259#issuecomment-533475571 I don't think we have some sort of bug here, if it's fine by you, please close this issue

[GitHub] [incubator-superset] dpgaspar commented on issue #8263: Login Page Default Focus.

2019-09-20 Thread GitBox
dpgaspar commented on issue #8263: Login Page Default Focus. URL: https://github.com/apache/incubator-superset/issues/8263#issuecomment-533478675 Hi @kuckjwi0928, The login page is implemented by flask-appbuilder. please close this issue here and open a new one there. Thks

[GitHub] [incubator-superset] dpgaspar commented on issue #8260: contrib/docker doesnt support corporate environment/proxy

2019-09-20 Thread GitBox
dpgaspar commented on issue #8260: contrib/docker doesnt support corporate environment/proxy URL: https://github.com/apache/incubator-superset/issues/8260#issuecomment-533479876 Hi @dprophet, Can you please try: https://docs.docker.com/network/proxy/

[GitHub] [incubator-superset] betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-20 Thread GitBox
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-533595765 Thanks, @graceguo-supercat. Fixing it, sorry for the trouble.

[GitHub] [incubator-superset] stale[bot] commented on issue #7272: Mapbox data visualization doesn't work

2019-09-20 Thread GitBox
stale[bot] commented on issue #7272: Mapbox data visualization doesn't work URL: https://github.com/apache/incubator-superset/issues/7272#issuecomment-533600833 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further

[GitHub] [incubator-superset] stale[bot] commented on issue #7913: Druid most recent data using subquery filter for max(__time)

2019-09-20 Thread GitBox
stale[bot] commented on issue #7913: Druid most recent data using subquery filter for max(__time) URL: https://github.com/apache/incubator-superset/issues/7913#issuecomment-533600840 This issue has been automatically marked as stale because it has not had recent activity. It will be

[GitHub] [incubator-superset] marmikcfc commented on issue #7381: Hanging during Docker webpack build

2019-09-20 Thread GitBox
marmikcfc commented on issue #7381: Hanging during Docker webpack build URL: https://github.com/apache/incubator-superset/issues/7381#issuecomment-533597219 Hi, to whomsoever it may help, I was able to get it working after increasing the total runtime memory available to docker from 2GB

[GitHub] [incubator-superset] stale[bot] closed issue #6883: superset 0.28.1 integrated echarts method

2019-09-20 Thread GitBox
stale[bot] closed issue #6883: superset 0.28.1 integrated echarts method URL: https://github.com/apache/incubator-superset/issues/6883 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] betodealmeida merged pull request #8268: Fix no data in Presto

2019-09-20 Thread GitBox
betodealmeida merged pull request #8268: Fix no data in Presto URL: https://github.com/apache/incubator-superset/pull/8268 This is an automated message from the Apache Git Service. To respond to the message, please log on to