[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-03-04 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r387812429 ## File path: superset/datasets/dao.py ## @@ -0,0 +1,119 @@ +# Licensed to the Apache Software

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-03-03 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r387163227 ## File path: superset/datasets/dao.py ## @@ -0,0 +1,119 @@ +# Licensed to the Apache Software

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-03-03 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r387161596 ## File path: superset/datasets/commands/create.py ## @@ -0,0 +1,82 @@ +# Licensed to the Apac

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379430544 ## File path: superset/datasets/commands/delete.py ## @@ -0,0 +1,49 @@ +# Licensed to the Apac

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379418836 ## File path: superset/datasets/dao.py ## @@ -0,0 +1,119 @@ +# Licensed to the Apache Software

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379425525 ## File path: tests/dataset_api_tests.py ## @@ -0,0 +1,445 @@ +# Licensed to the Apache Softwa

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379422828 ## File path: tests/dataset_api_tests.py ## @@ -0,0 +1,445 @@ +# Licensed to the Apache Softwa

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379418836 ## File path: superset/datasets/dao.py ## @@ -0,0 +1,119 @@ +# Licensed to the Apache Software

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379416111 ## File path: superset/datasets/commands/update.py ## @@ -0,0 +1,83 @@ +# Licensed to the Apac

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379414952 ## File path: superset/datasets/commands/delete.py ## @@ -0,0 +1,57 @@ +# Licensed to the Apac

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379414508 ## File path: superset/datasets/commands/delete.py ## @@ -0,0 +1,49 @@ +# Licensed to the Apac

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379412720 ## File path: superset/commands/base.py ## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379412720 ## File path: superset/commands/base.py ## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern

2020-02-14 Thread GitBox
dpgaspar commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379384670 ## File path: superset/datasets/commands/create.py ## @@ -0,0 +1,82 @@ +# Licensed to the Apac