[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8054: [sql lab] persist tables list in localStorage
graceguo-supercat commented on a change in pull request #8054: [sql lab]
persist tables list in localStorage
URL:
https://github.com/apache/incubator-superset/pull/8054#discussion_r314538069
##
File path: superset/assets/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
##
@@ -21,9 +21,11 @@ import { LOCALSTORAGE_MAX_QUERY_AGE_MS } from
'../constants';
const PERSISTENT_QUERY_EDITOR_KEYS = new Set([
'autorun',
'dbId',
+ 'height',
Review comment:
Hey btw, i found a bug in master branch: it seems should use `northPercent`,
`southPercent` instead of height values. Currently we lost the size settings
after user resized panel. Not only in localStorage, if user switch tabs, the
size doesn't persist in redux state either.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8054: [sql lab] persist tables list in localStorage
graceguo-supercat commented on a change in pull request #8054: [sql lab]
persist tables list in localStorage
URL:
https://github.com/apache/incubator-superset/pull/8054#discussion_r314538069
##
File path: superset/assets/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
##
@@ -21,9 +21,11 @@ import { LOCALSTORAGE_MAX_QUERY_AGE_MS } from
'../constants';
const PERSISTENT_QUERY_EDITOR_KEYS = new Set([
'autorun',
'dbId',
+ 'height',
Review comment:
Hey btw, i found a bug in master branch: it seems should use `northPercent`,
`southPercent` instead of height values.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8054: [sql lab] persist tables list in localStorage
graceguo-supercat commented on a change in pull request #8054: [sql lab]
persist tables list in localStorage
URL:
https://github.com/apache/incubator-superset/pull/8054#discussion_r314535744
##
File path: superset/assets/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
##
@@ -21,9 +21,11 @@ import { LOCALSTORAGE_MAX_QUERY_AGE_MS } from
'../constants';
const PERSISTENT_QUERY_EDITOR_KEYS = new Set([
'autorun',
'dbId',
+ 'height',
Review comment:
this is used by sql editor resize function. if user resize editing area vs
results area, this props saves user's setting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
