[GitHub] [superset] codecov[bot] edited a comment on pull request #15166: feat(trino): add support for query cost estimate

2021-06-15 Thread GitBox 


codecov[bot] edited a comment on pull request #15166:
URL: https://github.com/apache/superset/pull/15166#issuecomment-861212006


   # 
[Codecov](https://codecov.io/gh/apache/superset/pull/15166?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#15166](https://codecov.io/gh/apache/superset/pull/15166?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (2497ae7) into 
[master](https://codecov.io/gh/apache/superset/commit/66282c331363887c0da486bc68976a6c350e8645?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (66282c3) will **decrease** coverage by `0.08%`.
   > The diff coverage is `22.85%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/superset/pull/15166/graphs/tree.svg?width=650=150=pr=KsB0fHcx6l_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/15166?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master   #15166  +/-   ##
   ==
   - Coverage   77.62%   77.54%   -0.09% 
   ==
 Files 963  963  
 Lines   4931649423 +107 
 Branches 6228 6228  
   ==
   + Hits3828438325  +41 
   - Misses  1083310899  +66 
 Partials  199  199  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `81.34% <22.85%> (-0.02%)` | :arrow_down: |
   | mysql | `81.62% <22.85%> (-0.03%)` | :arrow_down: |
   | postgres | `81.63% <22.85%> (-0.03%)` | :arrow_down: |
   | presto | `?` | |
   | python | `82.01% <22.85%> (-0.18%)` | :arrow_down: |
   | sqlite | `81.27% <22.85%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/superset/pull/15166?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5)
 | `59.72% <22.85%> (-35.02%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==)
 | `84.42% <0.00%> (-5.90%)` | :arrow_down: |
   | 
[superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==)
 | `93.50% <0.00%> (-5.20%)` | :arrow_down: |
   | 
[superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==)
 | `88.23% <0.00%> (-3.93%)` | :arrow_down: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `88.38% <0.00%> (-1.38%)` | :arrow_down: |
   | 
[superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=)
 | `83.27% <0.00%> (-1.05%)` | :arrow_down: |
   | 
[superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==)
 | `95.23% <0.00%> (-0.81%)` | :arrow_down: |
   |

[GitHub] [superset] codecov[bot] edited a comment on pull request #15166: feat(trino): add support for query cost estimate

2021-06-15 Thread GitBox 


codecov[bot] edited a comment on pull request #15166:
URL: https://github.com/apache/superset/pull/15166#issuecomment-861212006


   # 
[Codecov](https://codecov.io/gh/apache/superset/pull/15166?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#15166](https://codecov.io/gh/apache/superset/pull/15166?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (2497ae7) into 
[master](https://codecov.io/gh/apache/superset/commit/66282c331363887c0da486bc68976a6c350e8645?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (66282c3) will **decrease** coverage by `0.08%`.
   > The diff coverage is `22.85%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/superset/pull/15166/graphs/tree.svg?width=650=150=pr=KsB0fHcx6l_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/15166?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master   #15166  +/-   ##
   ==
   - Coverage   77.62%   77.54%   -0.09% 
   ==
 Files 963  963  
 Lines   4931649423 +107 
 Branches 6228 6228  
   ==
   + Hits3828438325  +41 
   - Misses  1083310899  +66 
 Partials  199  199  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `81.34% <22.85%> (-0.02%)` | :arrow_down: |
   | mysql | `81.62% <22.85%> (-0.03%)` | :arrow_down: |
   | postgres | `81.63% <22.85%> (-0.03%)` | :arrow_down: |
   | presto | `?` | |
   | python | `82.01% <22.85%> (-0.18%)` | :arrow_down: |
   | sqlite | `81.27% <22.85%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/superset/pull/15166?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5)
 | `59.72% <22.85%> (-35.02%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==)
 | `84.42% <0.00%> (-5.90%)` | :arrow_down: |
   | 
[superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==)
 | `93.50% <0.00%> (-5.20%)` | :arrow_down: |
   | 
[superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==)
 | `88.23% <0.00%> (-3.93%)` | :arrow_down: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `88.38% <0.00%> (-1.38%)` | :arrow_down: |
   | 
[superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=)
 | `83.27% <0.00%> (-1.05%)` | :arrow_down: |
   | 
[superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==)
 | `95.23% <0.00%> (-0.81%)` | :arrow_down: |
   |

[GitHub] [superset] codecov[bot] edited a comment on pull request #15166: feat(trino): add support for query cost estimate

2021-06-15 Thread GitBox 


codecov[bot] edited a comment on pull request #15166:
URL: https://github.com/apache/superset/pull/15166#issuecomment-861212006


   # 
[Codecov](https://codecov.io/gh/apache/superset/pull/15166?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#15166](https://codecov.io/gh/apache/superset/pull/15166?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (2497ae7) into 
[master](https://codecov.io/gh/apache/superset/commit/66282c331363887c0da486bc68976a6c350e8645?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (66282c3) will **decrease** coverage by `0.23%`.
   > The diff coverage is `22.85%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/superset/pull/15166/graphs/tree.svg?width=650=150=pr=KsB0fHcx6l_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/15166?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master   #15166  +/-   ##
   ==
   - Coverage   77.62%   77.39%   -0.24% 
   ==
 Files 963  963  
 Lines   4931649423 +107 
 Branches 6228 6228  
   ==
   - Hits3828438249  -35 
   - Misses  1083310975 +142 
 Partials  199  199  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `81.62% <22.85%> (-0.03%)` | :arrow_down: |
   | postgres | `81.63% <22.85%> (-0.03%)` | :arrow_down: |
   | presto | `?` | |
   | python | `81.72% <22.85%> (-0.47%)` | :arrow_down: |
   | sqlite | `81.27% <22.85%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/superset/pull/15166?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5)
 | `59.72% <22.85%> (-35.02%)` | :arrow_down: |
   | 
[superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5)
 | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=)
 | `70.32% <0.00%> (-17.08%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==)
 | `83.36% <0.00%> (-6.95%)` | :arrow_down: |
   | 
[superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==)
 | `93.50% <0.00%> (-5.20%)` | :arrow_down: |
   | 
[superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==)
 | `88.23% <0.00%> (-3.93%)` | :arrow_down: |
   | 
[superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5)
 | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
   |

[GitHub] [superset] codecov[bot] edited a comment on pull request #15166: feat(trino): add support for query cost estimate

2021-06-15 Thread GitBox 


codecov[bot] edited a comment on pull request #15166:
URL: https://github.com/apache/superset/pull/15166#issuecomment-861212006


   # 
[Codecov](https://codecov.io/gh/apache/superset/pull/15166?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#15166](https://codecov.io/gh/apache/superset/pull/15166?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (2497ae7) into 
[master](https://codecov.io/gh/apache/superset/commit/66282c331363887c0da486bc68976a6c350e8645?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (66282c3) will **decrease** coverage by `0.24%`.
   > The diff coverage is `22.85%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/superset/pull/15166/graphs/tree.svg?width=650=150=pr=KsB0fHcx6l_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/15166?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master   #15166  +/-   ##
   ==
   - Coverage   77.62%   77.38%   -0.25% 
   ==
 Files 963  963  
 Lines   4931649395  +79 
 Branches 6228 6228  
   ==
   - Hits3828438222  -62 
   - Misses  1083310974 +141 
 Partials  199  199  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `81.62% <22.85%> (-0.03%)` | :arrow_down: |
   | postgres | `81.62% <22.85%> (-0.05%)` | :arrow_down: |
   | presto | `?` | |
   | python | `81.71% <22.85%> (-0.49%)` | :arrow_down: |
   | sqlite | `81.27% <22.85%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/superset/pull/15166?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5)
 | `59.72% <22.85%> (-35.02%)` | :arrow_down: |
   | 
[superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5)
 | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=)
 | `70.32% <0.00%> (-17.08%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==)
 | `83.36% <0.00%> (-6.95%)` | :arrow_down: |
   | 
[superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==)
 | `93.50% <0.00%> (-5.20%)` | :arrow_down: |
   | 
[superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==)
 | `88.23% <0.00%> (-3.93%)` | :arrow_down: |
   | 
[superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/15166/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==)
 | `75.63% <0.00%> (-2.35%)` | :arrow_down: |
   |