[GitHub] [superset] codecov[bot] edited a comment on pull request #15177: feat(trino): add support for query cost estimate #15166
codecov[bot] edited a comment on pull request #15177: URL: https://github.com/apache/superset/pull/15177#issuecomment-861785984 # [Codecov](https://codecov.io/gh/apache/superset/pull/15177?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15177](https://codecov.io/gh/apache/superset/pull/15177?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0e3a64f) into [master](https://codecov.io/gh/apache/superset/commit/7dc0cee5be33848f46e443fcf3181b605811945b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (7dc0cee) will **decrease** coverage by `0.09%`. > The diff coverage is `22.85%`. > :exclamation: Current head 0e3a64f differs from pull request most recent head 472a2bc. Consider uploading reports for the commit 472a2bc to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15177?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15177 +/- ## == - Coverage 77.40% 77.31% -0.10% == Files 969 969 Lines 5001350047 +34 Branches 6431 6431 == - Hits3871238692 -20 - Misses 1109811152 +54 Partials 203 203 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.62% <22.85%> (-0.08%)` | :arrow_down: | | postgres | `81.63% <22.85%> (-0.08%)` | :arrow_down: | | presto | `81.34% <22.85%> (?)` | | | python | `81.91% <22.85%> (-0.19%)` | :arrow_down: | | sqlite | `81.27% <22.85%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15177?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `59.72% <22.85%> (-35.02%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.93% <0.00%> (-0.13%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `90.02% <0.00%> (+0.26%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.57% <0.00%> (+1.18%)` | :arrow_up: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `90.31% <0.00%> (+5.89%)` | :arrow_up: | -- [Continue to review full report at
[GitHub] [superset] codecov[bot] edited a comment on pull request #15177: feat(trino): add support for query cost estimate #15166
codecov[bot] edited a comment on pull request #15177: URL: https://github.com/apache/superset/pull/15177#issuecomment-861785984 # [Codecov](https://codecov.io/gh/apache/superset/pull/15177?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15177](https://codecov.io/gh/apache/superset/pull/15177?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0e3a64f) into [master](https://codecov.io/gh/apache/superset/commit/7dc0cee5be33848f46e443fcf3181b605811945b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (7dc0cee) will **decrease** coverage by `0.19%`. > The diff coverage is `22.85%`. > :exclamation: Current head 0e3a64f differs from pull request most recent head 472a2bc. Consider uploading reports for the commit 472a2bc to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15177?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15177 +/- ## == - Coverage 77.40% 77.21% -0.20% == Files 969 969 Lines 5001350047 +34 Branches 6431 6431 == - Hits3871238643 -69 - Misses 1109811201 +103 Partials 203 203 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.62% <22.85%> (-0.08%)` | :arrow_down: | | postgres | `81.63% <22.85%> (-0.08%)` | :arrow_down: | | python | `81.72% <22.85%> (-0.37%)` | :arrow_down: | | sqlite | `81.27% <22.85%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15177?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `59.72% <22.85%> (-35.02%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15177/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-0.24%)` | :arrow_down: | |
