[GitHub] jaylindquist commented on issue #5269: Filters as a native dashboard (v2) construct
jaylindquist commented on issue #5269: Filters as a native dashboard (v2)
construct
URL:
https://github.com/apache/incubator-superset/issues/5269#issuecomment-445968034
Due to our changing priorities, we have been unable to complete the
dashboard level filters feature. You can find our in progress work on my
feature branch
(https://github.com/jaylindquist/incubator-superset/tree/feature/native-filter)
and I can create a PR if you are interested in keeping what we've been able to
start.
Completed tasks:
* Add a drag-and-drop filters container at the top of dashboards
* Add filters to the filter container (filters are added, but configuration
is hard coded)
* Remove filters from container
* Remove filters container from dashboard
* Update Dashboard short links to create `preselect_filters` parameter
without chart IDs. URL short links are now generated as `{ "column1": ["val1"],
"column2": ["val2", "val3"] }`
* Update `preselect_filters` parameter to support filters without chart IDs
while being backwards compatible. `preselect_filters` now supports the above
format as well as the existing format `{ "chartId1": { "column1": ["val1"]},
"chartId2": { "column2": ["val2", "val3"]}}`
The following shows adding filters to an existing dashboard:
There is still work to be done:
* Creating a modal to add new filters
* Manage date filters for each datasource
* Global filter configuration (for example, instant filtering)
* Saving selected filter options when the dashboard is saved
If you would like me to create a PR for this work, let me know. I apologize
for not being able to complete the feature, but other tasks took priority for
us.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] jaylindquist commented on issue #5269: Filters as a native dashboard (v2) construct
jaylindquist commented on issue #5269: Filters as a native dashboard (v2) construct URL: https://github.com/apache/incubator-superset/issues/5269#issuecomment-433407446 I apologize for the lack of updates on this. Our team hit a series of emergencies that took priority over the filter changes. We've only now been able to start the work. Changes will be going into my forked at https://github.com/jaylindquist/incubator-superset/tree/feature/native-filter This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] jaylindquist commented on issue #5269: Filters as a native dashboard (v2) construct
jaylindquist commented on issue #5269: Filters as a native dashboard (v2) construct URL: https://github.com/apache/incubator-superset/issues/5269#issuecomment-412535393 @mistercrunch @graceguo-supercat Just pinging to see if there is any other feedback before we start planning our implementation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] jaylindquist commented on issue #5269: Filters as a native dashboard (v2) construct
jaylindquist commented on issue #5269: Filters as a native dashboard (v2) construct URL: https://github.com/apache/incubator-superset/issues/5269#issuecomment-412109988 @graceguo-supercat Today superset has a "Time Column" for filters that it uses to manage which column to filter on. I'm not sure how a generic time filter would work. For instance, a table of events that have a start_date column and end_date column. If a user wanted to filter on all events starting in January, they wouldn't want the filter to apply to the end_date column as well. They would need to specify which column(s) the time range should apply to. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] jaylindquist commented on issue #5269: Filters as a native dashboard (v2) construct
jaylindquist commented on issue #5269: Filters as a native dashboard (v2)
construct
URL:
https://github.com/apache/incubator-superset/issues/5269#issuecomment-411389249
@mistercrunch
We would like to add a proposal for the native dashboard filter as outlined
in the first post. We are looking for feedback and approval before implementing.
### Dashboard changes
* Global filters will be the focus of the MVP
* Tab and section filters would work similarly but will not be included
in the initial implementation. The initial focus will be to replace the
existing Filter Box chart with a native, global dashboard filter
* The filter component is drag & drop from the insert panel, similar to tabs
* Global filters go above dashboard-level tabs and below the dashboard
title (see images below for an example)
* Tab filters go below tabs
* Section filters go at the top of the section
* New filters can be added when the dashboard is in "Edit Mode" via a button
that appears after the list of filters
* Individual filters are added based on datasource / column name
* Clicking the New Filter button will open a modal with "Data Source"
and "Column" options to select the filter column
* If the column selected is a time column, the 'Since' / 'Until' filters
will be added
* Filter controls for the dashboard are initially collapsed and can be
expanded / collapsed as needed (see images below for an example)
* Additional options such as timegrain and instant filtering are added via
the configuration cog
### Chart changes
* Filter box will be removed as a chart type
* Filter boxes that are currently included in dashboards will need to be
removed from the dashboard and options will be added as global filter options
* All existing filter box charts are deleted (not sure what else can be done
with them since they can't be added to dashboards anymore)
### URL changes
* The `preselect_filters` query parameter can still be used to fill in
filters via a link. It is currently a map which includes the Filter Box ID. The
format will need to change into a map of column name to arrays instead
* Old format
```json
{
"414": {
"column1": [
"value1",
"value2"
]
},
"12": {
"column2": [
"value3"
]
}
}
```
* New format
```json
{
"column1": [
"value1",
"value2"
],
"column2": [
"value3"
]
}
```
* This change can be made backwards compatible by collecting the filters
in the old format, ignoring the ID, and applying the filter values based on the
column name
### Dashboard mockups
*Collapsed filters*
*Opened filters*
*New filter dialog*
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
