[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-29 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r191592826 ## File path: tests/celery_tests.py ## @@ -196,13 +196,11 @@ def

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-23 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r190459975 ## File path: superset/sql_lab.py ## @@ -171,6 +171,8 @@ def

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189134922 ## File path: superset/utils.py ## @@ -841,3 +841,17 @@ def

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189043405 ## File path: superset/sql_lab.py ## @@ -171,6 +171,7 @@ def

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189043307 ## File path: superset/sql_lab.py ## @@ -185,7 +186,8 @@ def