Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
rusackas merged PR #36908: URL: https://github.com/apache/superset/pull/36908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
bito-code-review[bot] commented on code in PR #36908: URL: https://github.com/apache/superset/pull/36908#discussion_r2663704161 ## superset-frontend/netlify.toml: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Netlify configuration for Superset Storybook +# Deployed at: superset-storybook.netlify.app + +[build] + base = "superset-frontend" + command = "npm install && npm run build-storybook" + publish = "storybook-static" + # Skip builds when no relevant frontend changes + # Rebuilds on: component files, storybook config, dependencies + ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF -- src/ packages/ plugins/ .storybook/ package.json yarn.lock" Review Comment: Config Inconsistency The ignore command references 'yarn.lock', but superset-frontend uses npm with 'package-lock.json'. This could cause incorrect build skipping behavior on Netlify. Code Review Run #762d60 --- Should Bito avoid suggestions like this for future reviews? (https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
bito-code-review[bot] commented on PR #36908: URL: https://github.com/apache/superset/pull/36908#issuecomment-3713200208 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). Bito Usage Guide **Commands** Type the following command in the pull request comment and save the comment. - `/review` - Manually triggers a full AI review. - `/pause` - Pauses automatic reviews on this pull request. - `/resume` - Resumes automatic reviews. - `/resolve` - Marks all Bito-posted review comments as resolved. - `/abort` - Cancels all in-progress reviews. Refer to the https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands"; target="_blank" rel="noopener noreferrer">documentation for additional commands. **Configuration** This repository uses `Superset` You can customize the agent settings https://alpha.bito.ai/home/ai-agents/code-review-agent"; target="_blank" rel="noopener noreferrer">here or contact your Bito workspace admin at [email protected]. **Documentation & Help** - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance"; target="_blank" rel="noopener noreferrer">Customize agent settings - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules"; target="_blank" rel="noopener noreferrer">Review rules - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent"; target="_blank" rel="noopener noreferrer">General documentation - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs"; target="_blank" rel="noopener noreferrer">FAQ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
netlify[bot] commented on PR #36908: URL: https://github.com/apache/superset/pull/36908#issuecomment-3713107676 ### 👷 Deploy Preview for *superset-docs-preview* processing. | Name | Link | |:-:|| |🔨 Latest commit | f4de78345d617009a1c0a52238bb65c22e50ac74 | |🔍 Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/695c95254a4f0d0008eef27d | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
bito-code-review[bot] commented on code in PR #36908: URL: https://github.com/apache/superset/pull/36908#discussion_r2663366266 ## docs/netlify.toml: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Netlify configuration for Superset documentation +# This enables automatic deploy previews for PRs that modify docs + +[build] + # Base directory is the docs folder + base = "docs" + # Build command for Docusaurus + command = "yarn install && yarn build" + # Output directory (relative to base) + publish = "build" + +[build.environment] + # Node version matching docs/.nvmrc + NODE_VERSION = "20" + # Yarn version + YARN_VERSION = "1.22.22" + +# Deploy preview settings +[context.deploy-preview] + command = "yarn install && yarn build" + +# Branch deploy settings (for feature branches) +[context.branch-deploy] + command = "yarn install && yarn build" + +# Redirect /docs to the main docs page +[[redirects]] Review Comment: Incorrect redirect configuration The redirect from "/docs" to "/docs/intro" appears incorrect for a documentation site; typically, the root "/" should redirect to the main docs page "/docs/intro" to provide a clean entry point, rather than redirecting the docs index itself. Code Review Run #112bd9 --- Should Bito avoid suggestions like this for future reviews? (https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
codeant-ai-for-open-source[bot] commented on PR #36908: URL: https://github.com/apache/superset/pull/36908#issuecomment-3712837153 ## **Sequence Diagram** This PR adds a Netlify configuration so that pull requests which change docs/ trigger an automatic Netlify build and a deploy-preview URL posted back to the PR, enabling reviewers to view docs changes without local builds. ```mermaid sequenceDiagram participant Contributor participant GitHub_PR as "GitHub PR" participant Netlify participant Reviewer Contributor->>GitHub_PR: Open PR that modifies docs/** GitHub_PR->>Netlify: Trigger deploy-preview (webhook/CI integration) Netlify->>Netlify: Build site using base=docs, command "yarn install && yarn build", publish=build Netlify-->>GitHub_PR: Post deploy-preview URL (check/comment) Reviewer->>GitHub_PR: Click preview URL and review docs site ``` --- *Generated by [CodeAnt AI](https://codeant.ai)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
codeant-ai-for-open-source[bot] commented on PR #36908: URL: https://github.com/apache/superset/pull/36908#issuecomment-3712837710 ## 💡 Enhance Your PR Reviews We noticed that **3 feature(s)** are not configured for this repository. Enabling these features can help improve your code quality and workflow: ### 🚦 Quality Gates **Status:** Quality Gates are not enabled at the organization level Learn more about [Quality Gates](https://docs.codeant.ai/quality-gates) ### 🎫 Jira Ticket Compliance **Status:** Jira credentials file not found. Please configure Jira integration in your settings Learn more about [Jira Integration](https://docs.codeant.ai/integrations/jira) ### ⚙️ Custom Rules **Status:** No custom rules configured. Add rules via organization settings or .codeant/review.json in your repository Learn more about [Custom Rules](https://docs.codeant.ai/custom-rules) --- **Want to enable these features?** Contact your organization admin or check our documentation for setup instructions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
codeant-ai-for-open-source[bot] commented on PR #36908: URL: https://github.com/apache/superset/pull/36908#issuecomment-3712837650 CodeAnt AI finished reviewing your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
bito-code-review[bot] commented on PR #36908: URL: https://github.com/apache/superset/pull/36908#issuecomment-3712834694 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: add Netlify configuration for PR deploy previews [superset]
codeant-ai-for-open-source[bot] commented on PR #36908: URL: https://github.com/apache/superset/pull/36908#issuecomment-3712834525 CodeAnt AI is reviewing your PR. --- ### Thanks for using CodeAnt! 🎉 We're free for open-source projects. if you're enjoying it, help us grow by sharing. [Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) · [Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) · [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
