Re: [PR] fix(plugin-chart-table): keep the configured page size under server pagination [superset]

2026-09-21 Thread via GitHub 


rusackas closed pull request #43194: fix(plugin-chart-table): keep the 
configured page size under server pagination
URL: https://github.com/apache/superset/pull/43194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(plugin-chart-table): keep the configured page size under server pagination [superset]

2026-09-21 Thread via GitHub 


rusackas commented on PR #43194:
URL: https://github.com/apache/superset/pull/43194#issuecomment-5769202540

   Closing this one, sorry for the delay getting back to it. While rebasing I 
traced the conflicts and this turns out to be superseded: #42248 fixed the same 
issue (#42243) independently and already merged on the 15th. I compared the two 
— master's version keeps the configured `serverPageLength` selectable and snaps 
to the nearest valid option with a proper fallback, which covers what this PR 
does and then some.
   
   Thanks for tracking this down originally. Reopen if I'm misreading something 
or there's a case this PR still handles that #42248 doesn't.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(plugin-chart-table): keep the configured page size under server pagination [superset]

2026-09-09 Thread via GitHub 


rusackas commented on PR #43194:
URL: https://github.com/apache/superset/pull/43194#issuecomment-5606402113

   @bikash-barnwal mind resolving the conflicts? Then we can merge :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(plugin-chart-table): keep the configured page size under server pagination [superset]

2026-09-08 Thread via GitHub 


rusackas commented on PR #43194:
URL: https://github.com/apache/superset/pull/43194#issuecomment-5589015182

   Holler if you need a hand resolving the conflicts here. Can't merge without 
that being tended to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(plugin-chart-table): keep the configured page size under server pagination [superset]

2026-08-27 Thread via GitHub 


rusackas commented on PR #43194:
URL: https://github.com/apache/superset/pull/43194#issuecomment-5448549296

   @bikash-barnwal LGTM! That two-part fallback interaction was sneaky to 
catch, nice work tracking it down. Approving, but would love a second 
opinion... maybe @sbin2010 can check too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(plugin-chart-table): keep the configured page size under server pagination [superset]

2026-08-14 Thread via GitHub 


codecov[bot] commented on PR #43194:
URL: https://github.com/apache/superset/pull/43194#issuecomment-5298488279

   ## 
[Codecov](https://app.codecov.io/gh/apache/superset/pull/43194?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `87.5%` with `1 line` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 66.64%. Comparing base 
([`f458721`](https://app.codecov.io/gh/apache/superset/commit/f4587218dd19d046c3e4d00063e7d27f8a2ed354?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`bbe4bbd`](https://app.codecov.io/gh/apache/superset/commit/bbe4bbdf924d7eb26446b7aaf83220edcadac8d8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/superset/pull/43194?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...ins/plugin-chart-table/src/DataTable/DataTable.tsx](https://app.codecov.io/gh/apache/superset/pull/43194?src=pr&el=tree&filepath=superset-frontend%2Fplugins%2Fplugin-chart-table%2Fsrc%2FDataTable%2FDataTable.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL0RhdGFUYWJsZS9EYXRhVGFibGUudHN4)
 | 50.00% | [1 Missing :warning: 
](https://app.codecov.io/gh/apache/superset/pull/43194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   
   ```diff
   @@   Coverage Diff   @@
   ##   master   #43194   +/-   ##
   ===
 Coverage   66.64%   66.64%   
   ===
 Files2873 2873   
 Lines  163625   163627+2 
 Branches3776737768+1 
   ===
   + Hits   109053   109055+2 
 Misses  5244252442   
 Partials 2130 2130   
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/superset/pull/43194/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[javascript](https://app.codecov.io/gh/apache/superset/pull/43194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `73.76% <87.50%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   [:umbrella: View full report in Codecov by 
Harness](https://app.codecov.io/gh/apache/superset/pull/43194?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(plugin-chart-table): keep the configured page size under server pagination [superset]

2026-08-14 Thread via GitHub 


bito-code-review[bot] commented on PR #43194:
URL: https://github.com/apache/superset/pull/43194#issuecomment-5298384571

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a 
very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]