Re: [PR] fix(postprocessing): keep operation signatures visible through validate_column_args [superset]
rusackas commented on PR #43186: URL: https://github.com/apache/superset/pull/43186#issuecomment-5612470215 @bikash-barnwal thanks for this! Looks like the same `wraps` fix landed on `master` via #42927 shortly after this went up, which is also what's causing the conflict here. Tempted to close this as superseded, but holler if there's something still unique in this one that I'm missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix(postprocessing): keep operation signatures visible through validate_column_args [superset]
rusackas closed pull request #43186: fix(postprocessing): keep operation signatures visible through validate_column_args URL: https://github.com/apache/superset/pull/43186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix(postprocessing): keep operation signatures visible through validate_column_args [superset]
codecov[bot] commented on PR #43186: URL: https://github.com/apache/superset/pull/43186#issuecomment-5297970516 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43186?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 57.26%. Comparing base ([`0a7ebe1`](https://app.codecov.io/gh/apache/superset/commit/0a7ebe1dd1888cd8c19f3ad873651b5ab4d9ffb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`efef806`](https://app.codecov.io/gh/apache/superset/commit/efef8069eea7018df17734fec855c7165b60e202?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0a7ebe1) and HEAD (efef806). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (0a7ebe1) | HEAD (efef806) | >|--|--|--| >|python|24|2| >|presto|4|1| >|hive|4|1| > Additional details and impacted files ```diff @@Coverage Diff @@ ## master #43186 +/- ## == - Coverage 66.70% 57.26% -9.44% == Files2872 2873 +1 Lines 163447 163607 +160 Branches3772737763 +36 == - Hits 10902793692 -15335 - Misses 5229169026 +16735 + Partials 2129 889-1240 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/43186/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/43186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.17% <100.00%> (-0.05%)` | :arrow_down: | | [mysql](https://app.codecov.io/gh/apache/superset/pull/43186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/43186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/43186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.12% <100.00%> (-0.05%)` | :arrow_down: | | [python](https://app.codecov.io/gh/apache/superset/pull/43186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.17% <100.00%> (-19.18%)` | :arrow_down: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/43186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit](https://app.codecov.io/gh/apache/superset/pull/43186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43186?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To
Re: [PR] fix(postprocessing): keep operation signatures visible through validate_column_args [superset]
bito-code-review[bot] commented on PR #43186: URL: https://github.com/apache/superset/pull/43186#issuecomment-5297768800 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
