Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
sadpandajoe merged PR #36388: URL: https://github.com/apache/superset/pull/36388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
bito-code-review[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3751146578 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). Bito Usage Guide **Commands** Type the following command in the pull request comment and save the comment. - `/review` - Manually triggers a full AI review. - `/pause` - Pauses automatic reviews on this pull request. - `/resume` - Resumes automatic reviews. - `/resolve` - Marks all Bito-posted review comments as resolved. - `/abort` - Cancels all in-progress reviews. Refer to the https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands"; target="_blank" rel="noopener noreferrer">documentation for additional commands. **Configuration** This repository uses `Superset` You can customize the agent settings https://alpha.bito.ai/home/ai-agents/code-review-agent"; target="_blank" rel="noopener noreferrer">here or contact your Bito workspace admin at [email protected]. **Documentation & Help** - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance"; target="_blank" rel="noopener noreferrer">Customize agent settings - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules"; target="_blank" rel="noopener noreferrer">Review rules - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent"; target="_blank" rel="noopener noreferrer">General documentation - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs"; target="_blank" rel="noopener noreferrer">FAQ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
codeant-ai-for-open-source[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3750374441 CodeAnt AI Incremental review completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
codeant-ai-for-open-source[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3750371776 CodeAnt AI is running Incremental review --- ### Thanks for using CodeAnt! 🎉 We're free for open-source projects. if you're enjoying it, help us grow by sharing. [Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) · [Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) · [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
Antonio-RiveroMartnez commented on code in PR #36388:
URL: https://github.com/apache/superset/pull/36388#discussion_r2690935347
##
superset-frontend/oxlint.json:
##
@@ -14,7 +14,7 @@
},
"settings": {
"react": {
- "version": "detect"
+ "version": "17.0"
Review Comment:
is this intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
bito-code-review[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3739522626 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). Bito Usage Guide **Commands** Type the following command in the pull request comment and save the comment. - `/review` - Manually triggers a full AI review. - `/pause` - Pauses automatic reviews on this pull request. - `/resume` - Resumes automatic reviews. - `/resolve` - Marks all Bito-posted review comments as resolved. - `/abort` - Cancels all in-progress reviews. Refer to the https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands"; target="_blank" rel="noopener noreferrer">documentation for additional commands. **Configuration** This repository uses `Superset` You can customize the agent settings https://alpha.bito.ai/home/ai-agents/code-review-agent"; target="_blank" rel="noopener noreferrer">here or contact your Bito workspace admin at [email protected]. **Documentation & Help** - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance"; target="_blank" rel="noopener noreferrer">Customize agent settings - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules"; target="_blank" rel="noopener noreferrer">Review rules - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent"; target="_blank" rel="noopener noreferrer">General documentation - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs"; target="_blank" rel="noopener noreferrer">FAQ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
codeant-ai-for-open-source[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3739252834 CodeAnt AI is running Incremental review --- ### Thanks for using CodeAnt! 🎉 We're free for open-source projects. if you're enjoying it, help us grow by sharing. [Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) · [Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) · [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
geido commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3737801840 Hey @rebenitez1802 apparently some tests are still failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
bito-code-review[bot] commented on code in PR #36388:
URL: https://github.com/apache/superset/pull/36388#discussion_r2673444032
##
superset-frontend/packages/superset-ui-core/test/components/SafeMarkdown.test.tsx:
##
@@ -0,0 +1,167 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { render } from '@testing-library/react';
+import {
+ getOverrideHtmlSchema,
+ SafeMarkdown,
+} from '../../src/components/SafeMarkdown/SafeMarkdown';
+
+describe('getOverrideHtmlSchema', () => {
+ it('should append the override items', () => {
+const original = {
+ attributes: {
+'*': ['size'],
+ },
+ clobberPrefix: 'original-prefix',
+ tagNames: ['h1', 'h2', 'h3'],
+};
+const result = getOverrideHtmlSchema(original, {
+ attributes: { '*': ['src'], h1: ['style'] },
+ clobberPrefix: 'custom-prefix',
+ tagNames: ['iframe'],
+});
+expect(result.clobberPrefix).toEqual('custom-prefix');
+expect(result.attributes).toEqual({ '*': ['size', 'src'], h1: ['style'] });
+expect(result.tagNames).toEqual(['h1', 'h2', 'h3', 'iframe']);
+ });
+});
+
+describe('SafeMarkdown', () => {
+ describe('remark-gfm compatibility tests', () => {
+/**
+ * Critical regression test for remark-gfm v3.0.1 compatibility.
+ *
+ * CONTEXT:
+ * - remark-gfm v4+ requires unified v11 (react-markdown v9+, React 18+)
+ * - react-markdown v8 uses unified v10 (compatible with React 17)
+ * - Mixing remark-gfm v4 with react-markdown v8 causes:
+ * "Cannot set properties of undefined (setting 'inTable')" error
+ *
+ * HISTORY:
+ * - PR #32420 (March 2025): Fixed by pinning remark-gfm to v3
+ * - PR #32945 (July 2025): Dependabot auto-upgraded to v4, breaking tables
+ * - This test prevents future auto-upgrades from breaking functionality
+ *
+ * This test will FAIL if remark-gfm is upgraded to v4+ without upgrading
+ * react-markdown to v9+ (which requires React 18).
+ */
+it('should render GitHub Flavored Markdown tables without errors', () => {
Review Comment:
Async test synchronization removed
The SafeMarkdown component uses dynamic imports and setState for lazy
loading, making its rendering asynchronous. Removing async/await and waitFor
assumes synchronous behavior, but the component initially renders null and
updates after imports resolve. This will cause tests to fail as
container.innerHTML will be empty on first render.
Code Review Run #0e3032
---
Should Bito avoid suggestions like this for future reviews? (https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules)
- [ ] Yes, avoid them
##
superset-frontend/packages/superset-ui-core/test/components/SafeMarkdown.test.tsx:
##
@@ -0,0 +1,167 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { render } from '@testing-library/react';
+import {
+ getOverrideHtmlSchema,
+ SafeMarkdown,
+} from '../../src/components/SafeMarkdown/SafeMarkdown';
+
+describe('getOverrideHtmlSchema', () => {
+ it('should append the override items', () => {
+const original = {
+ attributes: {
+'*': ['size'],
+ },
+ clobberPrefix: 'original-prefix',
+ tagNames: ['h1', 'h2', 'h3'],
+};
+const result = getOverrideHtmlSchema(original, {
+ attributes: { '*': ['src'], h1: ['style'] }
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
bito-code-review[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3725121261 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). Bito Usage Guide **Commands** Type the following command in the pull request comment and save the comment. - `/review` - Manually triggers a full AI review. - `/pause` - Pauses automatic reviews on this pull request. - `/resume` - Resumes automatic reviews. - `/resolve` - Marks all Bito-posted review comments as resolved. - `/abort` - Cancels all in-progress reviews. Refer to the https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands"; target="_blank" rel="noopener noreferrer">documentation for additional commands. **Configuration** This repository uses `Superset` You can customize the agent settings https://alpha.bito.ai/home/ai-agents/code-review-agent"; target="_blank" rel="noopener noreferrer">here or contact your Bito workspace admin at [email protected]. **Documentation & Help** - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance"; target="_blank" rel="noopener noreferrer">Customize agent settings - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules"; target="_blank" rel="noopener noreferrer">Review rules - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent"; target="_blank" rel="noopener noreferrer">General documentation - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs"; target="_blank" rel="noopener noreferrer">FAQ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
bito-code-review[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3724846370 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). Bito Usage Guide **Commands** Type the following command in the pull request comment and save the comment. - `/review` - Manually triggers a full AI review. - `/pause` - Pauses automatic reviews on this pull request. - `/resume` - Resumes automatic reviews. - `/resolve` - Marks all Bito-posted review comments as resolved. - `/abort` - Cancels all in-progress reviews. Refer to the https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands"; target="_blank" rel="noopener noreferrer">documentation for additional commands. **Configuration** This repository uses `Superset` You can customize the agent settings https://alpha.bito.ai/home/ai-agents/code-review-agent"; target="_blank" rel="noopener noreferrer">here or contact your Bito workspace admin at [email protected]. **Documentation & Help** - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance"; target="_blank" rel="noopener noreferrer">Customize agent settings - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules"; target="_blank" rel="noopener noreferrer">Review rules - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent"; target="_blank" rel="noopener noreferrer">General documentation - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs"; target="_blank" rel="noopener noreferrer">FAQ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
bito-code-review[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3724523302 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). Bito Usage Guide **Commands** Type the following command in the pull request comment and save the comment. - `/review` - Manually triggers a full AI review. - `/pause` - Pauses automatic reviews on this pull request. - `/resume` - Resumes automatic reviews. - `/resolve` - Marks all Bito-posted review comments as resolved. - `/abort` - Cancels all in-progress reviews. Refer to the https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands"; target="_blank" rel="noopener noreferrer">documentation for additional commands. **Configuration** This repository uses `Superset` You can customize the agent settings https://alpha.bito.ai/home/ai-agents/code-review-agent"; target="_blank" rel="noopener noreferrer">here or contact your Bito workspace admin at [email protected]. **Documentation & Help** - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance"; target="_blank" rel="noopener noreferrer">Customize agent settings - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules"; target="_blank" rel="noopener noreferrer">Review rules - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent"; target="_blank" rel="noopener noreferrer">General documentation - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs"; target="_blank" rel="noopener noreferrer">FAQ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
codeant-ai-for-open-source[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3724247845 CodeAnt AI is running Incremental review --- ### Thanks for using CodeAnt! 🎉 We're free for open-source projects. if you're enjoying it, help us grow by sharing. [Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) · [Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) · [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
bito-code-review[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3720399955 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). Bito Usage Guide **Commands** Type the following command in the pull request comment and save the comment. - `/review` - Manually triggers a full AI review. - `/pause` - Pauses automatic reviews on this pull request. - `/resume` - Resumes automatic reviews. - `/resolve` - Marks all Bito-posted review comments as resolved. - `/abort` - Cancels all in-progress reviews. Refer to the https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands"; target="_blank" rel="noopener noreferrer">documentation for additional commands. **Configuration** This repository uses `Superset` You can customize the agent settings https://alpha.bito.ai/home/ai-agents/code-review-agent"; target="_blank" rel="noopener noreferrer">here or contact your Bito workspace admin at [email protected]. **Documentation & Help** - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance"; target="_blank" rel="noopener noreferrer">Customize agent settings - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules"; target="_blank" rel="noopener noreferrer">Review rules - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent"; target="_blank" rel="noopener noreferrer">General documentation - https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs"; target="_blank" rel="noopener noreferrer">FAQ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
netlify[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3720165639 ### ✅ Deploy Preview for *superset-docs-preview* ready! | Name | Link | |:-:|| |🔨 Latest commit | 15946de4e848d6866de16fd7ec59705490ce701b | |🔍 Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/695ea337f7edfb0008cd58b7 | |😎 Deploy Preview | [https://deploy-preview-36388--superset-docs-preview.netlify.app](https://deploy-preview-36388--superset-docs-preview.netlify.app) | |📱 Preview on mobile | Toggle QR Code... _Use your smartphone camera to open QR code link._ | --- _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
codeant-ai-for-open-source[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3720142701 CodeAnt AI is running Incremental review --- ### Thanks for using CodeAnt! 🎉 We're free for open-source projects. if you're enjoying it, help us grow by sharing. [Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) · [Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) · [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
rebenitez1802 commented on code in PR #36388: URL: https://github.com/apache/superset/pull/36388#discussion_r2586505300 ## .github/dependabot.yml: ## @@ -12,6 +12,9 @@ updates: # not until React >= 18.0.0 - dependency-name: "storybook" - dependency-name: "@storybook*" + # remark-gfm v4+ requires react-markdown v9+, which needs React 18 Review Comment: Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
codeant-ai-for-open-source[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3608666328 CodeAnt AI is running Incremental review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
rusackas commented on code in PR #36388: URL: https://github.com/apache/superset/pull/36388#discussion_r2586227749 ## .github/dependabot.yml: ## @@ -12,6 +12,9 @@ updates: # not until React >= 18.0.0 - dependency-name: "storybook" - dependency-name: "@storybook*" + # remark-gfm v4+ requires react-markdown v9+, which needs React 18 Review Comment: AHA! Maybe we can add a TODO comment in the relevant places this is imported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
rusackas commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3608286275 Is it possible to fix-forward so that we CAN upgrade? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
sadpandajoe commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3605089358 Are we sure this is the correct root cause? It looks like the dependabot bump happened 5 months ago and has been part of Superset 6.0.0rc1. Also can we add tests as this is a package bump and we won't know if this will break again in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
codeant-ai-for-open-source[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3604799039 CodeAnt AI finished reviewing your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
bito-code-review[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3604796738 AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix: pin remark-gfm to v3.0.1 for compatibility with react-markdown v8 [superset]
codeant-ai-for-open-source[bot] commented on PR #36388: URL: https://github.com/apache/superset/pull/36388#issuecomment-3604796403 CodeAnt AI is reviewing your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
