Re: [PR] feat: add test cases for revoking workflow access. [texera]

2026-02-09 Thread via GitHub 


aicam merged PR #4187:
URL: https://github.com/apache/texera/pull/4187


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] feat: add test cases for revoking workflow access. [texera]

2026-02-01 Thread via GitHub 


seongjinyoon commented on PR #4187:
URL: https://github.com/apache/texera/pull/4187#issuecomment-3832249935

   > Why a new test file?
   
   This is because it is related with the file WorkflowAccessResource.scala‎


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] feat: add test cases for revoking workflow access. [texera]

2026-01-31 Thread via GitHub 


carloea2 commented on PR #4187:
URL: https://github.com/apache/texera/pull/4187#issuecomment-3827926704

   Why a new test file?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] feat: add test cases for revoking workflow access. [texera]

2026-01-30 Thread via GitHub 


seongjinyoon commented on PR #4187:
URL: https://github.com/apache/texera/pull/4187#issuecomment-3825546963

   @aicam Please review this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

[PR] feat: add test cases for revoking workflow access. [texera]

2026-01-30 Thread via GitHub 


seongjinyoon opened a new pull request, #4187:
URL: https://github.com/apache/texera/pull/4187

   
   
   ### What changes were proposed in this PR?
   
   
   This PR adds test cases for the `revokeAccess()` method in 
`WorkflowAccessResourceSpec.scala`.
   
   **The test cases cover the following scenarios:**
   - Users with WRITE access can revoke other users' access.
   - Users with READ access cannot revoke other users' access.
   - Users can revoke their own access regardless of access level.
   - Owner's access cannot be revoked by others.
   - Owner cannot revoke their own access.
   - Error handling for non-existing users.
   - Revoking access does not affect other users' access level.
   - Revoke access of a user who does not have access.
   
   ### Any related issues, documentation, discussions?
   
   
   #4143 
   
   ### How was this PR tested?
   
   
   `sbt test`
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   
   revised with Claude Code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]